From 840374190243508c6e849abdab9631b61ff1c5cd Mon Sep 17 00:00:00 2001 From: unkin-agent Date: Wed, 12 Aug 2026 21:46:40 +1000 Subject: [PATCH] lint: check deferred resp.Body.Close error returns golangci-lint v2 (errcheck) flagged three unchecked resp.Body.Close() returns in gitea.go and vault.go. Wrap each deferred Close in a closure discarding the return, the idiomatic form for a deferred Close whose error is intentionally ignored. --- internal/agent/gitea.go | 2 +- internal/agent/vault.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/agent/gitea.go b/internal/agent/gitea.go index 74eb809..b454391 100644 --- a/internal/agent/gitea.go +++ b/internal/agent/gitea.go @@ -46,7 +46,7 @@ func (c *GiteaClient) do(method, path string, body any, out any) error { if err != nil { return err } - defer resp.Body.Close() + defer func() { _ = resp.Body.Close() }() data, _ := io.ReadAll(resp.Body) if resp.StatusCode < 200 || resp.StatusCode >= 300 { return fmt.Errorf("gitea %s %s: HTTP %d: %s", method, path, resp.StatusCode, strings.TrimSpace(string(data))) diff --git a/internal/agent/vault.go b/internal/agent/vault.go index b7f6b95..8fcd73b 100644 --- a/internal/agent/vault.go +++ b/internal/agent/vault.go @@ -29,7 +29,7 @@ func approleLogin(vaultAddr, roleID string) (string, error) { if err != nil { return "", fmt.Errorf("vault approle login: %w", err) } - defer resp.Body.Close() + defer func() { _ = resp.Body.Close() }() data, _ := io.ReadAll(resp.Body) if resp.StatusCode != http.StatusOK { return "", fmt.Errorf("vault approle login: HTTP %d: %s", resp.StatusCode, strings.TrimSpace(string(data))) @@ -62,7 +62,7 @@ func readGiteaCreds(vaultAddr, clientToken string) (string, error) { if err != nil { return "", fmt.Errorf("vault read %s: %w", GiteaCredsPath, err) } - defer resp.Body.Close() + defer func() { _ = resp.Body.Close() }() data, _ := io.ReadAll(resp.Body) if resp.StatusCode != http.StatusOK { return "", fmt.Errorf("vault read %s: HTTP %d: %s", GiteaCredsPath, resp.StatusCode, strings.TrimSpace(string(data)))