unkin/agent-tools
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 19 Wiki Activity

ci: authenticate artifactapi rpm upload with a vault token #27

Merged
benvin merged 1 commits from benvin/artifactapi-upload-token into main 2026-10-25 20:27:50 +11:00
Conversation 1 Commits 1 Files Changed 1
+8 -1
unkin-agent commented 2026-10-25 19:08:25 +11:00
Member
Copy Link
Copy Source

artifactapi is about to enforce auth on file uploads (ARTIFACTAPI_AUTH_UPLOADS), and the release upload currently PUTs anonymously.

  • mint an artifactapi-writer OIDC token via Vault k8s auth (role woodpecker_artifactapi_writer) using the step SA token
  • fail the step if minting fails (set -o pipefail)
  • send the token as Authorization: Bearer via a header file, never in argv or logs
artifactapi is about to enforce auth on file uploads (`ARTIFACTAPI_AUTH_UPLOADS`), and the release upload currently PUTs anonymously. - mint an `artifactapi-writer` OIDC token via Vault k8s auth (role `woodpecker_artifactapi_writer`) using the step SA token - fail the step if minting fails (`set -o pipefail`) - send the token as `Authorization: Bearer` via a header file, never in argv or logs
unkin-agent added 1 commit 2026-10-25 19:08:25 +11:00
ci: send vault-minted bearer token on artifactapi rpm upload
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
2d342bc463
unkin-agent commented 2026-10-25 19:09:21 +11:00
Author
Member
Copy Link
Copy Source
  • .woodpecker/release.yaml:124 — step runs as serviceAccountName: default, but the Vault role woodpecker_artifactapi_writer must bind that SA or login 403s and every release fails → confirm bound_service_account_names/namespace in terraform-vault matches default, or set a dedicated SA here and add it in argocd-apps.
  • nit: .woodpecker/release.yaml:101 — $$AUTH file holds the bearer token and is never removed → trap 'rm -f "$$AUTH"' EXIT after mktemp.
- .woodpecker/release.yaml:124 — step runs as `serviceAccountName: default`, but the Vault role `woodpecker_artifactapi_writer` must bind that SA or login 403s and every release fails → confirm `bound_service_account_names`/namespace in terraform-vault matches `default`, or set a dedicated SA here and add it in argocd-apps. - nit: .woodpecker/release.yaml:101 — `$$AUTH` file holds the bearer token and is never removed → `trap 'rm -f "$$AUTH"' EXIT` after mktemp.
benvin merged commit 78ed660066 into main 2026-10-25 20:27:50 +11:00
benvin deleted branch benvin/artifactapi-upload-token 2026-10-25 20:27:50 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/agent-tools#27
Delete Branch "benvin/artifactapi-upload-token"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?