From 49224d4a1bb3a4ad1537bbc8252b152b49b718f2 Mon Sep 17 00:00:00 2001
From: Ben Vincent <ben@unkin.net>
Date: Tue, 24 Mar 2026 18:51:46 +1100
Subject: [PATCH] fix: increase generate-types memory limit and remove invalid
 JVM env var (#74)

The container was OOMKilled on every run because the 256Mi limit was far
too low for `puppet generate types`. Remove PUPPETSERVER_JAVA_ARGS (only
relevant to the puppetserver JVM, not the puppet CLI) and raise the
memory limit to 1Gi / request 512Mi.

Reviewed-on: https://git.unkin.net/unkin/argocd-apps/pulls/74
---
 apps/base/puppet/cronjob_generate-types.yaml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/apps/base/puppet/cronjob_generate-types.yaml b/apps/base/puppet/cronjob_generate-types.yaml
index 8167823..72b2d1a 100644
--- a/apps/base/puppet/cronjob_generate-types.yaml
+++ b/apps/base/puppet/cronjob_generate-types.yaml
@@ -41,16 +41,14 @@ spec:
                     echo "Generating types for $env"
                     puppet generate types --environment "$env"
                   done
-              env:
-                - name: PUPPETSERVER_JAVA_ARGS
-                  value: -Xms1024m -Xmx3072m -Dcom.sun.management.jmxremote.port=31000 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false
+              env: []
               resources:
                 limits:
                   cpu: 300m
-                  memory: 256Mi
+                  memory: 1Gi
                 requests:
                   cpu: 200m
-                  memory: 128Mi
+                  memory: 512Mi
               securityContext:
                 runAsUser: 0
                 runAsNonRoot: false