unkin/argocd-apps
2
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(traefik): set controllerName on GatewayClasses and Traefik providers #135

Merged
unkinben merged 2 commits from benvin/fix-gatewayclass-controllernames into main 2026-05-22 23:44:07 +10:00
Conversation 0 Commits 2 Files Changed 4
+8 -2
unkinben commented 2026-05-22 23:35:14 +10:00
Owner
Copy Link
Copy Source

Problem

Both GatewayClasses (traefik-internal, traefik-external) were stuck as Unknown. Neither Traefik deployment had controllerName set in kubernetesGateway, so both defaulted to traefik.io/gateway-controller — which matched neither GatewayClass.

Fix

  • gatewayclass-internal.yaml: controllerName: traefik.io/gateway-controller-internal
  • gatewayclass-external.yaml: controllerName: traefik.io/gateway-controller-external
  • values-internal.yaml: added controllerName: traefik.io/gateway-controller-internal
  • values-external.yaml: added controllerName: traefik.io/gateway-controller-external

Test plan

  • ArgoCD syncs traefik-system cleanly
  • kubectl get gatewayclass shows both as Accepted: True
## Problem Both GatewayClasses (`traefik-internal`, `traefik-external`) were stuck as `Unknown`. Neither Traefik deployment had `controllerName` set in `kubernetesGateway`, so both defaulted to `traefik.io/gateway-controller` — which matched neither GatewayClass. ## Fix - `gatewayclass-internal.yaml`: `controllerName: traefik.io/gateway-controller-internal` - `gatewayclass-external.yaml`: `controllerName: traefik.io/gateway-controller-external` - `values-internal.yaml`: added `controllerName: traefik.io/gateway-controller-internal` - `values-external.yaml`: added `controllerName: traefik.io/gateway-controller-external` ## Test plan - [ ] ArgoCD syncs traefik-system cleanly - [ ] `kubectl get gatewayclass` shows both as `Accepted: True`
unkinben added 1 commit 2026-05-22 23:35:14 +10:00
fix(traefik): set controllerName on GatewayClasses and Traefik providers
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/kubeconform Pipeline failed
Details
45fd0090e5 
GatewayClasses were stuck as Unknown because neither Traefik instance
had controllerName configured, causing both to default to
traefik.io/gateway-controller which matched neither GatewayClass.

Align the GatewayClass controllerName fields with what each Traefik
instance is now explicitly configured to advertise.
unkinben added 1 commit 2026-05-22 23:39:07 +10:00
fix(traefik): pass controllerName via additionalArguments
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/kubeconform Pipeline was successful
Details
af998d8d2c 
Chart schema v40 doesn't allow controllerName under providers.kubernetesGateway;
pass it as a CLI flag via additionalArguments instead.
unkinben merged commit 2df359c4a9 into main 2026-05-22 23:44:07 +10:00
unkinben deleted branch benvin/fix-gatewayclass-controllernames 2026-05-22 23:44:07 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/argocd-apps#135
Delete Branch "benvin/fix-gatewayclass-controllernames"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?