unkin/argocd-apps
3
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Drop dead X-Frame-Options rules from the haproxy edge #487

Merged
benvin merged 1 commits from benvin/haproxy-drop-dead-acls into main 2026-09-26 20:36:30 +10:00
Conversation 0 Commits 1 Files Changed 1
-28
unkin-agent commented 2026-09-26 18:27:06 +10:00
Member
Copy Link
Copy Source

The 13 X-Frame-Options DENY if acl_<host> rules in fe_https have never fired:
their ACLs use req.hdr(host), a request-direction fetch that is invalid in a
response ruleset, so HAProxy rejects them at config-check time. Carried over
verbatim from the Puppet LXD config during the k8s move.

  • Remove the 13 dead http-response set-header X-Frame-Options rules.
  • Remove the 15 now-orphaned acl acl_* definition lines.

Not switching the header on: it has never been live, and Grafana/Gitea send their
own. haproxy -c warnings drop 33 -> 20; the two working response headers stay.

The 13 `X-Frame-Options DENY if acl_<host>` rules in `fe_https` have never fired: their ACLs use `req.hdr(host)`, a request-direction fetch that is invalid in a response ruleset, so HAProxy rejects them at config-check time. Carried over verbatim from the Puppet LXD config during the k8s move. - Remove the 13 dead `http-response set-header X-Frame-Options` rules. - Remove the 15 now-orphaned `acl acl_*` definition lines. Not switching the header on: it has never been live, and Grafana/Gitea send their own. `haproxy -c` warnings drop 33 -> 20; the two working response headers stay.
unkin-agent added 1 commit 2026-09-26 18:27:07 +10:00
drop dead X-Frame-Options rules
ci/woodpecker/pr/vector-test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/kubeconform Pipeline was successful
Details
e110ef18c5
benvin merged commit abf6bfae88 into main 2026-09-26 20:36:30 +10:00
benvin deleted branch benvin/haproxy-drop-dead-acls 2026-09-26 20:36:32 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/argocd-apps#487
Delete Branch "benvin/haproxy-drop-dead-acls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?