unkinben
5d1cc10588
## Why The puppet MASTER is the singleton CA/master. A second master, even transiently during a rolling update, races on CA/cert signing and shared state (the CA lives on a shared PVC mounted by every master pod). The master was previously driven by an HPA with `minReplicas: 2`, `maxReplicas: 5` and a `RollingUpdate` strategy, so 2-5 masters could coexist normally and a rollout would briefly run old+new masters against the same CA data — a latent CA-corruption/split-brain bug. Recreate guarantees the old pod terminates before the new one starts, so two masters never coexist. ## Changes - Set `puppetserver-master` `spec.replicas: 1` and `spec.strategy.type: Recreate` (drops RollingUpdate). - Remove the `puppetserver-masters-autoscaler` HPA and its kustomization entry, which forced 2-5 master replicas and would otherwise override `replicas: 1`. - Refresh the `puppetserver-master-vpa` note to reflect the pinned-singleton, no-HPA state (VPA stays `updateMode: Off`, recommendation-only). The compiler (`puppetserver-compiler`) remains the horizontally-scalable tier with its own HPA — untouched. puppetdb/puppetboard untouched. https://claude.ai/code/session_01JUoARVdmhxKQHyyyp1pxeT --------- Co-authored-by: Ben Vincent <neotheo@gmail.com> Reviewed-on: #341 Co-authored-by: Ben Vincent <ben@unkin.net> Co-committed-by: Ben Vincent <ben@unkin.net>
65 lines
1.9 KiB
YAML
65 lines
1.9 KiB
YAML
---
|
|
apiVersion: autoscaling.k8s.io/v1
|
|
kind: VerticalPodAutoscaler
|
|
metadata:
|
|
name: puppetboard-vpa
|
|
namespace: puppet
|
|
# NOTE: this workload also has an HPA. updateMode Off is recommendation-only
|
|
# and does not act, so there is no HPA/VPA conflict today. Do not flip to Auto/
|
|
# Initial without first moving the HPA off CPU/memory (VPA owns those under Auto).
|
|
spec:
|
|
targetRef:
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
name: puppetboard
|
|
updatePolicy:
|
|
updateMode: "Off"
|
|
---
|
|
apiVersion: autoscaling.k8s.io/v1
|
|
kind: VerticalPodAutoscaler
|
|
metadata:
|
|
name: puppetdb-vpa
|
|
namespace: puppet
|
|
# NOTE: this workload also has an HPA. updateMode Off is recommendation-only
|
|
# and does not act, so there is no HPA/VPA conflict today. Do not flip to Auto/
|
|
# Initial without first moving the HPA off CPU/memory (VPA owns those under Auto).
|
|
spec:
|
|
targetRef:
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
name: puppetdb
|
|
updatePolicy:
|
|
updateMode: "Off"
|
|
---
|
|
apiVersion: autoscaling.k8s.io/v1
|
|
kind: VerticalPodAutoscaler
|
|
metadata:
|
|
name: puppetserver-compiler-vpa
|
|
namespace: puppet
|
|
# NOTE: this workload also has an HPA. updateMode Off is recommendation-only
|
|
# and does not act, so there is no HPA/VPA conflict today. Do not flip to Auto/
|
|
# Initial without first moving the HPA off CPU/memory (VPA owns those under Auto).
|
|
spec:
|
|
targetRef:
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
name: puppetserver-compiler
|
|
updatePolicy:
|
|
updateMode: "Off"
|
|
---
|
|
apiVersion: autoscaling.k8s.io/v1
|
|
kind: VerticalPodAutoscaler
|
|
metadata:
|
|
name: puppetserver-master-vpa
|
|
namespace: puppet
|
|
# NOTE: the master is a pinned single replica (Recreate, no HPA) so the CA/master
|
|
# never coexists. updateMode Off keeps this recommendation-only; do not flip to
|
|
# Auto/Initial, which would evict and briefly recreate the singleton pod.
|
|
spec:
|
|
targetRef:
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
name: puppetserver-master
|
|
updatePolicy:
|
|
updateMode: "Off"
|