Fetch the ref and url the spec actually names #8

Closed
unkin-agent wants to merge 0 commits from benvin/url-significant-refs into main
Member

A ref goes into the archive URL verbatim and an explicit url reaches curl as a positional, so a spec could name one thing and fetch another.

  • reject #, ?, %, [, ], { and } in a tag or branch, which curl or the server turns into a different path
  • pass -- before the url so curl cannot read it as an option
  • document the ref rules in README and the help file
A ref goes into the archive URL verbatim and an explicit url reaches curl as a positional, so a spec could name one thing and fetch another. - reject `#`, `?`, `%`, `[`, `]`, `{` and `}` in a tag or branch, which curl or the server turns into a different path - pass `--` before the url so curl cannot read it as an option - document the ref rules in README and the help file
unkin-agent added 1 commit 2026-09-12 01:05:11 +10:00
Fetch the ref and url the spec actually names
ci/woodpecker/pr/pre-commit Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
e5a260ad25
A ref goes into the archive URL verbatim and an explicit url goes to curl
as a positional, so both could name one thing and fetch another.

- reject "#", "?", "%", "[", "]", "{" and "}" in a tag or branch, which
  curl or the server would turn into a different path
- pass "--" before the url so curl cannot read it as an option
- document the ref rules in README and the help file
benvin closed this pull request 2026-09-12 09:54:20 +10:00
benvin reopened this pull request 2026-09-12 09:54:26 +10:00
benvin closed this pull request 2026-09-12 10:06:41 +10:00
All checks were successful
ci/woodpecker/pr/pre-commit Pipeline was successful
Required
Details
ci/woodpecker/pr/test Pipeline was successful
Required
Details
ci/woodpecker/pr/lint Pipeline was successful
Required
Details

Pull request closed

Sign in to join this conversation.