Reject bare * and unknown remotes on evict, serialise with fetch lock

- return 400 for a bare * and 404 for an unknown remote
- take the per-path fetch lock for single-path evicts
- pass the evictor to Routes so local routes no longer carry it
- test If-None-Match revalidation, ForgetPath/ForgetPrefix glob escaping

internal/api/v2/objects_evict_test.go

@@ -2,31 +2,47 @@ package v2
 
 import (
 	"context"
+	"net/http"
 	"net/http/httptest"
 	"testing"
 
 	"github.com/go-chi/chi/v5"
+
+	"git.unkin.net/unkin/artifactapi/internal/proxy"
 )
 
-type fakeEvictor struct{ remote, path string }
+type fakeEvictor struct {
+	remote, path string
+	err          error
+}
 
 func (f *fakeEvictor) Evict(_ context.Context, remote, path string) error {
 	f.remote, f.path = remote, path
-	return nil
+	return f.err
+}
+
+func deleteObject(ev Evictor, path string) int {
+	router := chi.NewRouter()
+	router.Route("/remotes/{name}/objects", func(r chi.Router) {
+		r.Delete("/*", NewObjectsHandler(nil).Routes(ev).ServeHTTP)
+	})
+	w := httptest.NewRecorder()
+	router.ServeHTTP(w, httptest.NewRequest("DELETE", "/remotes/epel/objects/"+path, nil))
+	return w.Code
 }
 
 func TestRemoteEvictDelegatesToEvictor(t *testing.T) {
 	for _, path := range []string{"8/Everything/x86_64/repodata/repomd.xml", "8/Everything/x86_64/repodata/*"} {
 		ev := &fakeEvictor{}
-		h := NewObjectsHandler(nil, ev)
-		router := chi.NewRouter()
-		router.Route("/remotes/{name}/objects", func(r chi.Router) {
-			r.Delete("/*", h.Routes().ServeHTTP)
-		})
-		w := httptest.NewRecorder()
-		router.ServeHTTP(w, httptest.NewRequest("DELETE", "/remotes/epel/objects/"+path, nil))
-		if w.Code != 204 || ev.remote != "epel" || ev.path != path {
-			t.Errorf("DELETE %s: code=%d evicted=%q/%q", path, w.Code, ev.remote, ev.path)
+		if code := deleteObject(ev, path); code != 204 || ev.remote != "epel" || ev.path != path {
+			t.Errorf("DELETE %s: code=%d evicted=%q/%q", path, code, ev.remote, ev.path)
 		}
 	}
 }
+
+func TestRemoteEvictMapsProxyErrorStatus(t *testing.T) {
+	ev := &fakeEvictor{err: &proxy.ProxyError{Status: http.StatusNotFound, Message: "remote not found"}}
+	if code := deleteObject(ev, "x"); code != http.StatusNotFound {
+		t.Errorf("code = %d, want 404", code)
+	}
+}