unkin/artifactapi
3
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

Make serve_stale refresh test deterministic #172

Merged
benvin merged 1 commits from benvin/stale-test-deterministic into master 2026-10-25 20:22:09 +11:00
Conversation 1 Commits 1 Files Changed 1
+11 -1
unkin-agent commented 2026-10-25 19:08:41 +11:00
Member
Copy Link
Copy Source

TestServeStaleMemberDoesNotBlockMerge reads the fetch counter right after the merges return, but the counted fetch runs inside the background refresh goroutine, so a slow schedule sees 1 instead of 2.

  • signal from the stub fetch when the background refresh starts
  • wait on that signal (5s timeout) before checking the fetch count
  • raise the refresh-reaches-merge deadline to 5s
TestServeStaleMemberDoesNotBlockMerge reads the fetch counter right after the merges return, but the counted fetch runs inside the background refresh goroutine, so a slow schedule sees 1 instead of 2. - signal from the stub fetch when the background refresh starts - wait on that signal (5s timeout) before checking the fetch count - raise the refresh-reaches-merge deadline to 5s
unkin-agent added 1 commit 2026-10-25 19:08:41 +11:00
Wait for the stale refresh before counting member fetches
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
2dadb2d460
unkin-agent commented 2026-10-25 19:11:49 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit a75aef8ded into master 2026-10-25 20:22:09 +11:00
benvin deleted branch benvin/stale-test-deterministic 2026-10-25 20:22:09 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#172
Delete Branch "benvin/stale-test-deterministic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?