unkin/artifactapi
3
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

Show virtual parallel_fetch in UI and TUI #173

Merged
benvin merged 3 commits from benvin/ui-virtual-parallel-fetch into master 2026-10-25 20:25:00 +11:00
Conversation 3 Commits 3 Files Changed 3
+30 -23
unkin-agent commented 2026-10-25 19:14:01 +11:00
Member
Copy Link
Copy Source

Virtuals carry a parallel_fetch flag in the v2 API, but the UI type omits it and neither the UI nor the TUI displays it, so the setting is invisible to operators.

  • add parallel_fetch to the TS Virtual type
  • add a Parallel column with a yellow badge to the UI virtuals table
  • use one selected lookup for the virtual detail panel
  • add a parallel column to the TUI virtuals list, padding the member count (%3d members) so columns align
Virtuals carry a `parallel_fetch` flag in the v2 API, but the UI type omits it and neither the UI nor the TUI displays it, so the setting is invisible to operators. - add `parallel_fetch` to the TS `Virtual` type - add a Parallel column with a yellow badge to the UI virtuals table - use one `selected` lookup for the virtual detail panel - add a parallel column to the TUI virtuals list, padding the member count (`%3d members`) so columns align
unkin-agent added 1 commit 2026-10-25 19:14:01 +11:00
Show virtual parallel_fetch in UI and TUI
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
8cad89db68
unkin-agent commented 2026-10-25 19:16:29 +11:00
Author
Member
Copy Link
Copy Source
  • ui/src/pages/Virtuals.tsx:87 — flag shown as a bare text-muted paragraph above the members list, unlike the table's Badge/column convention (Managed) → add a table column with a Badge (e.g. "parallel") and drop the extra paragraph, or at least stop styling an operator-relevant setting as muted.
  • ui/src/pages/Virtuals.tsx:87 — repeats virtuals.find(...) inline a third time; the file already has a const v = virtuals.find(...) pattern below → hoist once.
  • internal/tui/render.go:111 — "parallel" is prepended into the Description column, so it is indistinguishable from description text and shifts it unevenly across rows → give it its own fixed-width column (e.g. %-8s) or put it after the description in mutedStyle.
  • nit: internal/tui/render.go — no test for the new list marker.
- ui/src/pages/Virtuals.tsx:87 — flag shown as a bare `text-muted` paragraph above the members list, unlike the table's Badge/column convention (Managed) → add a table column with a Badge (e.g. "parallel") and drop the extra paragraph, or at least stop styling an operator-relevant setting as muted. - ui/src/pages/Virtuals.tsx:87 — repeats `virtuals.find(...)` inline a third time; the file already has a `const v = virtuals.find(...)` pattern below → hoist once. - internal/tui/render.go:111 — "parallel" is prepended into the Description column, so it is indistinguishable from description text and shifts it unevenly across rows → give it its own fixed-width column (e.g. `%-8s`) or put it after the description in mutedStyle. - nit: internal/tui/render.go — no test for the new list marker.
unkin-agent added 1 commit 2026-10-25 19:19:23 +11:00
Show parallel fetch as its own column in UI and TUI
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
00c67879ce
unkin-agent commented 2026-10-25 19:22:12 +11:00
Author
Member
Copy Link
Copy Source
  • ui/src/pages/Virtuals.tsx:93 — hoisting selected and rewriting the detail panel (IIFE removal, {expanded} → {selected.name}) is an unrelated refactor not in the PR why → drop it, or split into its own PR (boundary: Parallel visibility vs. detail-panel cleanup), or add it to the body.
  • internal/tui/render.go:115 — %d members → %3d members is an unstated alignment change → mention it in the body.
  • nit: ui/src/pages/Virtuals.tsx:76 — variant="green" is the same colour as the Type badge, so Parallel is not distinguishable at a glance → pick a different variant (e.g. blue is taken by Managed; consider yellow).
- ui/src/pages/Virtuals.tsx:93 — hoisting `selected` and rewriting the detail panel (IIFE removal, `{expanded}` → `{selected.name}`) is an unrelated refactor not in the PR why → drop it, or split into its own PR (boundary: Parallel visibility vs. detail-panel cleanup), or add it to the body. - internal/tui/render.go:115 — `%d members` → `%3d members` is an unstated alignment change → mention it in the body. - nit: ui/src/pages/Virtuals.tsx:76 — `variant="green"` is the same colour as the Type badge, so Parallel is not distinguishable at a glance → pick a different variant (e.g. `blue` is taken by Managed; consider `yellow`).
unkin-agent added 1 commit 2026-10-25 19:24:31 +11:00
Use yellow badge for parallel virtuals
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
c1e45c0ea5
unkin-agent commented 2026-10-25 19:27:23 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit 00edeb478b into master 2026-10-25 20:25:00 +11:00
benvin deleted branch benvin/ui-virtual-parallel-fetch 2026-10-25 20:25:01 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#173
Delete Branch "benvin/ui-virtual-parallel-fetch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?