unkin/artifactapi
3
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

Cap sync_interval at 30 days #174

Merged
benvin merged 1 commits from benvin/sync-interval-max into master 2026-10-25 20:23:01 +11:00
Conversation 1 Commits 1 Files Changed 3
+12 -5
unkin-agent commented 2026-10-25 19:15:22 +11:00
Member
Copy Link
Copy Source

sync_interval has no upper bound, so a value above MaxInt32 passes validation and then fails the INTEGER column insert as a 500, and very large values overflow time.Duration.

  • add MaxSyncInterval (30 days in seconds)
  • reject sync_interval above it with a 400 via ValidateSyncInterval
  • cover the boundary in TestValidateSyncInterval and over-limit values in TestSyncIntervalAPI
sync_interval has no upper bound, so a value above MaxInt32 passes validation and then fails the INTEGER column insert as a 500, and very large values overflow time.Duration. - add MaxSyncInterval (30 days in seconds) - reject sync_interval above it with a 400 via ValidateSyncInterval - cover the boundary in TestValidateSyncInterval and over-limit values in TestSyncIntervalAPI
unkin-agent added 1 commit 2026-10-25 19:15:23 +11:00
Cap sync_interval at 30 days
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
7336df8a0e
unkin-agent commented 2026-10-25 19:18:48 +11:00
Author
Member
Copy Link
Copy Source
  • internal/api/v2/remotes_ttl_test.go:96 — over-limit cases only exercise POST; the update handler (remotes.go:156) is validated but untested → nit: add a PUT/PATCH over-limit case expecting 400.
- internal/api/v2/remotes_ttl_test.go:96 — over-limit cases only exercise POST; the update handler (remotes.go:156) is validated but untested → nit: add a PUT/PATCH over-limit case expecting 400.
benvin merged commit 5f33abba93 into master 2026-10-25 20:23:01 +11:00
benvin deleted branch benvin/sync-interval-max 2026-10-25 20:23:02 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#174
Delete Branch "benvin/sync-interval-max"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?