Refactor into submodules #19

New Issue

2026-04-28T08:07:09+10:00

unkinben commented

2026-04-28 08:07:09 +10:00

Refactor the codebase into submodules.

E.g.

cache.redis
database.postgres
remote.{helm,npm,python,rpm,generic}

There should be no function change with this refactor

Refactor the codebase into submodules. E.g. cache.redis database.postgres remote.{helm,npm,python,rpm,generic} There should be no function change with this refactor

unkinben referenced this issue from a commit

2026-04-28 22:10:04 +10:00

refactor: split cache, database, and remote logic into submodules

unkinben commented

2026-04-28 22:10:29 +10:00

Resolution

Refactored the flat module structure into proper subpackages with no functional changes.

Changes made:

cache/redis.py — RedisCache moved from cache.py; cache/__init__.py re-exports it for backwards compatibility
database/postgres.py — DatabaseManager moved from database.py; database/__init__.py re-exports it
remote/base.py — get_content_type() extracted from main.py
remote/python.py — PyPI URL construction and HTML rewriting
remote/npm.py — npm metadata URL rewriting
remote/helm.py — Helm index.yaml URL rewriting
remote/rpm.py — RPM remote (uses base content type; mutable patterns remain in config.py)
remote/generic.py — generic HTTP remotes

How main.py was updated: _resolve_content() and construct_remote_url() now delegate to the relevant remote.* submodule instead of containing inline per-package logic. _get_content_type() removed from main.py.

All 187 existing tests pass. README updated with a code layout diagram.

Potential future improvements:

storage.py and docker_auth.py could similarly be moved to storage/s3.py and remote/docker.py
The remote/ modules currently only contain content resolution; route logic (auth headers, URL building) could be further extracted per-package

## Resolution Refactored the flat module structure into proper subpackages with no functional changes. **Changes made:** - `cache/redis.py` — RedisCache moved from cache.py; cache/__init__.py re-exports it for backwards compatibility - `database/postgres.py` — DatabaseManager moved from database.py; database/__init__.py re-exports it - `remote/base.py` — get_content_type() extracted from main.py - `remote/python.py` — PyPI URL construction and HTML rewriting - `remote/npm.py` — npm metadata URL rewriting - `remote/helm.py` — Helm index.yaml URL rewriting - `remote/rpm.py` — RPM remote (uses base content type; mutable patterns remain in config.py) - `remote/generic.py` — generic HTTP remotes **How main.py was updated:** _resolve_content() and construct_remote_url() now delegate to the relevant remote.* submodule instead of containing inline per-package logic. _get_content_type() removed from main.py. All 187 existing tests pass. README updated with a code layout diagram. **Potential future improvements:** - storage.py and docker_auth.py could similarly be moved to storage/s3.py and remote/docker.py - The remote/ modules currently only contain content resolution; route logic (auth headers, URL building) could be further extracted per-package

unkinben commented

2026-04-28 22:25:08 +10:00

Additional refactor: storage/s3, auth/docker, and artifact/ handler split

storage/s3.py — S3Storage moved from storage.py. storage/__init__.py re-exports for backwards compat.

auth/docker.py — Docker Bearer token logic moved from docker_auth.py. docker_auth.py kept as a thin shim (re-exports all public symbols including _token_cache) so existing tests and import paths continue to work.

artifact/ subpackage — All route handler logic extracted from main.py. Each @app.route() in main.py is now a single-line delegation:

artifact/proxy.py — remote GET, caching, mutable revalidation, UpstreamUnreachable
artifact/local.py — local repo upload/check/delete
artifact/docker.py — Docker Registry v2 proxy + ping
artifact/discovery.py — GitHub release discovery + bulk cache
artifact/flush.py — cache flush

Tests updated to patch helpers at their new locations (artifactapi.artifact.proxy.*).

Wheel build confirmed with uv build. Docker stack (make docker-up) starts clean; /health, /, /v2/ all respond correctly.

## Additional refactor: storage/s3, auth/docker, and artifact/ handler split **storage/s3.py** — S3Storage moved from storage.py. storage/__init__.py re-exports for backwards compat. **auth/docker.py** — Docker Bearer token logic moved from docker_auth.py. docker_auth.py kept as a thin shim (re-exports all public symbols including _token_cache) so existing tests and import paths continue to work. **artifact/ subpackage** — All route handler logic extracted from main.py. Each @app.route() in main.py is now a single-line delegation: - artifact/proxy.py — remote GET, caching, mutable revalidation, UpstreamUnreachable - artifact/local.py — local repo upload/check/delete - artifact/docker.py — Docker Registry v2 proxy + ping - artifact/discovery.py — GitHub release discovery + bulk cache - artifact/flush.py — cache flush Tests updated to patch helpers at their new locations (artifactapi.artifact.proxy.*). Wheel build confirmed with uv build. Docker stack (make docker-up) starts clean; /health, /, /v2/ all respond correctly.

unkinben referenced a pull request that will close this issue

2026-04-28 22:44:46 +10:00

refactor: split codebase into submodules (closes #19) #24

unkinben closed this issue

2026-04-28 22:47:39 +10:00

unkinben referenced this issue from a commit

2026-04-28 22:47:39 +10:00

Merge pull request 'refactor: split codebase into submodules (closes #19)' (#24) from benvin/issue-19-submodules into master

Sign in to join this conversation.