unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: set timeouts on the upstream HTTP client #67

New Issue
Closed
opened 2026-07-02 00:20:15 +10:00 by unkinben · 0 comments
unkinben commented 2026-07-02 00:20:15 +10:00
Owner
Copy Link
Copy Source

The proxy uses http.DefaultClient for all upstream GET/HEAD and bearer-token requests (internal/proxy/engine.go:157,173,305,395). It has no timeout, so a slow/hung upstream holds a goroutine + connection indefinitely. Introduce one shared *http.Client with dial/TLS/response-header timeouts and a tuned Transport, and use it everywhere.

The proxy uses `http.DefaultClient` for all upstream GET/HEAD and bearer-token requests (`internal/proxy/engine.go:157,173,305,395`). It has no timeout, so a slow/hung upstream holds a goroutine + connection indefinitely. Introduce one shared `*http.Client` with dial/TLS/response-header timeouts and a tuned Transport, and use it everywhere.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#67
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?