fix: GC has no grace period (TOCTOU with dedup uploads) #71

New Issue

2026-07-02T00:20:16+10:00

unkinben commented

2026-07-02 00:20:16 +10:00

FindOrphanedBlobs (internal/database/artifacts.go:112) returns any blob not currently referenced. Because CAS dedups (blob row can exist before its artifact/local_files row is written), a concurrent upload reusing an existing hash can have its S3 object deleted mid-flight by internal/gc/gc.go. Add an age filter so only comfortably-old orphans (e.g. created_at < now()-1h) are collected.

`FindOrphanedBlobs` (`internal/database/artifacts.go:112`) returns any blob not currently referenced. Because CAS dedups (blob row can exist before its artifact/local_files row is written), a concurrent upload reusing an existing hash can have its S3 object deleted mid-flight by `internal/gc/gc.go`. Add an age filter so only comfortably-old orphans (e.g. created_at < now()-1h) are collected.

unkinben referenced a pull request that will close this issue

2026-07-02 00:30:12 +10:00

fix: GC has no grace period (TOCTOU with dedup uploads) #86

unkinben referenced this issue from a commit

2026-07-02 00:30:13 +10:00

fix: add a grace period before GC deletes orphaned blobs

unkinben referenced this issue from a commit

2026-07-02 22:30:42 +10:00

fix: add a grace period before GC deletes orphaned blobs

benvin closed this issue

2026-07-02 22:43:18 +10:00

benvin referenced this issue from a commit