unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: serveFromStore does a guaranteed-miss S3 lookup on every cache hit #78

New Issue
Closed
opened 2026-07-02 00:20:45 +10:00 by unkinben · 0 comments
unkinben commented 2026-07-02 00:20:45 +10:00
Owner
Copy Link
Copy Source

serveFromStore (internal/proxy/engine.go:250) first calls store.Download(ctx, artifact.ContentHash[len(\"sha256:\"):]) — passing the bare hash as an S3 key when real keys are blobs/sha256/<hash> (BlobKey). That first call effectively always 404s, then it retries with the correct BlobKey. Every cached blob serve pays an extra round-trip. Drop the first attempt.

`serveFromStore` (`internal/proxy/engine.go:250`) first calls `store.Download(ctx, artifact.ContentHash[len(\"sha256:\"):])` — passing the bare hash as an S3 key when real keys are `blobs/sha256/<hash>` (`BlobKey`). That first call effectively always 404s, then it retries with the correct `BlobKey`. Every cached blob serve pays an extra round-trip. Drop the first attempt.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#78
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?