unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

fix: e2e suite fails to build (stale server.New call) #81

Merged
benvin merged 1 commits from benvin/fix-e2e-build into master 2026-07-02 20:00:25 +10:00
Conversation 0 Commits 1 Files Changed 1
+1 -1
unkinben commented 2026-07-02 00:24:22 +10:00
Owner
Copy Link
Copy Source

Fixes #80

Why

make e2e did not compile against master: e2e/e2e_test.go called server.New(cfg) but the signature is New(cfg, version string). This blocked all end-to-end validation.

Changes

  • Pass a static "e2e-test" version to server.New in the e2e bootstrap.

Validation

  • make e2e builds and passes (testcontainers: postgres/redis/minio).
Fixes #80 ## Why `make e2e` did not compile against master: `e2e/e2e_test.go` called `server.New(cfg)` but the signature is `New(cfg, version string)`. This blocked all end-to-end validation. ## Changes - Pass a static `"e2e-test"` version to `server.New` in the e2e bootstrap. ## Validation - `make e2e` builds and passes (testcontainers: postgres/redis/minio).
unkinben added 1 commit 2026-07-02 00:24:23 +10:00
fix: pass version arg to server.New in e2e bootstrap
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
9651f7994a 
The e2e suite failed to compile because e2e_test.go called server.New(cfg)
but the signature is New(cfg, version). Pass a static test version so
make e2e builds and runs again.

Refs #80
benvin merged commit b9098bf19c into master 2026-07-02 20:00:25 +10:00
benvin deleted branch benvin/fix-e2e-build 2026-07-02 20:00:25 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#81
Delete Branch "benvin/fix-e2e-build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?