unkin/artifactapi
2
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases 1 Wiki Activity

feat: cache upstream bearer tokens #92

Merged
benvin merged 1 commits from benvin/cache-bearer-tokens into master 2026-07-02 21:35:46 +10:00
Conversation 0 Commits 1 Files Changed 2
+56 -10
unkinben commented 2026-07-02 00:42:50 +10:00
Owner
Copy Link
Copy Source

Fixes #77

Why

Each upstream 401 re-ran the full token-endpoint request, even though a single Docker pull triggers many blob/manifest requests sharing one scope.

Changes

  • Add Redis GetToken/SetToken.
  • fetchBearerToken now also parses expires_in and returns a TTL.
  • New Engine.cachedBearerToken reuses a cached token keyed by remote + challenge (hashed), caching for expires_in minus a safety margin (default 60s when absent).

Validation

  • make e2e passes.
Fixes #77 ## Why Each upstream 401 re-ran the full token-endpoint request, even though a single Docker pull triggers many blob/manifest requests sharing one scope. ## Changes - Add Redis `GetToken`/`SetToken`. - `fetchBearerToken` now also parses `expires_in` and returns a TTL. - New `Engine.cachedBearerToken` reuses a cached token keyed by remote + challenge (hashed), caching for `expires_in` minus a safety margin (default 60s when absent). ## Validation - `make e2e` passes.
unkinben added 1 commit 2026-07-02 00:42:50 +10:00
feat: cache upstream bearer tokens in Redis
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
493b3cb906 
Each upstream 401 re-ran the full token-endpoint dance. Cache the minted
token keyed by remote + challenge, honouring the token's expires_in (with
a safety margin, defaulting to 60s), so subsequent blobs sharing a scope
reuse it.

Refs #77
benvin merged commit e7027c8ccc into master 2026-07-02 21:35:46 +10:00
benvin deleted branch benvin/cache-bearer-tokens 2026-07-02 21:35:47 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/artifactapi#92
Delete Branch "benvin/cache-bearer-tokens"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?