unkin-agent
82bb5708c8
artifactapi's schema was a ~180-line inline DDL blob re-executed on every start, growing an ALTER TABLE ... IF NOT EXISTS line per change with nothing recording what had run. golib/pg already owns that mechanic for the estate, so move the SQL into a versioned, embedded set and let the library apply it. - Depend on git.unkin.net/unkin/golib v0.1.0. - Move the DDL verbatim to migrations/0001_init.sql, embedded via the new migrations package, and build the pool with pg.NewMigrated (LockName "artifactapi-migrations"). The runner adds a cluster-wide advisory lock the old blob never took, so replicas starting together queue instead of racing each other through the DDL. - The live database has the schema but no schema_migrations, so its first start on this build re-runs 0001. Every statement is IF NOT EXISTS-guarded, so that run is a no-op landing only the tracking row; a container-backed test drops the row from a migrated database and asserts exactly that, and a static guard keeps future migrations additive and idempotent. - Keep config.DatabaseDSN as the DSN source rather than pg.DSNFromEnv: the variable names match, but golib has no default user or database name, and artifactapi documents and ships DBUSER/DBNAME defaults of "artifacts". The deployed env var contract is unchanged. - Guard the embedded set against migrations/ and pin the derived advisory key, so neither can drift unnoticed. - Plumb GOPRIVATE=git.unkin.net for the first cross-repo Go dependency: exported by the Makefile, set in the Dockerfile and the woodpecker Go steps, documented in the README.
77 lines
2.4 KiB
Makefile
77 lines
2.4 KiB
Makefile
.PHONY: build test lint fmt e2e docker-e2e docker docker-ui compose clean tidy check-go
|
|
|
|
BINARY := bin/artifactapi
|
|
MODULE := git.unkin.net/unkin/artifactapi
|
|
VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo "0.0.0-dev")
|
|
GO_VERSION_REQUIRED := 1.23
|
|
GO_VERSION_ACTUAL := $(shell go version | sed 's/go version go\([0-9]*\.[0-9]*\).*/\1/')
|
|
|
|
# git.unkin.net modules (golib) are fetched straight from Gitea, never via the
|
|
# public proxy or sum db, which have no view of them. Exported here rather than
|
|
# written with `go env -w`, so a fresh checkout needs no machine-local setup.
|
|
export GOPRIVATE := git.unkin.net
|
|
|
|
check-go:
|
|
@if [ "$$(printf '%s\n%s' "$(GO_VERSION_REQUIRED)" "$(GO_VERSION_ACTUAL)" | sort -V | head -1)" != "$(GO_VERSION_REQUIRED)" ]; then \
|
|
echo "ERROR: Go >= $(GO_VERSION_REQUIRED) required, found $(GO_VERSION_ACTUAL)"; exit 1; \
|
|
fi
|
|
|
|
build: check-go tidy
|
|
go build -ldflags="-s -w -X main.version=$(VERSION)" -o $(BINARY) ./cmd/artifactapi
|
|
|
|
test: check-go
|
|
go test -race -count=1 ./pkg/... ./internal/...
|
|
|
|
lint: check-go
|
|
golangci-lint run ./...
|
|
go vet ./...
|
|
|
|
fmt: check-go
|
|
gofmt -w .
|
|
goimports -w .
|
|
|
|
e2e: check-go
|
|
TESTCONTAINERS_RYUK_DISABLED=true go test -tags=e2e -race -count=1 -timeout=5m ./e2e/...
|
|
|
|
# Build the container, bring up the full docker-compose stack + a mock upstream,
|
|
# and run the black-box suite against the running product.
|
|
docker-e2e: check-go
|
|
./scripts/docker-e2e.sh
|
|
|
|
docker:
|
|
docker build -t artifactapi:$(VERSION) .
|
|
|
|
docker-ui:
|
|
docker build -t artifactapi-ui:$(VERSION) -f ui/Dockerfile.ui ui/
|
|
|
|
compose:
|
|
docker compose up -d
|
|
|
|
clean:
|
|
rm -rf bin/
|
|
|
|
tidy:
|
|
go mod tidy
|
|
|
|
# Bump helpers — reads the latest semver tag and creates the next one.
|
|
_LATEST := $(shell git tag --sort=-v:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$$' | head -1)
|
|
_BASE := $(if $(_LATEST),$(_LATEST),v0.0.0)
|
|
_MAJ := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f1)
|
|
_MIN := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f2)
|
|
_PAT := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f3)
|
|
|
|
patch:
|
|
@NEW=v$(_MAJ).$(_MIN).$(shell expr $(_PAT) + 1); \
|
|
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
|
|
|
|
minor:
|
|
@NEW=v$(_MAJ).$(shell expr $(_MIN) + 1).0; \
|
|
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
|
|
|
|
major:
|
|
@NEW=v$(shell expr $(_MAJ) + 1).0.0; \
|
|
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _tag TAG=$$NEW
|
|
|
|
_tag:
|
|
git push origin $(TAG)
|