unkin-agent
9b18bbf471
Add a per-remote mirror_strategy selector for the mirrorlist, supporting
round_robin (default, unchanged) and least_conn.
- models.Remote gains MirrorStrategy string + MirrorStrategy{RoundRobin,LeastConn}
constants and ValidateMirrorStrategy (enum check; least_conn requires a
non-empty mirrorlist). Empty behaves as round_robin for back-compat.
- DB: additive mirror_strategy TEXT NOT NULL DEFAULT 'round_robin' column
(CREATE TABLE + ADD COLUMN IF NOT EXISTS), wired through remoteCols/scanRemote/
CreateRemote/UpdateRemote; empty normalized to round_robin on write.
- Engine: least_conn starts each attempt with the pool URL holding the fewest
in-flight requests via a per-remote/per-URL atomic gauge (incremented around
each upstream call in head/fetch/checkUpstream), ties broken by the existing
round-robin rotation. Round-robin path and failover order unchanged;
single-URL pools are a no-op.
- Tests: unit tests for least-loaded selection, round-robin default, gauge
inc/dec, single-URL no-op, and strategy validation; DB round-trip covers the
new column; docker e2e adds a least_conn distribution test and a real dnf
install through a least_conn remote.
Dockerised end-to-end suite
Black-box tests that run against a fully containerised artifactapi stack
(built image + Postgres + Redis + MinIO) plus a static mock upstream. Unlike the
in-process e2e/ suite (testcontainers, server run in-process), these only speak
HTTP to the running product, so they exercise the shipped container image.
Run
make docker-e2e # build image, compose up, run suite, compose down
scripts/docker-e2e.sh builds and starts docker-compose.yml +
docker-compose.e2e.yml, waits for /health, then runs
go test -tags=dockere2e ./e2e-docker/... and tears everything down.
The stack publishes artifactapi on host port 8001 (to avoid colliding with a
local instance on 8000). Override with ARTIFACTAPI_URL to point the tests at an
already-running stack.
Coverage
- Repository lifecycle — add / change / delete for remote, local and virtual repos.
- Caching — one immutable artifact per remote package type (generic, docker,
helm, pypi, npm, rpm, alpine, puppet, terraform, goproxy) proxied through the
mock upstream: first fetch
X-Artifact-Source: remote, secondcache, bytes verified against the origin fixture. - Local uploads — generic (upload/download), pypi (wheel + generated
simple/index), rpm (real package + automatic repodata generation). - Virtual repositories — pypi simple-index merge and helm
index.yamlmerge across two members. - Mirrorlist — an rpm remote with a
mirrorlistof extra upstream mirrors (pool =base_url+mirrorlist): round-robin distribution across both mirrors (constant-bodymockupstreama/mockupstreamb), failover past a dead primary, no-mirrorlist regression, and a realdnf(stockrockylinux:9container)makecache+installthrough a two-mirror rpm remote whosebase_urlis dead — a dead mirror must not break the client. - Mirror strategy (
least_conn) — amirror_strategy: least_connrpm remote over the two constant-body mirrors exercises the least-connections selection path end-to-end (both mirrors serve, all requests succeed), plus a realdnfinstall through aleast_connremote with a dead primary (failover unchanged). The precise least-loaded pick is asserted deterministically in the proxy unit test, since an in-flight-skew assertion over HTTP is timing-sensitive.
Fixtures
fixtures/ is served by the mock upstream at its web root. Paths mirror each
provider's upstream URL layout (e.g. v2/... for docker, v1/providers/... for
terraform). The RPM under fixtures/rpmrepo/Packages/ is a real package so the
rpm provider can parse its metadata for repodata generation.