Render empty forwarders for forward zones

A forward zone with no forwarders now renders "forwarders { };", which
BIND accepts and treats as disabling forwarding for the zone.

internal/controller/bindzone_controller.go

@@ -218,10 +218,7 @@ func (r *BindZoneReconciler) buildZoneConfig(ctx context.Context, zone *bindv1al
 			parts = append(parts, fmt.Sprintf("primaries { %s }", terminateInline(zone.Spec.Primaries)))
 		}
 	case bindv1alpha1.ZoneForward:
-		parts = append(parts, "type forward", "forward only")
-		if len(zone.Spec.Forwarders) > 0 {
-			parts = append(parts, fmt.Sprintf("forwarders { %s }", terminateInline(zone.Spec.Forwarders)))
-		}
+		parts = append(parts, "type forward", "forward only", bind.ForwardersClause(zone.Spec.Forwarders))
 	case bindv1alpha1.ZoneStub:
 		parts = append(parts, "type stub", fmt.Sprintf("file \"%s\"", bind.ZoneFilePath(zone.Spec.ZoneName)))
 		if len(zone.Spec.Primaries) > 0 {

internal/controller/bindzone_notify_test.go

@@ -63,3 +63,23 @@ func TestBuildZoneConfigPrimaryNoNotifyTargets(t *testing.T) {
 		t.Errorf("did not expect notify clauses with no targets: %q", cfg)
 	}
 }
+
+func TestBuildZoneConfigForwardForwarders(t *testing.T) {
+	r := &BindZoneReconciler{}
+	for _, tc := range []struct {
+		fwd  []string
+		want string
+	}{
+		{nil, "{ type forward; forward only; forwarders { }; };"},
+		{[]string{"198.18.19.15"}, "{ type forward; forward only; forwarders { 198.18.19.15; }; };"},
+	} {
+		zone := &bindv1alpha1.BindZone{Spec: bindv1alpha1.BindZoneSpec{ZoneName: "spamhaus.org", Type: bindv1alpha1.ZoneForward, Forwarders: tc.fwd}}
+		cfg, err := r.buildZoneConfig(context.Background(), zone, "", nil, "")
+		if err != nil {
+			t.Fatalf("buildZoneConfig: %v", err)
+		}
+		if cfg != tc.want {
+			t.Errorf("forwarders %v:\ngot  %q\nwant %q", tc.fwd, cfg, tc.want)
+		}
+	}
+}