unkin/bind-operator
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reject an apex NS DNSRecord instead of silently appending #24

Merged
benvin merged 1 commits from benvin/apex-ns-dnsrecord-reject into main 2026-09-27 11:23:47 +10:00
Conversation 1 Commits 1 Files Changed 6
+56 -3
unkin-agent commented 2026-09-27 11:04:54 +10:00
Member
Copy Link
Copy Source

BIND ignores an RRset-wide delete of NS at a zone apex, so a DNSRecord with name: "@" and type: NS only ever adds to the live RRset while the transaction reports success. acme.unkin.net has published a name its DNSRecord spec does not list for weeks. The apex NS is converged per rdata from BindZone.spec.nameservers; DNSRecord has no equivalent and should not grow a second one.

  • add a CEL rule rejecting an apex NS DNSRecord at admission, naming BindZone.spec.nameservers
  • fail the reconcile with ApexNSUnsupported for a zone-qualified apex name, which CEL cannot see
  • skip the ignored RRset delete on the deletion path
  • share one isApexNS helper across the apex checks

Closes #23

BIND ignores an RRset-wide delete of NS at a zone apex, so a DNSRecord with `name: "@"` and `type: NS` only ever adds to the live RRset while the transaction reports success. `acme.unkin.net` has published a name its DNSRecord spec does not list for weeks. The apex NS is converged per rdata from `BindZone.spec.nameservers`; DNSRecord has no equivalent and should not grow a second one. - add a CEL rule rejecting an apex NS DNSRecord at admission, naming `BindZone.spec.nameservers` - fail the reconcile with `ApexNSUnsupported` for a zone-qualified apex name, which CEL cannot see - skip the ignored RRset delete on the deletion path - share one `isApexNS` helper across the apex checks Closes #23
unkin-agent added 1 commit 2026-09-27 11:04:55 +10:00
reject an apex NS DNSRecord instead of appending to the live RRset
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
afb4fe2631 
BIND ignores an RRset-wide delete at a zone apex, so a DNSRecord for the
apex NS can only add to what the zone was seeded with while reporting
success. BindZone.spec.nameservers converges it per rdata.
unkin-agent commented 2026-09-27 11:11:17 +10:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit 8c0b36521e into main 2026-09-27 11:23:47 +10:00
benvin deleted branch benvin/apex-ns-dnsrecord-reject 2026-09-27 11:23:47 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/bind-operator#24
Delete Branch "benvin/apex-ns-dnsrecord-reject"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?