unkin/bind-operator
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Render empty forwarders for forward zones #27

Merged
benvin merged 2 commits from benvin/forward-zone-empty-forwarders into main 2026-10-17 12:52:10 +11:00
Conversation 2 Commits 2 Files Changed 5
+25 -5
unkin-agent commented 2026-10-16 23:32:14 +11:00
Member
Copy Link
Copy Source

A forward zone with no forwarders omits the forwarders clause, so BIND falls back to the global forwarders instead of resolving the zone directly.

  • render forwarders { }; in named.conf for forward zones with an empty forwarders list
  • document the empty-list behaviour on spec.forwarders and regenerate the CRDs
A forward zone with no forwarders omits the `forwarders` clause, so BIND falls back to the global forwarders instead of resolving the zone directly. - render `forwarders { };` in named.conf for forward zones with an empty forwarders list - document the empty-list behaviour on `spec.forwarders` and regenerate the CRDs
unkin-agent added 1 commit 2026-10-16 23:32:14 +11:00
Render empty forwarders for forward zones
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
53cb7fa059 
A forward zone with no forwarders now renders "forwarders { };", which
BIND accepts and treats as disabling forwarding for the zone.
unkin-agent commented 2026-10-16 23:36:56 +11:00
Author
Member
Copy Link
Copy Source
  • internal/controller/bindzone_controller.go:221 — nit: ZoneForward never reaches buildZoneConfig (Reconcile returns early at line 41 and forward zones render only via named.conf), so this branch and TestBuildZoneConfigForwardForwarders (bindzone_notify_test.go) test unreachable code → drop the rndc change and test, or note in the body that it is defensive only.
- internal/controller/bindzone_controller.go:221 — nit: ZoneForward never reaches buildZoneConfig (Reconcile returns early at line 41 and forward zones render only via named.conf), so this branch and TestBuildZoneConfigForwardForwarders (bindzone_notify_test.go) test unreachable code → drop the rndc change and test, or note in the body that it is defensive only.
unkin-agent added 1 commit 2026-10-16 23:38:00 +11:00
Drop unreachable forward-zone addzone config
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
651c54cf7f
unkin-agent commented 2026-10-16 23:38:52 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit f3e28aa504 into main 2026-10-17 12:52:10 +11:00
benvin deleted branch benvin/forward-zone-empty-forwarders 2026-10-17 12:52:10 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/bind-operator#27
Delete Branch "benvin/forward-zone-empty-forwarders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?