Remove -copyts and add -flush_packets 1 to subtitle extraction
-copyts is unnecessary for -c:s copy to SRT and slows extraction ~5x. Without -flush_packets 1, ffmpeg buffers all output until exit, leaving .srt files at 0 bytes for minutes while the player shows no subtitles. Fixes #16438
This commit is contained in:
@@ -569,7 +569,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
|
|||||||
var outputPaths = new List<string>();
|
var outputPaths = new List<string>();
|
||||||
var args = string.Format(
|
var args = string.Format(
|
||||||
CultureInfo.InvariantCulture,
|
CultureInfo.InvariantCulture,
|
||||||
"-i {0} -copyts",
|
"-i {0}",
|
||||||
inputPath);
|
inputPath);
|
||||||
|
|
||||||
foreach (var subtitleStream in subtitleStreams)
|
foreach (var subtitleStream in subtitleStreams)
|
||||||
@@ -594,7 +594,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
|
|||||||
outputPaths.Add(outputPath);
|
outputPaths.Add(outputPath);
|
||||||
args += string.Format(
|
args += string.Format(
|
||||||
CultureInfo.InvariantCulture,
|
CultureInfo.InvariantCulture,
|
||||||
" -map 0:{0} -an -vn -c:s {1} \"{2}\"",
|
" -map 0:{0} -an -vn -c:s {1} -flush_packets 1 \"{2}\"",
|
||||||
streamIndex,
|
streamIndex,
|
||||||
outputCodec,
|
outputCodec,
|
||||||
outputPath);
|
outputPath);
|
||||||
@@ -613,7 +613,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
|
|||||||
var outputPaths = new List<string>();
|
var outputPaths = new List<string>();
|
||||||
var args = string.Format(
|
var args = string.Format(
|
||||||
CultureInfo.InvariantCulture,
|
CultureInfo.InvariantCulture,
|
||||||
"-i {0} -copyts",
|
"-i {0}",
|
||||||
inputPath);
|
inputPath);
|
||||||
|
|
||||||
foreach (var subtitleStream in subtitleStreams)
|
foreach (var subtitleStream in subtitleStreams)
|
||||||
@@ -639,7 +639,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
|
|||||||
outputPaths.Add(outputPath);
|
outputPaths.Add(outputPath);
|
||||||
args += string.Format(
|
args += string.Format(
|
||||||
CultureInfo.InvariantCulture,
|
CultureInfo.InvariantCulture,
|
||||||
" -map 0:{0} -an -vn -c:s {1} \"{2}\"",
|
" -map 0:{0} -an -vn -c:s {1} -flush_packets 1 \"{2}\"",
|
||||||
streamIndex,
|
streamIndex,
|
||||||
outputCodec,
|
outputCodec,
|
||||||
outputPath);
|
outputPath);
|
||||||
|
|||||||
Reference in New Issue
Block a user