diff --git a/Jellyfin.Server.Implementations/Item/BaseItemRepository.TranslateQuery.cs b/Jellyfin.Server.Implementations/Item/BaseItemRepository.TranslateQuery.cs
index 8c0a39fe4c..379f480106 100644
--- a/Jellyfin.Server.Implementations/Item/BaseItemRepository.TranslateQuery.cs
+++ b/Jellyfin.Server.Implementations/Item/BaseItemRepository.TranslateQuery.cs
@@ -555,7 +555,7 @@ public sealed partial class BaseItemRepository
if (filter.ArtistIds.Length > 0)
{
- baseQuery = baseQuery.WhereReferencedItemMultipleTypes(context, [ItemValueType.Artist, ItemValueType.AlbumArtist], filter.ArtistIds);
+ baseQuery = baseQuery.WhereReferencedItem(context, [ItemValueType.Artist, ItemValueType.AlbumArtist], filter.ArtistIds);
}
if (filter.AlbumArtistIds.Length > 0)
@@ -586,12 +586,12 @@ public sealed partial class BaseItemRepository
if (filter.ExcludeArtistIds.Length > 0)
{
- baseQuery = baseQuery.WhereReferencedItemMultipleTypes(context, [ItemValueType.Artist, ItemValueType.AlbumArtist], filter.ExcludeArtistIds, true);
+ baseQuery = baseQuery.WhereReferencedItem(context, [ItemValueType.Artist, ItemValueType.AlbumArtist], filter.ExcludeArtistIds, true);
}
if (filter.GenreIds.Count > 0)
{
- baseQuery = baseQuery.WhereReferencedItem(context, ItemValueType.Genre, filter.GenreIds.ToArray());
+ baseQuery = baseQuery.WhereReferencedItem(context, ItemValueType.Genre, filter.GenreIds);
}
if (filter.Genres.Count > 0)
@@ -617,7 +617,7 @@ public sealed partial class BaseItemRepository
if (filter.StudioIds.Length > 0)
{
- baseQuery = baseQuery.WhereReferencedItem(context, ItemValueType.Studios, filter.StudioIds.ToArray());
+ baseQuery = baseQuery.WhereReferencedItem(context, ItemValueType.Studios, filter.StudioIds);
}
if (filter.OfficialRatings.Length > 0)
@@ -963,17 +963,6 @@ public sealed partial class BaseItemRepository
baseQuery = baseQuery.WhereHasAnyProviderIds(filter.HasAnyProviderIds);
}
- if (filter.HasAnyProviderIds is not null && filter.HasAnyProviderIds.Count > 0)
- {
- var includeAny = filter.HasAnyProviderIds
- .SelectMany(kvp => kvp.Value.Select(v => $"{kvp.Key}:{v}"))
- .ToArray();
- if (includeAny.Length > 0)
- {
- baseQuery = baseQuery.Where(e => e.Provider!.Select(f => f.ProviderId + ":" + f.ProviderValue)!.Any(f => includeAny.Contains(f)));
- }
- }
-
if (filter.HasImdbId.HasValue)
{
baseQuery = filter.HasImdbId.Value
diff --git a/src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs b/src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs
index fec37ce723..0dfce732ce 100644
--- a/src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs
+++ b/src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs
@@ -14,11 +14,17 @@ namespace Jellyfin.Database.Implementations;
///
/// Contains a number of query related extensions.
///
+///
+/// Every helper here binds its values through . Values embedded as bare
+/// constants are inlined into the SQL as literals, which gives each distinct value its own entry in EF's
+/// compiled query cache and its own statement for the database to plan.
+///
public static class JellyfinQueryHelperExtensions
{
private static readonly MethodInfo _containsMethodGenericCache = typeof(Enumerable).GetMethods(BindingFlags.Public | BindingFlags.Static).First(m => m.Name == nameof(Enumerable.Contains) && m.GetParameters().Length == 2);
private static readonly MethodInfo _efParameterInstruction = typeof(EF).GetMethod(nameof(EF.Parameter), BindingFlags.Public | BindingFlags.Static)!;
private static readonly ConcurrentDictionary _containsQueryCache = new();
+ private static readonly ConcurrentDictionary _efParameterCache = new();
///
/// Builds an optimised query checking one property against a list of values while maintaining an optimal query.
@@ -26,14 +32,68 @@ public static class JellyfinQueryHelperExtensions
/// The entity.
/// The property type to compare.
/// The source query.
- /// The list of items to check.
+ /// The list of items to check. An empty list matches nothing.
/// Property expression.
/// A Query.
- public static IQueryable WhereOneOrMany(this IQueryable query, IList oneOf, Expression> property)
+ public static IQueryable WhereOneOrMany(this IQueryable query, IReadOnlyList oneOf, Expression> property)
{
return query.Where(OneOrManyExpressionBuilder(oneOf, property));
}
+ ///
+ /// Builds an optimised query expression checking one property against a list of values while maintaining an optimal query.
+ ///
+ /// The entity.
+ /// The property type to compare.
+ /// The list of items to check. An empty list matches nothing.
+ /// Property expression.
+ /// A Query.
+ public static Expression> OneOrManyExpressionBuilder(this IReadOnlyList oneOf, Expression> property)
+ {
+ ArgumentNullException.ThrowIfNull(oneOf);
+ ArgumentNullException.ThrowIfNull(property);
+
+ var parameter = Expression.Parameter(typeof(TEntity), "item");
+ property = ParameterReplacer.Replace, Func>(property, property.Parameters[0], parameter);
+
+ if (oneOf.Count == 0)
+ {
+ // Fail closed, and without asking the database to unpack an empty collection to prove it.
+ return Expression.Lambda>(Expression.Constant(false), parameter);
+ }
+
+ if (oneOf.Count == 1)
+ {
+ var value = Expression.Call(
+ null,
+ EfParameterFor(typeof(TProperty)),
+ Expression.Constant(oneOf[0], typeof(TProperty)));
+
+ return Expression.Lambda>(
+ typeof(TProperty).IsValueType
+ ? Expression.Equal(property.Body, value)
+ : Expression.ReferenceEqual(property.Body, value),
+ parameter);
+ }
+
+ var containsMethodInfo = _containsQueryCache.GetOrAdd(typeof(TProperty), static (key) => _containsMethodGenericCache.MakeGenericMethod(key));
+
+ // Binding the whole collection as one parameter keeps the statement identical for any element
+ // count, instead of emitting one placeholder per element.
+ return Expression.Lambda>(
+ Expression.Call(
+ null,
+ containsMethodInfo,
+ Expression.Call(null, EfParameterFor(oneOf.GetType()), Expression.Constant(oneOf)),
+ property.Body),
+ parameter);
+ }
+
+ private static MethodInfo EfParameterFor(Type type)
+ {
+ return _efParameterCache.GetOrAdd(type, static (key) => _efParameterInstruction.MakeGenericMethod(key));
+ }
+
///
/// Builds a query that checks referenced ItemValues for a cross BaseItem lookup.
///
@@ -47,207 +107,160 @@ public static class JellyfinQueryHelperExtensions
this IQueryable baseQuery,
JellyfinDbContext context,
ItemValueType itemValueType,
- IList referenceIds,
+ IReadOnlyList referenceIds,
bool invert = false)
{
- return baseQuery.Where(ReferencedItemFilterExpressionBuilder(context, itemValueType, referenceIds, invert));
+ return baseQuery.WhereReferencedItem(context, [itemValueType], referenceIds, invert);
}
///
- /// Builds a query that checks referenced ItemValues for a cross BaseItem lookup.
+ /// Builds a query that checks referenced ItemValues of any of the given types for a cross BaseItem lookup.
///
/// The source query.
/// The database context.
- /// The type of item value to reference.
+ /// The types of item value to reference.
/// The list of BaseItem ids to check matches.
/// If set an exclusion check is performed instead.
/// A Query.
- public static IQueryable WhereReferencedItemMultipleTypes(
+ ///
+ /// Matching is on CleanName alone. Genre/artist/album etc items do not set an ItemValue of their own
+ /// type, so the referenced item's Type is never consulted and ids whose names clean to the same value
+ /// are interchangeable across types.
+ ///
+ public static IQueryable WhereReferencedItem(
this IQueryable baseQuery,
JellyfinDbContext context,
- IList itemValueTypes,
- IList referenceIds,
+ IReadOnlyList itemValueTypes,
+ IReadOnlyList referenceIds,
bool invert = false)
{
- var itemFilter = OneOrManyExpressionBuilder(referenceIds, f => f.Id);
- var typeFilter = OneOrManyExpressionBuilder(itemValueTypes, m => m.ItemValue.Type);
+ ArgumentNullException.ThrowIfNull(context);
- // Flat sub-selects + Contains instead of a nested correlated .Any(...Any(...)).
+ // Flat sub-selects rather than a correlated .Any(...Any(...)).
var referencedCleanValues = context.BaseItems
- .Where(itemFilter)
+ .Where(OneOrManyExpressionBuilder(referenceIds, e => e.Id))
.Select(e => e.CleanName);
var matchingItemIds = context.ItemValuesMap
- .Where(typeFilter)
+ .Where(OneOrManyExpressionBuilder(itemValueTypes, m => m.ItemValue.Type))
.Where(m => referencedCleanValues.Contains(m.ItemValue.CleanValue))
.Select(m => m.ItemId);
- if (invert)
- {
- return baseQuery.Where(e => !matchingItemIds.Contains(e.Id));
- }
-
- return baseQuery.Where(e => matchingItemIds.Contains(e.Id));
+ return invert
+ ? baseQuery.Where(e => !matchingItemIds.Contains(e.Id))
+ : baseQuery.Where(e => matchingItemIds.Contains(e.Id));
}
///
- /// Builds a query expression that checks referenced ItemValues for a cross BaseItem lookup.
- ///
- /// The database context.
- /// The type of item value to reference.
- /// The list of BaseItem ids to check matches.
- /// If set an exclusion check is performed instead.
- /// A Query.
- public static Expression> ReferencedItemFilterExpressionBuilder(
- this JellyfinDbContext context,
- ItemValueType itemValueType,
- IList referenceIds,
- bool invert = false)
- {
- // Well genre/artist/album etc items do not actually set the ItemValue of thier specitic types so we cannot match it that way.
- /*
- "(guid in (select itemid from ItemValues where CleanValue = (select CleanName from TypedBaseItems where guid=@GenreIds and Type=2)))"
- */
-
- var itemFilter = OneOrManyExpressionBuilder(referenceIds, f => f.Id);
-
- // Flat sub-selects + Contains instead of a nested correlated .Any(...Any(...)).
- var referencedCleanValues = context.BaseItems
- .Where(itemFilter)
- .Select(e => e.CleanName);
-
- var matchingItemIds = context.ItemValuesMap
- .Where(m => m.ItemValue.Type == itemValueType && referencedCleanValues.Contains(m.ItemValue.CleanValue))
- .Select(m => m.ItemId);
-
- if (invert)
- {
- return item => !matchingItemIds.Contains(item.Id);
- }
-
- return item => matchingItemIds.Contains(item.Id);
- }
-
- ///
- /// Filters items that match any of the specified (provider name, value) pairs.
+ /// Filters items that have any of the specified providers, optionally restricted to given values.
///
/// The source query.
- /// Dictionary mapping provider names to arrays of values to match.
+ /// Dictionary mapping provider names to values to match. An empty value array matches any value for that provider.
/// A filtered query.
public static IQueryable WhereHasAnyProviderIds(
this IQueryable baseQuery,
IReadOnlyDictionary providerIds)
{
- var providerKeys = providerIds
- .SelectMany(kvp => kvp.Value.Select(v => $"{kvp.Key}:{v}"))
- .ToList();
-
- if (providerKeys.Count == 0)
- {
- return baseQuery;
- }
-
- return baseQuery.Where(e => e.Provider!.Any(p => providerKeys.Contains(p.ProviderId + ":" + p.ProviderValue)));
+ return baseQuery.WhereProviderMatch(Flatten(providerIds), false);
}
///
- /// Filters items that have any of the specified providers. Empty/null values match any value for that provider.
+ /// Filters items that have any of the specified providers, optionally restricted to a given value.
///
/// The source query.
- /// Dictionary mapping provider names to optional values.
+ /// Dictionary mapping provider names to optional values. An empty value matches any value for that provider.
/// A filtered query.
public static IQueryable WhereHasAnyProviderId(
this IQueryable baseQuery,
IReadOnlyDictionary providerIds)
{
- var existenceOnly = providerIds
- .Where(e => string.IsNullOrEmpty(e.Value))
- .Select(e => e.Key)
- .ToList();
+ return baseQuery.WhereProviderMatch(providerIds, false);
+ }
- var specificValues = providerIds
- .Where(e => !string.IsNullOrEmpty(e.Value))
- .Select(e => $"{e.Key}:{e.Value}")
- .ToList();
+ ///
+ /// Excludes items that have any of the specified providers, optionally restricted to a given value.
+ ///
+ /// The source query.
+ /// Dictionary mapping provider names to optional values. An empty value excludes any value for that provider.
+ /// A filtered query.
+ public static IQueryable WhereExcludeProviderIds(
+ this IQueryable baseQuery,
+ IReadOnlyDictionary providerIds)
+ {
+ return baseQuery.WhereProviderMatch(providerIds, true);
+ }
+
+ private static IEnumerable> Flatten(IReadOnlyDictionary providerIds)
+ {
+ ArgumentNullException.ThrowIfNull(providerIds);
+
+ foreach (var (provider, values) in providerIds)
+ {
+ if (values is null || values.Length == 0)
+ {
+ yield return new KeyValuePair(provider, string.Empty);
+ continue;
+ }
+
+ foreach (var value in values)
+ {
+ yield return new KeyValuePair(provider, value);
+ }
+ }
+ }
+
+ ///
+ /// Matches items against a set of (provider, value) pairs, where an empty value means any value for
+ /// that provider. Emits a single EXISTS over the provider collection with the predicates OR'd, rather
+ /// than one subquery per predicate group.
+ ///
+ private static IQueryable WhereProviderMatch(
+ this IQueryable baseQuery,
+ IEnumerable> providerIds,
+ bool invert)
+ {
+ ArgumentNullException.ThrowIfNull(providerIds);
+
+ var existenceOnly = new List();
+ var specificValues = new List();
+ foreach (var (provider, value) in providerIds)
+ {
+ if (string.IsNullOrEmpty(value))
+ {
+ existenceOnly.Add(provider);
+ }
+ else
+ {
+ specificValues.Add(provider + ":" + value);
+ }
+ }
if (existenceOnly.Count == 0 && specificValues.Count == 0)
{
return baseQuery;
}
- if (existenceOnly.Count == 0)
- {
- return baseQuery.Where(e => e.Provider!.Any(p =>
- specificValues.Contains(p.ProviderId + ":" + p.ProviderValue)));
- }
+ var predicate = ProviderPredicate(existenceOnly, specificValues);
- if (specificValues.Count == 0)
- {
- return baseQuery.Where(e => e.Provider!.Any(p => existenceOnly.Contains(p.ProviderId)));
- }
-
- // Single EXISTS over Provider with both predicates OR'd, instead of two separate subqueries.
- return baseQuery.Where(e => e.Provider!.Any(p =>
- existenceOnly.Contains(p.ProviderId) ||
- specificValues.Contains(p.ProviderId + ":" + p.ProviderValue)));
+ // NOT EXISTS rather than NOT IN: the latter yields no rows at all if the subquery can produce NULL.
+ return invert
+ ? baseQuery.Where(e => !e.Provider!.AsQueryable().Any(predicate))
+ : baseQuery.Where(e => e.Provider!.AsQueryable().Any(predicate));
}
- ///
- /// Excludes items that match any of the specified (provider name, value) pairs.
- ///
- /// The source query.
- /// Dictionary mapping provider names to values to exclude.
- /// A filtered query.
- public static IQueryable WhereExcludeProviderIds(
- this IQueryable baseQuery,
- IReadOnlyDictionary providerIds)
+ private static Expression> ProviderPredicate(
+ IReadOnlyList existenceOnly,
+ IReadOnlyList specificValues)
{
- var excludeKeys = providerIds
- .Select(e => $"{e.Key}:{e.Value}")
- .ToList();
+ var byProvider = existenceOnly.OneOrManyExpressionBuilder(p => p.ProviderId);
+ var byPair = specificValues.OneOrManyExpressionBuilder(p => p.ProviderId + ":" + p.ProviderValue);
- if (excludeKeys.Count == 0)
- {
- return baseQuery;
- }
+ // Both builders mint their own parameter; rebind so the two bodies can share one lambda.
+ var parameter = byProvider.Parameters[0];
+ var reboundPair = ParameterReplacer.Replace, Func>(byPair, byPair.Parameters[0], parameter);
- return baseQuery.Where(e => e.Provider!.All(p => !excludeKeys.Contains(p.ProviderId + ":" + p.ProviderValue)));
- }
-
- ///
- /// Builds an optimised query expression checking one property against a list of values while maintaining an optimal query.
- ///
- /// The entity.
- /// The property type to compare.
- /// The list of items to check.
- /// Property expression.
- /// A Query.
- public static Expression> OneOrManyExpressionBuilder(this IList oneOf, Expression> property)
- {
- var parameter = Expression.Parameter(typeof(TEntity), "item");
- property = ParameterReplacer.Replace, Func>(property, property.Parameters[0], parameter);
- if (oneOf.Count == 1)
- {
- var value = oneOf[0];
- if (typeof(TProperty).IsValueType)
- {
- return Expression.Lambda>(Expression.Equal(property.Body, Expression.Constant(value)), parameter);
- }
- else
- {
- return Expression.Lambda>(Expression.ReferenceEqual(property.Body, Expression.Constant(value)), parameter);
- }
- }
-
- var containsMethodInfo = _containsQueryCache.GetOrAdd(typeof(TProperty), static (key) => _containsMethodGenericCache.MakeGenericMethod(key));
-
- // Always wrap the collection in EF.Parameter so EF Core caches a single compiled plan and reuses it across calls.
- return Expression.Lambda>(
- Expression.Call(
- null,
- containsMethodInfo,
- Expression.Call(null, _efParameterInstruction.MakeGenericMethod(oneOf.GetType()), Expression.Constant(oneOf)),
- property.Body),
+ return Expression.Lambda>(
+ Expression.OrElse(byProvider.Body, reboundPair.Body),
parameter);
}