fail quick connect closed on an unreachable valkey and restore the idempotent exchange

tests/Jellyfin.Server.Tests/QuickConnect/QuickConnectStoreWiringTests.cs

@@ -59,7 +59,7 @@ public sealed class QuickConnectStoreWiringTests : IAsyncLifetime
     [Fact]
     public async Task ManifestStyleEnvironmentVariable_SelectsTheSharedStore()
     {
-        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, _redis.ConnectionString + ",abortConnect=false");
+        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, _redis.ConnectionString);
 
         await using var provider = BuildProvider();
 
@@ -76,45 +76,50 @@ public sealed class QuickConnectStoreWiringTests : IAsyncLifetime
     }
 
     /// <summary>
-    /// Without the variable the deployment is single-instance and gets the process-local store.
-    /// </summary>
-    [Fact]
-    public void NoEnvironmentVariable_SelectsTheProcessLocalStore()
-    {
-        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, null);
-
-        using var provider = BuildProvider();
-
-        Assert.IsType<InMemoryQuickConnectStore>(provider.GetRequiredService<IQuickConnectStore>());
-    }
-
-    /// <summary>
-    /// A configured but unreachable Redis degrades to the single-instance behaviour of a flow having to
-    /// complete against one instance, rather than taking quick connect down at startup.
+    /// Without the variable the deployment is single-instance and gets the process-local store, which
+    /// runs a whole flow on its own.
     /// </summary>
     /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
     [Fact]
-    public async Task UnreachableRedisAtStartup_DegradesToTheProcessLocalStore()
+    public async Task NoEnvironmentVariable_SelectsTheProcessLocalStore()
     {
-        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, "127.0.0.1:1,connectTimeout=250,connectRetry=0");
+        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, null);
 
         await using var provider = BuildProvider();
 
         var store = provider.GetRequiredService<IQuickConnectStore>();
         Assert.IsType<InMemoryQuickConnectStore>(store);
 
-        // Quick connect still works, it just cannot span instances.
+        var cancellationToken = TestContext.Current.CancellationToken;
         var request = NewRequest();
-        await store.SetRequestAsync(request, DateTime.UtcNow.AddMinutes(10), TestContext.Current.CancellationToken);
-        Assert.True(await store.TryClaimAuthorizationAsync(request.Secret, DateTime.UtcNow.AddMinutes(10), TestContext.Current.CancellationToken));
+        await store.SetRequestAsync(request, DateTime.UtcNow.AddMinutes(10), cancellationToken);
+
+        Assert.Equal(request.Secret, (await store.GetRequestByCodeAsync(request.Code, cancellationToken))?.Secret);
+        Assert.True(await store.TryClaimAuthorizationAsync(request.Secret, DateTime.UtcNow.AddMinutes(10), cancellationToken));
+
         await store.SetAuthorizationAsync(
             request.Secret,
             new AuthenticationResult { AccessToken = "token-1" },
             DateTime.UtcNow.AddMinutes(10),
-            TestContext.Current.CancellationToken);
+            cancellationToken);
 
-        Assert.Equal("token-1", (await store.TryConsumeAuthorizationAsync(request.Secret, TestContext.Current.CancellationToken))?.AccessToken);
-        Assert.Null(await store.TryConsumeAuthorizationAsync(request.Secret, TestContext.Current.CancellationToken));
+        Assert.Equal("token-1", (await store.GetAuthorizationAsync(request.Secret, cancellationToken))?.AccessToken);
+        Assert.Equal("token-1", (await store.GetAuthorizationAsync(request.Secret, cancellationToken))?.AccessToken);
+    }
+
+    /// <summary>
+    /// A connection string that is set but unreachable is a misconfigured multi-instance deployment. It
+    /// fails rather than handing out a store the other instances cannot see, which would put quick
+    /// connect back on the cross-instance behaviour this configuration exists to fix.
+    /// </summary>
+    [Fact]
+    public void UnreachableRedisAtStartup_FailsClosed()
+    {
+        Environment.SetEnvironmentVariable(RedisConnectionStringVariable, "127.0.0.1:1,connectTimeout=250,connectRetry=0");
+
+        using var provider = BuildProvider();
+
+        Assert.ThrowsAny<RedisConnectionException>(() => provider.GetRequiredService<IQuickConnectStore>());
     }
 
     private static QuickConnectResult NewRequest() => new QuickConnectResult(