Commit Graph

63 Commits

Author SHA1 Message Date
zerafachris 20678c9a8c fix: return fallback gracefully when requested fallback font is missing
GetFallbackFont() called .First() on the font file sequence, which throws
System.InvalidOperationException when no file matched the requested name,
causing HTTP 500. Change to .FirstOrDefault() so a missing font falls
through to the existing null guard and returns HTTP 200 OK (the empty
response is intentional to avoid breaking SubtitlesOctopus).

Fixes #17683.

Prepared with AI assistance (Claude Code, Anthropic), reviewed for correctness before submission.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-09-01 16:25:59 +02:00
Niels van Velzen 3b8e614819 Prefer ApiKey over api_key in generated URL's (#13342) 2025-01-11 09:35:44 -07:00
Cody Robibero 6fb6b5f176 Validate item access (#11171) 2024-04-14 08:18:36 -06:00
Niels van Velzen 3d7d0297fe Fix policy for GetRemoteSubtitles
Other operations related to remote subtitles require the SubtitleManagement policy, so it only makes sense that this operation requires it too.
2024-04-08 22:24:24 +02:00
Cody Robibero 2e0e1ecc99 Rename route parameters that are id to be more descriptive 2024-02-26 15:57:59 -07:00
Cody Robibero 0bc41c015f Store lyrics in the database as media streams (#9951) 2024-02-26 05:09:40 -07:00
Patrick Barron de0241e975 Move API policies to MediaBrowser.Common 2023-11-12 10:24:35 -05:00
chinkara 8ada8dbbac add policy to the subtitle controller 2023-10-18 18:31:32 +02:00
Bond_009 efc4c305a9 Use CryptoStream to convert stream from base64
Should be way more efficient
2023-10-05 23:36:37 +02:00
MBR-0001 9564248b10 Add ability to upload (and save) SDH subtitles (#10036) 2023-07-29 06:52:35 -06:00
Stepan Goremykin 910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
cvium 209edd38a4 refactor: simplify authz 2023-02-09 13:51:37 +01:00
Shadowghost f5f890e685 Migrate to file-scoped namespaces 2023-02-02 18:50:33 +01:00
Bond-009 69a51c425a Fix all warnings in Jellyfin.Api (#9003) 2023-01-04 08:01:31 -07:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
cvium 5dc30c6a6d fix: use HttpContext and ClaimsPrincipal instead of IAuthorizationContext 2022-10-06 13:57:47 +02:00
Bond_009 5726535a26 Fix some warnings
609 left
2021-11-09 13:14:31 +01:00
MBR-0001 ade3afad41 Add IsAutomated to SubtitleSearchRequest 2021-10-19 21:06:05 +02:00
cvium 229917a2f8 Queue refresh after subtitle upload + minor fixes 2021-10-04 21:12:09 +02:00
Cody Robibero 9234e5bf80 Remove all instances of en-US culture 2021-09-26 09:11:25 -06:00
Patrick Barron be88efce3c Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Devices/DeviceManager.cs
#	Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
#	Emby.Server.Implementations/Security/AuthenticationRepository.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Net/ISessionContext.cs
2021-06-18 18:56:10 -04:00
Niels van Velzen 0a0e10e854 Fix routeMediaSourceId route parameter in SubtitleController GetSubtitle 2021-06-12 15:38:13 +02:00
Patrick Barron a0c6f72762 Migrate authentication db to EF Core 2021-05-20 23:56:59 -04:00
crobibero afe3b5999e Fix route naming 2021-03-26 17:40:55 -06:00
crobibero 5b758c4711 Mark query parameters as obsolete 2021-03-26 07:07:45 -06:00
crobibero e0ff51cf2a Mark query parameters as obsolete 2021-03-25 20:30:15 -06:00
crobibero 73fe9d3f69 Allow subtitle format to be set from query parameter. 2021-03-25 18:06:25 -06:00
crobibero 5f998bdd1f Require elevated auth to upload subtitles 2021-01-10 10:48:37 -07:00
crobibero 547ee88561 Remove api client generator errors 2020-11-15 10:58:39 -07:00
nyanmisaka 2229ca38ac pascal case 2020-11-08 19:33:40 +08:00
nyanmisaka 737cb727f9 Merge remote-tracking branch 'upstream/master' into fonts 2020-11-08 19:11:54 +08:00
Claus Vium 96dcd9c87e Merge pull request #3086 from redSpoutnik/api-upload-subtitle
Add Post subtitle in API
2020-11-08 11:32:53 +01:00
Bond_009 2dbf73b989 Minor improvements 2020-09-16 14:16:44 +02:00
crobibero e3fb7f426c Migrate subtitle upload to Jellyfin.Api 2020-09-11 16:08:49 -06:00
crobibero efce4d4bf3 Merge remote-tracking branch 'upstream/master' into bad-route 2020-09-09 14:23:53 -06:00
crobibero 7294dc103f Fix api routes 2020-09-07 18:45:06 -06:00
crobibero eab92a0b01 Merge remote-tracking branch 'upstream/master' into api-stream-return 2020-09-06 14:34:31 -06:00
crobibero 29fc882037 merge all attributes 2020-09-06 09:07:27 -06:00
crobibero 59d47ec3f5 Make all FromRoute required 2020-09-05 17:07:25 -06:00
crobibero ec2a5e4fb0 Simplify file returns 2020-09-01 19:27:57 -06:00
crobibero 2f33bee2a9 Set openapi schema type to file where possible 2020-09-01 17:26:49 -06:00
Nyanmisaka 05e78ee78c Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-08-20 22:53:36 +08:00
nyanmisaka dd3b48f203 fix lint 2020-08-20 15:17:42 +08:00
Nyanmisaka 16658c92fe fix SubtitlesOctopus 2020-08-20 00:08:44 +08:00
Nyanmisaka 53861db451 Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-08-20 00:04:55 +08:00
nyanmisaka 988e76d4c7 update endpoints as AspNet controllers 2020-08-19 17:30:22 +08:00
crobibero fffa94fc33 Apply fixes from review 2020-08-06 08:17:45 -06:00
crobibero 393666efcf fix merge conflicts 2020-08-04 20:30:45 -06:00
crobibero 858aecd409 Fix all route for base url support 2020-08-04 12:48:53 -06:00