Commit Graph

33 Commits

Author SHA1 Message Date
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Joe Rogers 6252bc399a Fix unit tests after merge from master
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-11-23 15:59:50 +01:00
Claus Vium 81b04ddbb5 Merge branch 'master' into providermanager-cleanup 2022-10-07 09:57:16 +02:00
Cody Robibero 6004060b4e Fix build errors from new warnings 2022-09-09 07:44:14 -06:00
Joe Rogers 6bf71c0fd3 Combine verify calls
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-04-03 23:36:33 +02:00
Joe Rogers b03f56c3d6 Remove warnings 2022-04-03 23:36:32 +02:00
Joe Rogers ee5bd0daa6 Implement tests on ProviderManager.RefreshSingleItem 2022-04-03 23:36:32 +02:00
Joe Rogers bdce435b09 Reorder and flatten provider filtering 2022-04-03 23:36:30 +02:00
Joe Rogers 6ab64f4930 Switch to nameof to simplify theory signatures 2022-04-03 23:34:50 +02:00
Joe Rogers a7c009e2eb Pass TypeOptions instead of full LibraryOptions 2022-04-03 23:34:49 +02:00
Joe Rogers d5e2c2fb5e Implement CanRefreshMetadata tests for GetMetadataProviders
Cleanup tests, extract common blocks
2022-04-03 23:34:49 +02:00
Joe Rogers e7df72de49 Improve metadata provider sorting
Extract configured order up front instead of for each provider
Non-IHasOrder providers default to middle, not beginning
Merge image and metadata sort helper methods
2022-04-03 23:34:49 +02:00
Joe Rogers 91e706d387 Implement sort test for ProviderManager.GetMetadataProviders 2022-04-03 23:34:49 +02:00
Joe Rogers 11c7c24f0e Clarify naming, minor method ordering improvement 2022-04-03 23:34:49 +02:00
Joe Rogers 56900d0fc3 Implement CanRefresh tests for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
Joe Rogers 8515e8fbd1 Improve image provider sorting
Remove irrelevant check for ILocalImageProvider
Providers that are not IHasOrder default to middle, not beginning
2022-04-03 23:34:48 +02:00
Joe Rogers 785cc1bb6e Implement sort test for ProviderManager.GetImageProviders 2022-04-03 23:34:48 +02:00
Joe Rogers f87e780fb5 Address review comments
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-01-16 13:21:24 +01:00
Joe Rogers 1dfbeae045 Embed ProviderUtils into MetadataService 2022-01-04 00:44:03 +01:00
Joe Rogers c81d2e9dec Remove existing images when applying identify 2022-01-03 23:41:13 +01:00
Joe Rogers 29755c9384 Merge a couple tests, extract duplicate code 2022-01-02 22:24:04 +01:00
Joe Rogers 608a91162a Add test for #6830 2022-01-02 22:23:47 +01:00
Joe Rogers 76e640b0b9 Add tests and documentation for ProviderUtils 2021-12-31 00:10:35 +01:00
Claus Vium c50c9c3dbf Merge pull request #6794 from Bond-009/dead
Remove some dead code
2021-11-09 19:47:34 +01:00
Bond_009 994101fcf4 Remove some dead code 2021-11-09 16:28:39 +01:00
Joe Rogers b4bf5af7c8 Remove ImageType.Screenshot and ItemFields.Screenshot 2021-11-06 20:43:20 +01:00
Bond_009 924c6682b9 Remove unused IHasScreenshots interface 2021-11-04 01:06:21 +01:00
Bond_009 416894008e Minor improvements
* Removed some allocations
* Removed some useless abstractions
2021-11-03 14:02:57 +01:00
Joe Rogers 149c77d9b1 Remove commented theory data, merge tests 2021-11-02 22:46:53 +01:00
Joe Rogers 7fcf01235c Change RemoveImages to array, improve download test 2021-11-02 16:16:06 +01:00
Joe Rogers b478b115e3 Refactor to validate all images up front 2021-11-01 11:53:31 +01:00
Joe Rogers 080b02cc4c Add comments, minor cleanup, add tests 2021-10-31 23:56:50 +01:00