Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 547333ecd2 |
@@ -1,8 +0,0 @@
|
|||||||
when:
|
|
||||||
- event: pull_request
|
|
||||||
|
|
||||||
steps:
|
|
||||||
- name: lint
|
|
||||||
image: golangci/golangci-lint:latest
|
|
||||||
commands:
|
|
||||||
- golangci-lint run ./...
|
|
||||||
@@ -1,8 +0,0 @@
|
|||||||
when:
|
|
||||||
- event: pull_request
|
|
||||||
|
|
||||||
steps:
|
|
||||||
- name: pre-commit
|
|
||||||
image: git.unkin.net/unkin/almalinux9-gobuilder:20260325
|
|
||||||
commands:
|
|
||||||
- uvx pre-commit run --all-files
|
|
||||||
@@ -1,37 +0,0 @@
|
|||||||
when:
|
|
||||||
- event: release
|
|
||||||
|
|
||||||
steps:
|
|
||||||
- name: test
|
|
||||||
image: golang:latest
|
|
||||||
commands:
|
|
||||||
- go test ./...
|
|
||||||
|
|
||||||
- name: build
|
|
||||||
image: golang:latest
|
|
||||||
commands:
|
|
||||||
- VERSION=${CI_COMMIT_TAG}
|
|
||||||
- go build -ldflags="-s -w -X main.version=${VERSION}" -o node-lookup ./...
|
|
||||||
depends_on: [test]
|
|
||||||
|
|
||||||
- name: release
|
|
||||||
image: git.unkin.net/unkin/almalinux9-base:20260325
|
|
||||||
environment:
|
|
||||||
RELEASER_TOKEN:
|
|
||||||
from_secret: RELEASER_TOKEN
|
|
||||||
commands:
|
|
||||||
- |
|
|
||||||
curl --output /usr/local/bin/tea https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/gitea-dl/tea/0.12.0/tea-0.12.0-linux-amd64 && chmod +x /usr/local/bin/tea
|
|
||||||
tea logins add --name gitea --url https://git.unkin.net --token "$${RELEASER_TOKEN}" --no-version-check
|
|
||||||
PREV_TAG=$(git describe --tags --abbrev=0 HEAD^ 2>/dev/null || echo "")
|
|
||||||
if [ -n "$PREV_TAG" ]; then
|
|
||||||
NOTES=$(git log "${PREV_TAG}..${CI_COMMIT_TAG}" --merges --pretty=format:"- %s")
|
|
||||||
else
|
|
||||||
NOTES=$(git log --merges --pretty=format:"- %s")
|
|
||||||
fi
|
|
||||||
tea releases edit "${CI_COMMIT_TAG}" --note "${NOTES}" --login gitea --repo "${CI_REPO}"
|
|
||||||
tea releases assets create "${CI_COMMIT_TAG}" node-lookup --login gitea --repo "${CI_REPO}"
|
|
||||||
backend_options:
|
|
||||||
kubernetes:
|
|
||||||
serviceAccountName: default
|
|
||||||
depends_on: [build]
|
|
||||||
@@ -1,8 +0,0 @@
|
|||||||
when:
|
|
||||||
- event: pull_request
|
|
||||||
|
|
||||||
steps:
|
|
||||||
- name: unit-tests
|
|
||||||
image: golang:latest
|
|
||||||
commands:
|
|
||||||
- go test -v -race ./...
|
|
||||||
@@ -29,7 +29,7 @@ Requires Go 1.21+. Dependencies: `github.com/spf13/cobra` (CLI), `gopkg.in/yaml.
|
|||||||
./node-lookup -n <hostname> # lookup a specific node
|
./node-lookup -n <hostname> # lookup a specific node
|
||||||
./node-lookup -F <fact_name> # filter by fact name
|
./node-lookup -F <fact_name> # filter by fact name
|
||||||
./node-lookup -m <value> # exact value match
|
./node-lookup -m <value> # exact value match
|
||||||
./node-lookup --pm <pattern> # partial/regex match on value
|
./node-lookup -p <pattern> # partial/regex match on value (also --pm)
|
||||||
./node-lookup -R -1 # node names only
|
./node-lookup -R -1 # node names only
|
||||||
./node-lookup -R -2 # values only
|
./node-lookup -R -2 # values only
|
||||||
./node-lookup -R -C # count occurrences
|
./node-lookup -R -C # count occurrences
|
||||||
@@ -94,6 +94,7 @@ No test suite exists. Manual testing requires access to the Consul/PuppetDB envi
|
|||||||
## Gotchas
|
## Gotchas
|
||||||
|
|
||||||
- `-1`, `-2`, `-C`, and `-A` all require `-R` or `-F`; the tool exits with an error otherwise.
|
- `-1`, `-2`, `-C`, and `-A` all require `-R` or `-F`; the tool exits with an error otherwise.
|
||||||
- `-C` (count) with stdin reads all lines as pre-fetched `"node value"` output for counting — it does **not** query PuppetDB per line.
|
- `-C` (count) with stdin extracts the first field of each line as the node name, queries PuppetDB per node, then counts the resulting values.
|
||||||
- JSON output (`-j`) builds `{ hostname: { factname: value } }` where the fact key is the `-F` value, the `role_fact` config value (if `-R`), or `"value"` as fallback.
|
- JSON output (`-j`) builds `{ hostname: { factname: value } }` where the fact key is the `-F` value, the `role_fact` config value (if `-R`), or `"value"` as fallback.
|
||||||
- `config init` fails if the config file already exists (will not overwrite).
|
- `config init` fails if the config file already exists (will not overwrite).
|
||||||
|
- `--pm` has shorthand `-p`. Use `-p <pattern>` or `--pm <pattern>` — not `-pm <pattern>` (pflag parses single-dash multi-char as combined shorthands).
|
||||||
|
|||||||
@@ -1,8 +1,7 @@
|
|||||||
BINARY := node-lookup
|
BINARY := node-lookup
|
||||||
VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)
|
GOFLAGS := -ldflags="-s -w"
|
||||||
GOFLAGS := -ldflags="-s -w -X main.version=$(VERSION)"
|
|
||||||
|
|
||||||
.PHONY: all build test lint clean install patch minor major _release
|
.PHONY: all build test lint clean install
|
||||||
|
|
||||||
all: build
|
all: build
|
||||||
|
|
||||||
@@ -20,27 +19,3 @@ clean:
|
|||||||
|
|
||||||
install:
|
install:
|
||||||
go install $(GOFLAGS) ./...
|
go install $(GOFLAGS) ./...
|
||||||
|
|
||||||
# Bump helpers — reads the latest semver tag and creates the next one.
|
|
||||||
# If no tag exists yet, starts from v0.0.0.
|
|
||||||
_LATEST := $(shell git tag --sort=-v:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$$' | head -1)
|
|
||||||
_BASE := $(if $(_LATEST),$(_LATEST),v0.0.0)
|
|
||||||
_MAJ := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f1)
|
|
||||||
_MIN := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f2)
|
|
||||||
_PAT := $(shell echo $(_BASE) | sed 's/^v//' | cut -d. -f3)
|
|
||||||
|
|
||||||
patch:
|
|
||||||
@NEW=v$(_MAJ).$(_MIN).$(shell expr $(_PAT) + 1); \
|
|
||||||
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
|
|
||||||
|
|
||||||
minor:
|
|
||||||
@NEW=v$(_MAJ).$(shell expr $(_MIN) + 1).0; \
|
|
||||||
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
|
|
||||||
|
|
||||||
major:
|
|
||||||
@NEW=v$(shell expr $(_MAJ) + 1).0.0; \
|
|
||||||
git tag $$NEW && echo "Tagged $$NEW" && $(MAKE) _release TAG=$$NEW
|
|
||||||
|
|
||||||
_release:
|
|
||||||
git push origin $(TAG)
|
|
||||||
tea releases create --tag $(TAG) --title $(TAG)
|
|
||||||
|
|||||||
@@ -25,8 +25,6 @@ const (
|
|||||||
appName = "node-lookup"
|
appName = "node-lookup"
|
||||||
)
|
)
|
||||||
|
|
||||||
var version = "dev"
|
|
||||||
|
|
||||||
// config holds all configurable values. Fields map 1:1 to config file keys,
|
// config holds all configurable values. Fields map 1:1 to config file keys,
|
||||||
// env vars (NODE_LOOKUP_*), and (where applicable) CLI flags.
|
// env vars (NODE_LOOKUP_*), and (where applicable) CLI flags.
|
||||||
type config struct {
|
type config struct {
|
||||||
@@ -110,7 +108,7 @@ type fact struct {
|
|||||||
Value json.RawMessage `json:"value"`
|
Value json.RawMessage `json:"value"`
|
||||||
}
|
}
|
||||||
|
|
||||||
func buildQuery(node, factName, match, partialMatch, roleFact string, showRole bool) string {
|
func buildQuery(node, factName, match, partialMatch, inverseMatch, roleFact string, showRole bool) string {
|
||||||
type filter = []interface{}
|
type filter = []interface{}
|
||||||
var filters []filter
|
var filters []filter
|
||||||
|
|
||||||
@@ -127,6 +125,8 @@ func buildQuery(node, factName, match, partialMatch, roleFact string, showRole b
|
|||||||
filters = append(filters, filter{"=", "value", match})
|
filters = append(filters, filter{"=", "value", match})
|
||||||
} else if partialMatch != "" {
|
} else if partialMatch != "" {
|
||||||
filters = append(filters, filter{"~", "value", partialMatch})
|
filters = append(filters, filter{"~", "value", partialMatch})
|
||||||
|
} else if inverseMatch != "" {
|
||||||
|
filters = append(filters, filter{"not", filter{"~", "value", inverseMatch}})
|
||||||
}
|
}
|
||||||
|
|
||||||
if len(filters) == 0 {
|
if len(filters) == 0 {
|
||||||
@@ -150,7 +150,7 @@ func queryPuppetDB(puppetDBURL, query string) ([]fact, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("request failed: %w", err)
|
return nil, fmt.Errorf("request failed: %w", err)
|
||||||
}
|
}
|
||||||
defer func() { _ = resp.Body.Close() }()
|
defer resp.Body.Close()
|
||||||
|
|
||||||
if resp.StatusCode != http.StatusOK {
|
if resp.StatusCode != http.StatusOK {
|
||||||
body, _ := io.ReadAll(resp.Body)
|
body, _ := io.ReadAll(resp.Body)
|
||||||
@@ -176,7 +176,7 @@ func valueString(raw json.RawMessage) string {
|
|||||||
|
|
||||||
func valueAny(raw json.RawMessage) interface{} {
|
func valueAny(raw json.RawMessage) interface{} {
|
||||||
var v interface{}
|
var v interface{}
|
||||||
_ = json.Unmarshal(raw, &v)
|
json.Unmarshal(raw, &v)
|
||||||
return v
|
return v
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -215,53 +215,27 @@ func isTerminal(f *os.File) bool {
|
|||||||
return (fi.Mode() & os.ModeCharDevice) != 0
|
return (fi.Mode() & os.ModeCharDevice) != 0
|
||||||
}
|
}
|
||||||
|
|
||||||
func allFactsForNode(puppetDBURL, node string) ([]fact, error) {
|
func run(cfg config, nodeName, factName, match, partialMatch, inverseMatch string, showRole, nodeOnly, valueOnly, count, ansible, jsonMode bool) error {
|
||||||
query, _ := json.Marshal([]interface{}{"=", "certname", node})
|
|
||||||
return queryPuppetDB(puppetDBURL, string(query))
|
|
||||||
}
|
|
||||||
|
|
||||||
func run(cfg config, nodeName, factName, match, partialMatch string, showRole, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts bool) error {
|
|
||||||
signal.Ignore(syscall.SIGPIPE)
|
signal.Ignore(syscall.SIGPIPE)
|
||||||
|
|
||||||
if allFacts {
|
|
||||||
if nodeName == "" {
|
|
||||||
return fmt.Errorf("-a requires -n")
|
|
||||||
}
|
|
||||||
facts, err := allFactsForNode(cfg.PuppetDBURL, nodeName)
|
|
||||||
if err != nil {
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
sort.Slice(facts, func(i, j int) bool { return facts[i].Name < facts[j].Name })
|
|
||||||
for _, f := range facts {
|
|
||||||
fmt.Printf("%-40s %s\n", f.Name, valueString(f.Value))
|
|
||||||
}
|
|
||||||
return nil
|
|
||||||
}
|
|
||||||
|
|
||||||
if (nodeOnly || valueOnly || count || ansible) && !showRole && factName == "" {
|
if (nodeOnly || valueOnly || count || ansible) && !showRole && factName == "" {
|
||||||
return fmt.Errorf("-R or -F must be used with -1, -2, -C, or -A")
|
return fmt.Errorf("-R or -F must be used with -1, -2, -C, or -A")
|
||||||
}
|
}
|
||||||
|
|
||||||
var collected []fact
|
var allFacts []fact
|
||||||
var stdinLines []string
|
|
||||||
|
|
||||||
doQuery := func(node string) error {
|
doQuery := func(node string) error {
|
||||||
query := buildQuery(node, factName, match, partialMatch, cfg.RoleFact, showRole)
|
query := buildQuery(node, factName, match, partialMatch, inverseMatch, cfg.RoleFact, showRole)
|
||||||
facts, err := queryPuppetDB(cfg.PuppetDBURL, query)
|
facts, err := queryPuppetDB(cfg.PuppetDBURL, query)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
collected = append(collected, facts...)
|
allFacts = append(allFacts, facts...)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
if nodeName == "" && !isTerminal(os.Stdin) {
|
if nodeName == "" && !isTerminal(os.Stdin) {
|
||||||
scanner := bufio.NewScanner(os.Stdin)
|
scanner := bufio.NewScanner(os.Stdin)
|
||||||
if count {
|
|
||||||
for scanner.Scan() {
|
|
||||||
stdinLines = append(stdinLines, scanner.Text())
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
for scanner.Scan() {
|
for scanner.Scan() {
|
||||||
fields := strings.Fields(scanner.Text())
|
fields := strings.Fields(scanner.Text())
|
||||||
if len(fields) == 0 {
|
if len(fields) == 0 {
|
||||||
@@ -271,19 +245,18 @@ func run(cfg config, nodeName, factName, match, partialMatch string, showRole, n
|
|||||||
fmt.Fprintln(os.Stderr, "error:", err)
|
fmt.Fprintln(os.Stderr, "error:", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
if err := doQuery(nodeName); err != nil {
|
if err := doQuery(nodeName); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
returnData := processResults(collected)
|
returnData := processResults(allFacts)
|
||||||
|
|
||||||
switch {
|
switch {
|
||||||
case jsonMode:
|
case jsonMode:
|
||||||
hostFactMap := map[string]map[string]interface{}{}
|
hostFactMap := map[string]map[string]interface{}{}
|
||||||
for _, f := range collected {
|
for _, f := range allFacts {
|
||||||
if _, ok := hostFactMap[f.Certname]; !ok {
|
if _, ok := hostFactMap[f.Certname]; !ok {
|
||||||
hostFactMap[f.Certname] = map[string]interface{}{}
|
hostFactMap[f.Certname] = map[string]interface{}{}
|
||||||
}
|
}
|
||||||
@@ -300,14 +273,10 @@ func run(cfg config, nodeName, factName, match, partialMatch string, showRole, n
|
|||||||
enc := json.NewEncoder(os.Stdout)
|
enc := json.NewEncoder(os.Stdout)
|
||||||
enc.SetIndent("", " ")
|
enc.SetIndent("", " ")
|
||||||
enc.SetEscapeHTML(false)
|
enc.SetEscapeHTML(false)
|
||||||
_ = enc.Encode(hostFactMap)
|
enc.Encode(hostFactMap)
|
||||||
|
|
||||||
case count:
|
case count:
|
||||||
values := stdinLines
|
fmt.Println(strings.Join(countResults(returnData), "\n"))
|
||||||
if len(values) == 0 {
|
|
||||||
values = returnData
|
|
||||||
}
|
|
||||||
fmt.Println(strings.Join(countResults(values), "\n"))
|
|
||||||
|
|
||||||
case ansible:
|
case ansible:
|
||||||
hosts := map[string]interface{}{}
|
hosts := map[string]interface{}{}
|
||||||
@@ -319,7 +288,7 @@ func run(cfg config, nodeName, factName, match, partialMatch string, showRole, n
|
|||||||
"all": map[string]interface{}{"hosts": hosts},
|
"all": map[string]interface{}{"hosts": hosts},
|
||||||
}
|
}
|
||||||
b, _ := yaml.Marshal(inventory)
|
b, _ := yaml.Marshal(inventory)
|
||||||
_, _ = os.Stdout.Write(b)
|
os.Stdout.Write(b)
|
||||||
|
|
||||||
case nodeOnly:
|
case nodeOnly:
|
||||||
for _, line := range returnData {
|
for _, line := range returnData {
|
||||||
@@ -342,6 +311,18 @@ func run(cfg config, nodeName, factName, match, partialMatch string, showRole, n
|
|||||||
}
|
}
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
|
for i, arg := range os.Args {
|
||||||
|
if arg == "-pm" {
|
||||||
|
os.Args[i] = "--pm"
|
||||||
|
} else if strings.HasPrefix(arg, "-pm=") {
|
||||||
|
os.Args[i] = "--pm=" + arg[4:]
|
||||||
|
} else if arg == "-im" {
|
||||||
|
os.Args[i] = "--im"
|
||||||
|
} else if strings.HasPrefix(arg, "-im=") {
|
||||||
|
os.Args[i] = "--im=" + arg[4:]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
cfg, err := loadConfig()
|
cfg, err := loadConfig()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintln(os.Stderr, "config error:", err)
|
fmt.Fprintln(os.Stderr, "config error:", err)
|
||||||
@@ -354,12 +335,12 @@ func main() {
|
|||||||
showRole bool
|
showRole bool
|
||||||
match string
|
match string
|
||||||
partialMatch string
|
partialMatch string
|
||||||
|
inverseMatch string
|
||||||
nodeOnly bool
|
nodeOnly bool
|
||||||
valueOnly bool
|
valueOnly bool
|
||||||
count bool
|
count bool
|
||||||
ansible bool
|
ansible bool
|
||||||
jsonMode bool
|
jsonMode bool
|
||||||
allFacts bool
|
|
||||||
puppetDBURL string
|
puppetDBURL string
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -373,7 +354,7 @@ func main() {
|
|||||||
return nil
|
return nil
|
||||||
},
|
},
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
return run(cfg, nodeName, factName, match, partialMatch, showRole, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts)
|
return run(cfg, nodeName, factName, match, partialMatch, inverseMatch, showRole, nodeOnly, valueOnly, count, ansible, jsonMode)
|
||||||
},
|
},
|
||||||
SilenceUsage: true,
|
SilenceUsage: true,
|
||||||
}
|
}
|
||||||
@@ -383,13 +364,13 @@ func main() {
|
|||||||
f.StringVarP(&factName, "fact", "F", "", "Fact name")
|
f.StringVarP(&factName, "fact", "F", "", "Fact name")
|
||||||
f.BoolVarP(&showRole, "role", "R", false, "Show role fact ("+defaultRoleFact+" by default)")
|
f.BoolVarP(&showRole, "role", "R", false, "Show role fact ("+defaultRoleFact+" by default)")
|
||||||
f.StringVarP(&match, "match", "m", "", "Exact value match")
|
f.StringVarP(&match, "match", "m", "", "Exact value match")
|
||||||
f.StringVar(&partialMatch, "pm", "", "Partial match on value")
|
f.StringVar(&partialMatch, "pm", "", "Partial/regex match on value")
|
||||||
|
f.StringVar(&inverseMatch, "im", "", "Inverse partial/regex match on value")
|
||||||
f.BoolVarP(&nodeOnly, "nodeonly", "1", false, "Show only the node name")
|
f.BoolVarP(&nodeOnly, "nodeonly", "1", false, "Show only the node name")
|
||||||
f.BoolVarP(&valueOnly, "valueonly", "2", false, "Show only the value")
|
f.BoolVarP(&valueOnly, "valueonly", "2", false, "Show only the value")
|
||||||
f.BoolVarP(&count, "count", "C", false, "Count fact occurrences")
|
f.BoolVarP(&count, "count", "C", false, "Count fact occurrences")
|
||||||
f.BoolVarP(&ansible, "ansible", "A", false, "Output as Ansible inventory")
|
f.BoolVarP(&ansible, "ansible", "A", false, "Output as Ansible inventory")
|
||||||
f.BoolVarP(&jsonMode, "json", "j", false, "Emit valid JSON for all output")
|
f.BoolVarP(&jsonMode, "json", "j", false, "Emit valid JSON for all output")
|
||||||
f.BoolVarP(&allFacts, "all", "a", false, "Show all facts for a node (requires -n)")
|
|
||||||
rootCmd.PersistentFlags().StringVar(&puppetDBURL, "url", cfg.PuppetDBURL, "PuppetDB facts URL (overrides config and NODE_LOOKUP_URL)")
|
rootCmd.PersistentFlags().StringVar(&puppetDBURL, "url", cfg.PuppetDBURL, "PuppetDB facts URL (overrides config and NODE_LOOKUP_URL)")
|
||||||
|
|
||||||
configCmd := &cobra.Command{
|
configCmd := &cobra.Command{
|
||||||
@@ -421,14 +402,6 @@ func main() {
|
|||||||
configCmd.AddCommand(configInitCmd, configShowCmd)
|
configCmd.AddCommand(configInitCmd, configShowCmd)
|
||||||
rootCmd.AddCommand(configCmd)
|
rootCmd.AddCommand(configCmd)
|
||||||
|
|
||||||
versionCmd := &cobra.Command{
|
|
||||||
Use: "version",
|
|
||||||
Short: "Print the version",
|
|
||||||
Run: func(cmd *cobra.Command, args []string) { fmt.Println(version) },
|
|
||||||
SilenceUsage: true,
|
|
||||||
}
|
|
||||||
rootCmd.AddCommand(versionCmd)
|
|
||||||
|
|
||||||
if err := rootCmd.Execute(); err != nil {
|
if err := rootCmd.Execute(); err != nil {
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
|
|||||||
+23
-131
@@ -2,7 +2,6 @@ package main
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"io"
|
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"os"
|
"os"
|
||||||
@@ -13,11 +12,19 @@ import (
|
|||||||
|
|
||||||
// ---- helpers ----------------------------------------------------------------
|
// ---- helpers ----------------------------------------------------------------
|
||||||
|
|
||||||
|
func mustMarshal(v interface{}) []byte {
|
||||||
|
b, err := json.Marshal(v)
|
||||||
|
if err != nil {
|
||||||
|
panic(err)
|
||||||
|
}
|
||||||
|
return b
|
||||||
|
}
|
||||||
|
|
||||||
func newTestServer(t *testing.T, facts []fact) *httptest.Server {
|
func newTestServer(t *testing.T, facts []fact) *httptest.Server {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
w.Header().Set("Content-Type", "application/json")
|
w.Header().Set("Content-Type", "application/json")
|
||||||
_ = json.NewEncoder(w).Encode(facts)
|
json.NewEncoder(w).Encode(facts)
|
||||||
}))
|
}))
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -29,42 +36,42 @@ func rawJSON(v interface{}) json.RawMessage {
|
|||||||
// ---- buildQuery -------------------------------------------------------------
|
// ---- buildQuery -------------------------------------------------------------
|
||||||
|
|
||||||
func TestBuildQuery_NoFilters(t *testing.T) {
|
func TestBuildQuery_NoFilters(t *testing.T) {
|
||||||
q := buildQuery("", "", "", "", "enc_role", false)
|
q := buildQuery("", "", "", "", "", "enc_role", false)
|
||||||
if !strings.Contains(q, "enc_role") {
|
if !strings.Contains(q, "enc_role") {
|
||||||
t.Fatalf("expected default role query, got %s", q)
|
t.Fatalf("expected default role query, got %s", q)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildQuery_Node(t *testing.T) {
|
func TestBuildQuery_Node(t *testing.T) {
|
||||||
q := buildQuery("host1", "", "", "", "enc_role", false)
|
q := buildQuery("host1", "", "", "", "", "enc_role", false)
|
||||||
if !strings.Contains(q, "certname") || !strings.Contains(q, "host1") {
|
if !strings.Contains(q, "certname") || !strings.Contains(q, "host1") {
|
||||||
t.Fatalf("unexpected query: %s", q)
|
t.Fatalf("unexpected query: %s", q)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildQuery_FactAndMatch(t *testing.T) {
|
func TestBuildQuery_FactAndMatch(t *testing.T) {
|
||||||
q := buildQuery("", "region", "syd1", "", "enc_role", false)
|
q := buildQuery("", "region", "syd1", "", "", "enc_role", false)
|
||||||
if !strings.Contains(q, "region") || !strings.Contains(q, "syd1") {
|
if !strings.Contains(q, "region") || !strings.Contains(q, "syd1") {
|
||||||
t.Fatalf("unexpected query: %s", q)
|
t.Fatalf("unexpected query: %s", q)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildQuery_PartialMatch(t *testing.T) {
|
func TestBuildQuery_PartialMatch(t *testing.T) {
|
||||||
q := buildQuery("", "enc_role", "", "dns", "enc_role", false)
|
q := buildQuery("", "enc_role", "", "dns", "", "enc_role", false)
|
||||||
if !strings.Contains(q, "~") || !strings.Contains(q, "dns") {
|
if !strings.Contains(q, "~") || !strings.Contains(q, "dns") {
|
||||||
t.Fatalf("expected partial match query, got %s", q)
|
t.Fatalf("expected partial match query, got %s", q)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildQuery_ShowRole(t *testing.T) {
|
func TestBuildQuery_ShowRole(t *testing.T) {
|
||||||
q := buildQuery("", "", "", "", "my_role_fact", true)
|
q := buildQuery("", "", "", "", "", "my_role_fact", true)
|
||||||
if !strings.Contains(q, "my_role_fact") {
|
if !strings.Contains(q, "my_role_fact") {
|
||||||
t.Fatalf("expected role fact in query, got %s", q)
|
t.Fatalf("expected role fact in query, got %s", q)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBuildQuery_CustomRoleFact(t *testing.T) {
|
func TestBuildQuery_CustomRoleFact(t *testing.T) {
|
||||||
q := buildQuery("", "", "", "", "custom_role", true)
|
q := buildQuery("", "", "", "", "", "custom_role", true)
|
||||||
if !strings.Contains(q, "custom_role") {
|
if !strings.Contains(q, "custom_role") {
|
||||||
t.Fatalf("expected custom role fact, got %s", q)
|
t.Fatalf("expected custom role fact, got %s", q)
|
||||||
}
|
}
|
||||||
@@ -176,7 +183,7 @@ func TestQueryPuppetDB_HTTPError(t *testing.T) {
|
|||||||
|
|
||||||
func TestQueryPuppetDB_BadJSON(t *testing.T) {
|
func TestQueryPuppetDB_BadJSON(t *testing.T) {
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
_, _ = w.Write([]byte("not json"))
|
w.Write([]byte("not json"))
|
||||||
}))
|
}))
|
||||||
defer srv.Close()
|
defer srv.Close()
|
||||||
|
|
||||||
@@ -236,12 +243,8 @@ func TestLoadConfig_FileOverride(t *testing.T) {
|
|||||||
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
||||||
|
|
||||||
cfgDir := filepath.Join(dir, appName)
|
cfgDir := filepath.Join(dir, appName)
|
||||||
if err := os.MkdirAll(cfgDir, 0o755); err != nil {
|
os.MkdirAll(cfgDir, 0o755)
|
||||||
t.Fatal(err)
|
os.WriteFile(filepath.Join(cfgDir, configFileName), []byte("puppetdb_url: http://file:8080/facts\nrole_fact: file_role\n"), 0o644)
|
||||||
}
|
|
||||||
if err := os.WriteFile(filepath.Join(cfgDir, configFileName), []byte("puppetdb_url: http://file:8080/facts\nrole_fact: file_role\n"), 0o644); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
cfg, err := loadConfig()
|
cfg, err := loadConfig()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -262,12 +265,8 @@ func TestLoadConfig_EnvOverridesFile(t *testing.T) {
|
|||||||
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
||||||
|
|
||||||
cfgDir := filepath.Join(dir, appName)
|
cfgDir := filepath.Join(dir, appName)
|
||||||
if err := os.MkdirAll(cfgDir, 0o755); err != nil {
|
os.MkdirAll(cfgDir, 0o755)
|
||||||
t.Fatal(err)
|
os.WriteFile(filepath.Join(cfgDir, configFileName), []byte("puppetdb_url: http://file:8080/facts\n"), 0o644)
|
||||||
}
|
|
||||||
if err := os.WriteFile(filepath.Join(cfgDir, configFileName), []byte("puppetdb_url: http://file:8080/facts\n"), 0o644); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
cfg, err := loadConfig()
|
cfg, err := loadConfig()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -285,12 +284,8 @@ func TestLoadConfig_InvalidYAML(t *testing.T) {
|
|||||||
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
||||||
|
|
||||||
cfgDir := filepath.Join(dir, appName)
|
cfgDir := filepath.Join(dir, appName)
|
||||||
if err := os.MkdirAll(cfgDir, 0o755); err != nil {
|
os.MkdirAll(cfgDir, 0o755)
|
||||||
t.Fatal(err)
|
os.WriteFile(filepath.Join(cfgDir, configFileName), []byte(":\tinvalid: yaml:\n"), 0o644)
|
||||||
}
|
|
||||||
if err := os.WriteFile(filepath.Join(cfgDir, configFileName), []byte(":\tinvalid: yaml:\n"), 0o644); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
_, err := loadConfig()
|
_, err := loadConfig()
|
||||||
if err == nil {
|
if err == nil {
|
||||||
@@ -320,112 +315,9 @@ func TestWriteDefaultConfig_AlreadyExists(t *testing.T) {
|
|||||||
dir := t.TempDir()
|
dir := t.TempDir()
|
||||||
t.Setenv("XDG_CONFIG_HOME", dir)
|
t.Setenv("XDG_CONFIG_HOME", dir)
|
||||||
|
|
||||||
if err := writeDefaultConfig(); err != nil {
|
writeDefaultConfig()
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
err := writeDefaultConfig()
|
err := writeDefaultConfig()
|
||||||
if err == nil {
|
if err == nil {
|
||||||
t.Fatal("expected error when config already exists")
|
t.Fatal("expected error when config already exists")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// ---- allFactsForNode --------------------------------------------------------
|
|
||||||
|
|
||||||
func TestAllFactsForNode_ReturnsSortedFacts(t *testing.T) {
|
|
||||||
facts := []fact{
|
|
||||||
{Certname: "node1", Name: "zebra", Value: rawJSON("z-val")},
|
|
||||||
{Certname: "node1", Name: "alpha", Value: rawJSON("a-val")},
|
|
||||||
{Certname: "node1", Name: "middle", Value: rawJSON(42)},
|
|
||||||
}
|
|
||||||
srv := newTestServer(t, facts)
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
got, err := allFactsForNode(srv.URL+"/pdb/query/v4/facts", "node1")
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if len(got) != 3 {
|
|
||||||
t.Fatalf("expected 3 facts, got %d", len(got))
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestAllFactsForNode_QueryContainsCertname(t *testing.T) {
|
|
||||||
var receivedQuery string
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
receivedQuery = r.URL.Query().Get("query")
|
|
||||||
w.Header().Set("Content-Type", "application/json")
|
|
||||||
_ = json.NewEncoder(w).Encode([]fact{})
|
|
||||||
}))
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
_, _ = allFactsForNode(srv.URL+"/pdb/query/v4/facts", "mynode.example.com")
|
|
||||||
if !strings.Contains(receivedQuery, "mynode.example.com") {
|
|
||||||
t.Fatalf("expected certname in query, got: %s", receivedQuery)
|
|
||||||
}
|
|
||||||
if !strings.Contains(receivedQuery, "certname") {
|
|
||||||
t.Fatalf("expected 'certname' in query, got: %s", receivedQuery)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestAllFactsForNode_HTTPError(t *testing.T) {
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
http.Error(w, "internal error", http.StatusInternalServerError)
|
|
||||||
}))
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
_, err := allFactsForNode(srv.URL+"/pdb/query/v4/facts", "node1")
|
|
||||||
if err == nil {
|
|
||||||
t.Fatal("expected error for HTTP 500")
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---- run with -a flag -------------------------------------------------------
|
|
||||||
|
|
||||||
func TestRun_AllFacts_RequiresNode(t *testing.T) {
|
|
||||||
cfg := config{PuppetDBURL: "http://unused", RoleFact: "enc_role"}
|
|
||||||
err := run(cfg, "", "", "", "", false, false, false, false, false, false, true)
|
|
||||||
if err == nil || !strings.Contains(err.Error(), "-a requires -n") {
|
|
||||||
t.Fatalf("expected -a requires -n error, got: %v", err)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestRun_AllFacts_PrintsSortedByName(t *testing.T) {
|
|
||||||
facts := []fact{
|
|
||||||
{Certname: "node1", Name: "zzz_fact", Value: rawJSON("last")},
|
|
||||||
{Certname: "node1", Name: "aaa_fact", Value: rawJSON("first")},
|
|
||||||
{Certname: "node1", Name: "mmm_fact", Value: rawJSON(true)},
|
|
||||||
}
|
|
||||||
srv := newTestServer(t, facts)
|
|
||||||
defer srv.Close()
|
|
||||||
|
|
||||||
old := os.Stdout
|
|
||||||
r, w, _ := os.Pipe()
|
|
||||||
os.Stdout = w
|
|
||||||
|
|
||||||
cfg := config{PuppetDBURL: srv.URL + "/pdb/query/v4/facts", RoleFact: "enc_role"}
|
|
||||||
err := run(cfg, "node1", "", "", "", false, false, false, false, false, false, true)
|
|
||||||
|
|
||||||
_ = w.Close()
|
|
||||||
os.Stdout = old
|
|
||||||
var buf strings.Builder
|
|
||||||
_, _ = io.Copy(&buf, r)
|
|
||||||
out := buf.String()
|
|
||||||
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
lines := strings.Split(strings.TrimSpace(out), "\n")
|
|
||||||
if len(lines) != 3 {
|
|
||||||
t.Fatalf("expected 3 lines, got %d: %q", len(lines), out)
|
|
||||||
}
|
|
||||||
if !strings.HasPrefix(lines[0], "aaa_fact") {
|
|
||||||
t.Errorf("first line should be aaa_fact, got: %s", lines[0])
|
|
||||||
}
|
|
||||||
if !strings.HasPrefix(lines[1], "mmm_fact") {
|
|
||||||
t.Errorf("second line should be mmm_fact, got: %s", lines[1])
|
|
||||||
}
|
|
||||||
if !strings.HasPrefix(lines[2], "zzz_fact") {
|
|
||||||
t.Errorf("third line should be zzz_fact, got: %s", lines[2])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
Reference in New Issue
Block a user