Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 35edc9c547 | |||
| 182bd326b8 | |||
| 2aaffd7e31 | |||
| f296056360 | |||
| 5982d257d5 |
+8
-1
@@ -1,2 +1,9 @@
|
|||||||
node-lookup
|
# built binaries (repo root only — not the cmd/ source dirs)
|
||||||
|
/node-lookup
|
||||||
|
/pburl
|
||||||
|
/pblastreport
|
||||||
|
# cross-compiled release artifacts (e.g. node-lookup-linux-amd64)
|
||||||
|
/node-lookup-*
|
||||||
|
/pburl-*
|
||||||
|
/pblastreport-*
|
||||||
dist/
|
dist/
|
||||||
|
|||||||
+43
-16
@@ -17,16 +17,26 @@ steps:
|
|||||||
memory: 2Gi
|
memory: 2Gi
|
||||||
cpu: 2
|
cpu: 2
|
||||||
|
|
||||||
# Build the linux/amd64 binary into dist/ (consumed by the RPM step) plus the
|
# Build all binaries into dist/ (consumed by the RPM step) plus the
|
||||||
# cross-platform binaries attached to the Gitea release.
|
# cross-platform binaries attached to the Gitea release. Each tool is a
|
||||||
|
# separate main package, so they are built individually per os/arch.
|
||||||
- name: build
|
- name: build
|
||||||
image: git.unkin.net/unkin/almalinux9-gobuilder:20260606
|
image: git.unkin.net/unkin/almalinux9-gobuilder:20260606
|
||||||
commands:
|
commands:
|
||||||
- make build VERSION=${CI_COMMIT_TAG}
|
- make build VERSION=${CI_COMMIT_TAG}
|
||||||
- GOOS=linux GOARCH=amd64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-linux-amd64 ./...
|
# Shell variables/expansions are escaped as $$ so Woodpecker leaves them
|
||||||
- GOOS=linux GOARCH=arm64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-linux-arm64 ./...
|
# for the shell instead of substituting them (as pipeline vars) at parse
|
||||||
- GOOS=darwin GOARCH=amd64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-darwin-amd64 ./...
|
# time. ${CI_COMMIT_TAG} is a real Woodpecker var and stays single-$.
|
||||||
- GOOS=darwin GOARCH=arm64 go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" -o node-lookup-darwin-arm64 ./...
|
- |
|
||||||
|
for entry in "node-lookup:." "pburl:./cmd/pburl" "pblastreport:./cmd/pblastreport"; do
|
||||||
|
name="$${entry%%:*}"; pkg="$${entry##*:}"
|
||||||
|
for osarch in linux/amd64 linux/arm64 darwin/amd64 darwin/arm64; do
|
||||||
|
os="$${osarch%/*}"; arch="$${osarch#*/}"
|
||||||
|
GOOS="$$os" GOARCH="$$arch" \
|
||||||
|
go build -ldflags="-s -w -X main.version=${CI_COMMIT_TAG}" \
|
||||||
|
-o "$${name}-$${os}-$${arch}" "$$pkg"
|
||||||
|
done
|
||||||
|
done
|
||||||
depends_on: [test]
|
depends_on: [test]
|
||||||
backend_options:
|
backend_options:
|
||||||
kubernetes:
|
kubernetes:
|
||||||
@@ -101,18 +111,35 @@ steps:
|
|||||||
- |
|
- |
|
||||||
curl --output /usr/local/bin/tea https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/gitea-dl/tea/0.12.0/tea-0.12.0-linux-amd64 && chmod +x /usr/local/bin/tea
|
curl --output /usr/local/bin/tea https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/gitea-dl/tea/0.12.0/tea-0.12.0-linux-amd64 && chmod +x /usr/local/bin/tea
|
||||||
tea logins add --name gitea --url https://git.unkin.net --token "$${RELEASER_TOKEN}" --no-version-check
|
tea logins add --name gitea --url https://git.unkin.net --token "$${RELEASER_TOKEN}" --no-version-check
|
||||||
PREV_TAG=$(git describe --tags --abbrev=0 HEAD^ 2>/dev/null || echo "")
|
# $$ escapes shell vars/substitutions so Woodpecker doesn't blank them
|
||||||
if [ -n "$PREV_TAG" ]; then
|
# at parse time; ${CI_COMMIT_TAG}/${CI_REPO} are real Woodpecker vars.
|
||||||
NOTES=$(git log "${PREV_TAG}..${CI_COMMIT_TAG}" --pretty=format:"- %s")
|
# Find the previous release tag for the changelog range. Several tags can
|
||||||
|
# point at the same commit (e.g. v0.5.3 and v0.5.4), so we skip tags on
|
||||||
|
# the current commit and pick the newest semver tag that is a real
|
||||||
|
# ancestor of this one -- describe HEAD^ would jump too far back.
|
||||||
|
CUR_SHA=$$(git rev-list -n1 "${CI_COMMIT_TAG}")
|
||||||
|
PREV_TAG=""
|
||||||
|
for t in $$(git tag --sort=-v:refname); do
|
||||||
|
[ "$$t" = "${CI_COMMIT_TAG}" ] && continue
|
||||||
|
[ "$$(git rev-list -n1 "$$t")" = "$$CUR_SHA" ] && continue
|
||||||
|
if git merge-base --is-ancestor "$$t" "${CI_COMMIT_TAG}" 2>/dev/null; then
|
||||||
|
PREV_TAG="$$t"; break
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
if [ -n "$$PREV_TAG" ]; then
|
||||||
|
NOTES=$$(git log "$${PREV_TAG}..${CI_COMMIT_TAG}" --pretty=format:"- %s")
|
||||||
else
|
else
|
||||||
NOTES=$(git log --pretty=format:"- %s")
|
NOTES=$$(git log --pretty=format:"- %s")
|
||||||
fi
|
fi
|
||||||
tea releases create --tag "${CI_COMMIT_TAG}" --title "${CI_COMMIT_TAG}" --note "${NOTES}" --login gitea --repo "${CI_REPO}"
|
tea releases create --tag "${CI_COMMIT_TAG}" --title "${CI_COMMIT_TAG}" --note "$${NOTES}" --login gitea --repo "${CI_REPO}"
|
||||||
tea releases assets create "${CI_COMMIT_TAG}" \
|
# The build step writes the 12 cross-compiled binaries into the workspace
|
||||||
node-lookup-linux-amd64 \
|
# root; the package step writes the RPM to dist/. Generate a checksums
|
||||||
node-lookup-linux-arm64 \
|
# manifest over everything we attach so downloads can be verified.
|
||||||
node-lookup-darwin-amd64 \
|
RPM=$$(ls dist/*.rpm 2>/dev/null | head -1)
|
||||||
node-lookup-darwin-arm64 \
|
ASSETS="node-lookup-linux-amd64 node-lookup-linux-arm64 node-lookup-darwin-amd64 node-lookup-darwin-arm64 pburl-linux-amd64 pburl-linux-arm64 pburl-darwin-amd64 pburl-darwin-arm64 pblastreport-linux-amd64 pblastreport-linux-arm64 pblastreport-darwin-amd64 pblastreport-darwin-arm64"
|
||||||
|
[ -n "$$RPM" ] && ASSETS="$$ASSETS $$RPM"
|
||||||
|
sha256sum $$ASSETS > sha256sums.txt
|
||||||
|
tea releases assets create "${CI_COMMIT_TAG}" $$ASSETS sha256sums.txt \
|
||||||
--login gitea --repo "${CI_REPO}"
|
--login gitea --repo "${CI_REPO}"
|
||||||
depends_on: [upload-rpm]
|
depends_on: [upload-rpm]
|
||||||
backend_options:
|
backend_options:
|
||||||
|
|||||||
@@ -2,22 +2,39 @@
|
|||||||
|
|
||||||
## Project Overview
|
## Project Overview
|
||||||
|
|
||||||
`node-lookup` is a Go CLI tool that queries a PuppetDB API to retrieve and filter node facts.
|
This repo ships three related Puppet CLIs in one RPM:
|
||||||
|
|
||||||
|
- **`node-lookup`** — queries the PuppetDB API to retrieve and filter node facts.
|
||||||
|
- **`pburl`** — prints the Puppetboard node-page URL for each host (reads hosts
|
||||||
|
from args or piped `node-lookup` output). Output: `<host> <url>`.
|
||||||
|
- **`pblastreport`** — prints each host's last Puppet report time and its
|
||||||
|
Puppetboard URL. Output: `<host>\t<time>\t<url>`. Supports `--relative`/`-r`
|
||||||
|
(relative age) and `--timezone`/`-z <IANA>` (default: local timezone).
|
||||||
|
|
||||||
|
`node-lookup` is the module root; `pburl` and `pblastreport` live under `cmd/`
|
||||||
|
and share the `internal/puppet` package (config, PuppetDB `nodes` queries,
|
||||||
|
Puppetboard URL construction, stdin host reading).
|
||||||
|
|
||||||
## Structure
|
## Structure
|
||||||
|
|
||||||
```
|
```
|
||||||
main.go # entire application source
|
main.go # node-lookup CLI source (module root, package main)
|
||||||
main_test.go # unit tests (mock PuppetDB via httptest, no live deps)
|
main_test.go # node-lookup unit tests (mock PuppetDB via httptest)
|
||||||
|
cmd/pburl/main.go # pburl CLI
|
||||||
|
cmd/pblastreport/main.go # pblastreport CLI (report.go: report-time formatting)
|
||||||
|
internal/puppet/ # shared: config, puppetdb nodes query, board URLs, stdin
|
||||||
go.mod # Go module (module name: node-lookup)
|
go.mod # Go module (module name: node-lookup)
|
||||||
go.sum # dependency checksums
|
go.sum # dependency checksums
|
||||||
Makefile # build / test / lint / completions / rpm / version-bump targets
|
Makefile # build / test / lint / completions / rpm / version-bump targets
|
||||||
packaging/nfpm.yaml # nfpm spec (envsubst-templated) for the RPM
|
packaging/nfpm.yaml # nfpm spec (envsubst-templated) for the RPM (all 3 binaries)
|
||||||
scripts/build-rpm.sh # generates completions + packages the RPM with nfpm
|
scripts/build-rpm.sh # generates completions + packages the RPM with nfpm
|
||||||
.woodpecker/ # CI: build, test, pre-commit (PR) + release (tag)
|
.woodpecker/ # CI: build, test, pre-commit (PR) + release (tag)
|
||||||
dist/ # build output: binary, completions, RPM (not committed)
|
dist/ # build output: binaries, completions, RPM (not committed)
|
||||||
```
|
```
|
||||||
|
|
||||||
|
Every binary is a separate `main` package, so `make build` builds each with its
|
||||||
|
own `-o` (a single `go build ./...` can't emit multiple mains to one file).
|
||||||
|
|
||||||
## Build
|
## Build
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
@@ -59,19 +76,37 @@ installed. To load ad-hoc in the current shell, e.g. zsh:
|
|||||||
./node-lookup -R # show all nodes with role fact
|
./node-lookup -R # show all nodes with role fact
|
||||||
./node-lookup -n <hostname> # lookup a specific node
|
./node-lookup -n <hostname> # lookup a specific node
|
||||||
./node-lookup -F <fact_name> # filter by fact name
|
./node-lookup -F <fact_name> # filter by fact name
|
||||||
./node-lookup -m <value> # exact value match (-m)
|
./node-lookup -jF ipaddress,enc_role # several facts at once (comma-separated)
|
||||||
./node-lookup -pm <value> # partial/regex match (-p -m combined)
|
./node-lookup -R -m <value> # exact value match (-m)
|
||||||
./node-lookup -im <value> # inverse exact match (-i -m combined)
|
./node-lookup -R -pm <value> # partial/regex match (-p -m combined)
|
||||||
./node-lookup -ipm <value> # inverse partial match (-i -p -m combined)
|
./node-lookup -R -im <value> # inverse exact match (-i -m combined)
|
||||||
|
./node-lookup -R -ipm <value> # inverse partial match (-i -p -m combined)
|
||||||
|
./node-lookup -R -p <value> # value may also be given positionally
|
||||||
./node-lookup -R -1 # node names only
|
./node-lookup -R -1 # node names only
|
||||||
./node-lookup -R -2 # values only
|
./node-lookup -R -2 # values only
|
||||||
./node-lookup -R -C # count occurrences
|
./node-lookup -R -C # count occurrences
|
||||||
./node-lookup -R -A # output as Ansible YAML inventory
|
./node-lookup -R -A # output as Ansible YAML inventory (queried facts become host vars)
|
||||||
./node-lookup -j # output as JSON { host → { fact → value } }
|
./node-lookup -j # output as JSON { host → { fact → value } }
|
||||||
./node-lookup --url http://host:8080/... # override PuppetDB URL for this invocation
|
./node-lookup --url http://host:8080/... # override PuppetDB URL for this invocation
|
||||||
echo -e "node1\nnode2" | ./node-lookup -R # pipe node names via stdin
|
echo -e "node1\nnode2" | ./node-lookup -R # pipe node names via stdin
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### Companion tools
|
||||||
|
|
||||||
|
```bash
|
||||||
|
node-lookup -R | pburl # <host> <puppetboard-url> per line
|
||||||
|
pburl host1 host2 # hosts as args instead of stdin
|
||||||
|
|
||||||
|
node-lookup -R | pblastreport # <host> <last-report-time> <url>
|
||||||
|
pblastreport -r host1 # relative age (e.g. "3h ago")
|
||||||
|
pblastreport -z Asia/Singapore host1 # render the time in a specific IANA tz
|
||||||
|
```
|
||||||
|
|
||||||
|
Both read hostnames from arguments or the first field of each piped line (so
|
||||||
|
any `node-lookup` output mode works), de-duplicate, and share `node-lookup`'s
|
||||||
|
config file / env vars. `pblastreport` reads `report_timestamp` from the
|
||||||
|
PuppetDB v4 `nodes` endpoint (derived from the configured facts URL).
|
||||||
|
|
||||||
## Configuration
|
## Configuration
|
||||||
|
|
||||||
Precedence (lowest → highest): **defaults < config file < env vars < `--url` flag**
|
Precedence (lowest → highest): **defaults < config file < env vars < `--url` flag**
|
||||||
@@ -83,6 +118,7 @@ XDG location: `$XDG_CONFIG_HOME/node-lookup/config.yaml` (default: `~/.config/no
|
|||||||
```yaml
|
```yaml
|
||||||
puppetdb_url: http://puppetdbapi.service.consul:8080/pdb/query/v4/facts
|
puppetdb_url: http://puppetdbapi.service.consul:8080/pdb/query/v4/facts
|
||||||
role_fact: enc_role
|
role_fact: enc_role
|
||||||
|
puppetboard_url: https://puppetboard.k8s.syd1.au.unkin.net # used by pburl / pblastreport
|
||||||
```
|
```
|
||||||
|
|
||||||
Generate the default config file:
|
Generate the default config file:
|
||||||
@@ -101,18 +137,24 @@ Show the active configuration (after all overrides applied):
|
|||||||
|---|---|---|
|
|---|---|---|
|
||||||
| `NODE_LOOKUP_URL` | `puppetdb_url` | PuppetDB facts endpoint |
|
| `NODE_LOOKUP_URL` | `puppetdb_url` | PuppetDB facts endpoint |
|
||||||
| `NODE_LOOKUP_ROLE_FACT` | `role_fact` | Fact name used by `-R` flag |
|
| `NODE_LOOKUP_ROLE_FACT` | `role_fact` | Fact name used by `-R` flag |
|
||||||
|
| `NODE_LOOKUP_PUPPETBOARD_URL` | `puppetboard_url` | Puppetboard base URL (pburl / pblastreport) |
|
||||||
|
| `NODE_LOOKUP_DOMAIN` | `domain` | Domain appended to short (dotless) `-n` node names (default `main.unkin.net`) |
|
||||||
|
|
||||||
### CLI flag
|
### CLI flags
|
||||||
|
|
||||||
`--url <url>` overrides the PuppetDB URL for a single invocation (highest precedence).
|
`--url <url>` overrides the PuppetDB URL for a single invocation (highest precedence).
|
||||||
|
`--domain <domain>` overrides the auto-qualify domain for a single invocation.
|
||||||
|
|
||||||
## Code Patterns
|
## Code Patterns
|
||||||
|
|
||||||
- **`loadConfig()`**: reads config file → applies env vars → returns `config` struct. Called once at startup in `main()`.
|
- **`loadConfig()`**: reads config file → applies env vars → returns `config` struct. Called once at startup in `main()`.
|
||||||
- **`buildQuery()`**: returns a PuppetDB PQL-compatible JSON array string. Uses `roleFact` from config (not hardcoded). Match modifiers: `-p` (partial/regex, uses `~` op), `-i` (inverse, wraps with `not`), composable.
|
- **`buildQuery()`**: returns a PuppetDB PQL-compatible JSON array string. Uses `roleFact` from config (not hardcoded). Match modifiers: `-p` (partial/regex, uses `~` op), `-i` (inverse, wraps with `not`), composable.
|
||||||
|
- **Multiple facts**: `-F` accepts a comma-separated list (`ipaddress,enc_role`). `splitFactNames()`/`nameFilter()` turn several names into an `or` over `["=","name",<n>]` clauses; JSON output keys each value by the fact's real name so all requested facts appear per host.
|
||||||
|
- **Match value / `matchValue()`**: the value to match comes from `-m/--match` or, if that is empty, an optional positional argument. The positional fallback exists because pflag does not attach a space-separated value to a string flag grouped with a bool flag, so in `-pm k8s` the `k8s` arrives as a positional. `-m` still wins when both are given.
|
||||||
- **`queryPuppetDB(url, query)`**: takes the URL as a parameter — never reads globals.
|
- **`queryPuppetDB(url, query)`**: takes the URL as a parameter — never reads globals.
|
||||||
- **`processResults()`**: iterates facts, returns sorted `"certname value"` strings. JSON string values are unquoted; other JSON types rendered as compact JSON.
|
- **`processResults()`**: iterates facts, returns sorted `"certname value"` strings. JSON string values are unquoted; other JSON types rendered as compact JSON.
|
||||||
- **Output modes**: JSON (`-j`), count (`-C`), Ansible YAML (`-A`), node-only (`-1`), value-only (`-2`), default (node + value).
|
- **Output modes**: JSON (`-j`), count (`-C`), Ansible YAML (`-A`), node-only (`-1`), value-only (`-2`), default (node + value). `-j` and `-A` share `factsByHost()`, so both attach the queried fact(s) per host — as an object under the host (`-j`) or as inventory host vars (`-A`).
|
||||||
|
- **Short node names / `qualifyNode()`**: a `-n` value (and stdin-sourced node names) with no dot is auto-qualified to `<name>.<domain>` (domain defaults to `main.unkin.net`, overridable via `--domain`/`NODE_LOOKUP_DOMAIN`), so `-n ausyd1nxvm2120` resolves the same as its FQDN. A name that already contains a dot (any domain) is left unchanged; a single trailing dot is stripped; empty input is preserved.
|
||||||
- **Stdin support**: `stdinReader()` reads node names from stdin only when it is a real pipe/redirect carrying data (and no `-n` given). Terminals, `/dev/null`, and empty/closed pipes fall through to a normal query — so running without a TTY (e.g. invoked by an agent or CI) behaves like an interactive run instead of consuming empty input.
|
- **Stdin support**: `stdinReader()` reads node names from stdin only when it is a real pipe/redirect carrying data (and no `-n` given). Terminals, `/dev/null`, and empty/closed pipes fall through to a normal query — so running without a TTY (e.g. invoked by an agent or CI) behaves like an interactive run instead of consuming empty input.
|
||||||
- **SIGPIPE handling**: `signal.Ignore(syscall.SIGPIPE)` so pipes to `head` etc. work cleanly.
|
- **SIGPIPE handling**: `signal.Ignore(syscall.SIGPIPE)` so pipes to `head` etc. work cleanly.
|
||||||
|
|
||||||
@@ -136,5 +178,5 @@ mode (default, `-1`, `-2`, `-C`, `-j`, `-A`, `-a`). PuppetDB is stubbed with
|
|||||||
|
|
||||||
- `-1`, `-2`, `-C`, and `-A` all require `-R` or `-F`; the tool exits with an error otherwise.
|
- `-1`, `-2`, `-C`, and `-A` all require `-R` or `-F`; the tool exits with an error otherwise.
|
||||||
- `-C` (count) with stdin reads all lines as pre-fetched `"node value"` output for counting — it does **not** query PuppetDB per line.
|
- `-C` (count) with stdin reads all lines as pre-fetched `"node value"` output for counting — it does **not** query PuppetDB per line.
|
||||||
- JSON output (`-j`) builds `{ hostname: { factname: value } }` where the fact key is the `-F` value, the `role_fact` config value (if `-R`), or `"value"` as fallback.
|
- JSON output (`-j`) builds `{ hostname: { factname: value } }` keyed by each result's actual fact name (so `-F ipaddress,enc_role` yields both per host); it falls back to the `-F` value, the `role_fact` config value (if `-R`), or `"value"` only when a result carries no name.
|
||||||
- `config init` fails if the config file already exists (will not overwrite).
|
- `config init` fails if the config file already exists (will not overwrite).
|
||||||
|
|||||||
@@ -1,17 +1,29 @@
|
|||||||
BINARY := node-lookup
|
BINARY := node-lookup
|
||||||
|
# All shipped binaries and the package path each is built from. node-lookup is
|
||||||
|
# the module root; the companion tools live under cmd/.
|
||||||
|
BINARIES := node-lookup pburl pblastreport
|
||||||
DIST := dist
|
DIST := dist
|
||||||
VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)
|
VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)
|
||||||
GOFLAGS := -ldflags="-s -w -X main.version=$(VERSION)"
|
GOFLAGS := -ldflags="-s -w -X main.version=$(VERSION)"
|
||||||
OS ?= $(shell go env GOOS)
|
OS ?= $(shell go env GOOS)
|
||||||
ARCH ?= $(shell go env GOARCH)
|
ARCH ?= $(shell go env GOARCH)
|
||||||
|
|
||||||
|
# The Go package path for a binary: node-lookup is the module root, the
|
||||||
|
# companion tools live under cmd/. Usable inside a shell for-loop over $(BINARIES).
|
||||||
|
pkgpath = $$([ "$$b" = "node-lookup" ] && echo . || echo ./cmd/$$b)
|
||||||
|
|
||||||
.PHONY: all build test lint fmt clean install completions rpm rpm-package patch minor major _tag
|
.PHONY: all build test lint fmt clean install completions rpm rpm-package patch minor major _tag
|
||||||
|
|
||||||
all: build
|
all: build
|
||||||
|
|
||||||
# Build into dist/ so the nfpm packaging step (scripts/build-rpm.sh) can find it.
|
# Build every binary into dist/ so the nfpm packaging step
|
||||||
|
# (scripts/build-rpm.sh) can find them. Each main package needs its own -o, so
|
||||||
|
# they are built individually rather than with a single ./... invocation.
|
||||||
build:
|
build:
|
||||||
CGO_ENABLED=0 GOOS=$(OS) GOARCH=$(ARCH) go build $(GOFLAGS) -o $(DIST)/$(BINARY) ./...
|
@for b in $(BINARIES); do \
|
||||||
|
echo "building $$b"; \
|
||||||
|
CGO_ENABLED=0 GOOS=$(OS) GOARCH=$(ARCH) go build $(GOFLAGS) -o $(DIST)/$$b $(pkgpath) || exit 1; \
|
||||||
|
done
|
||||||
|
|
||||||
test:
|
test:
|
||||||
go test -v -race ./...
|
go test -v -race ./...
|
||||||
@@ -23,17 +35,19 @@ fmt:
|
|||||||
gofmt -w .
|
gofmt -w .
|
||||||
|
|
||||||
clean:
|
clean:
|
||||||
rm -rf $(DIST) $(BINARY)
|
rm -rf $(DIST) $(BINARIES)
|
||||||
|
|
||||||
install:
|
install:
|
||||||
go install $(GOFLAGS) ./...
|
go install $(GOFLAGS) ./...
|
||||||
|
|
||||||
# Generate bash/zsh/fish completions from the built binary into dist/completions.
|
# Generate bash/zsh/fish completions for every binary into dist/completions.
|
||||||
completions: build
|
completions: build
|
||||||
@mkdir -p $(DIST)/completions
|
@mkdir -p $(DIST)/completions
|
||||||
$(DIST)/$(BINARY) completion bash > $(DIST)/completions/$(BINARY).bash
|
@for b in $(BINARIES); do \
|
||||||
$(DIST)/$(BINARY) completion zsh > $(DIST)/completions/_$(BINARY)
|
$(DIST)/$$b completion bash > $(DIST)/completions/$$b.bash; \
|
||||||
$(DIST)/$(BINARY) completion fish > $(DIST)/completions/$(BINARY).fish
|
$(DIST)/$$b completion zsh > $(DIST)/completions/_$$b; \
|
||||||
|
$(DIST)/$$b completion fish > $(DIST)/completions/$$b.fish; \
|
||||||
|
done
|
||||||
|
|
||||||
# Build the binary then package it (with completions) into an RPM via nfpm.
|
# Build the binary then package it (with completions) into an RPM via nfpm.
|
||||||
rpm: build rpm-package
|
rpm: build rpm-package
|
||||||
|
|||||||
@@ -0,0 +1,97 @@
|
|||||||
|
// Command pblastreport shows each host's last Puppet report time alongside its
|
||||||
|
// Puppetboard node-page URL.
|
||||||
|
//
|
||||||
|
// It reads hostnames from its arguments or from piped node-lookup output,
|
||||||
|
// queries PuppetDB for each node's report_timestamp, and prints a
|
||||||
|
// tab-separated "<host> <last-report> <puppetboard-url>" line:
|
||||||
|
//
|
||||||
|
// node-lookup -R | pblastreport
|
||||||
|
// pblastreport --relative host1.example.net
|
||||||
|
// pblastreport --timezone Asia/Singapore host1.example.net
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"node-lookup/internal/puppet"
|
||||||
|
|
||||||
|
"github.com/spf13/cobra"
|
||||||
|
)
|
||||||
|
|
||||||
|
var version = "dev"
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
cfg, err := puppet.Load()
|
||||||
|
if err != nil {
|
||||||
|
fmt.Fprintln(os.Stderr, "config error:", err)
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
|
||||||
|
var (
|
||||||
|
relative bool
|
||||||
|
tz string
|
||||||
|
boardURL string
|
||||||
|
pdbURL string
|
||||||
|
)
|
||||||
|
|
||||||
|
root := &cobra.Command{
|
||||||
|
Use: "pblastreport [host...]",
|
||||||
|
Short: "Show each host's last Puppet report time and Puppetboard URL.",
|
||||||
|
Long: "Reads hostnames from arguments or piped node-lookup output and prints, per\n" +
|
||||||
|
"host, the time of its last Puppet report and its Puppetboard node-page URL.\n" +
|
||||||
|
"Times are shown in the local timezone unless --timezone is given, or as a\n" +
|
||||||
|
"relative age with --relative. Example: node-lookup -R | pblastreport -r",
|
||||||
|
Args: cobra.ArbitraryArgs,
|
||||||
|
SilenceUsage: true,
|
||||||
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
|
if cmd.Flags().Changed("puppetboard-url") {
|
||||||
|
cfg.PuppetboardURL = boardURL
|
||||||
|
}
|
||||||
|
if cmd.Flags().Changed("url") {
|
||||||
|
cfg.PuppetDBURL = pdbURL
|
||||||
|
}
|
||||||
|
|
||||||
|
loc := time.Local
|
||||||
|
if tz != "" {
|
||||||
|
l, err := time.LoadLocation(tz)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("invalid timezone %q: %w", tz, err)
|
||||||
|
}
|
||||||
|
loc = l
|
||||||
|
}
|
||||||
|
|
||||||
|
hosts := puppet.ReadHosts(os.Stdin, args)
|
||||||
|
if len(hosts) == 0 {
|
||||||
|
return fmt.Errorf("no hosts given (pass as arguments or pipe node-lookup output)")
|
||||||
|
}
|
||||||
|
|
||||||
|
nodesURL := puppet.NodesEndpoint(cfg.PuppetDBURL)
|
||||||
|
now := time.Now()
|
||||||
|
for _, h := range hosts {
|
||||||
|
node, lookupErr := puppet.LookupNode(nodesURL, h)
|
||||||
|
when := formatWhen(node, lookupErr, relative, loc, now)
|
||||||
|
fmt.Printf("%s\t%s\t%s\n", h, when, puppet.HostPageURL(cfg.PuppetboardURL, h))
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
f := root.Flags()
|
||||||
|
f.BoolVarP(&relative, "relative", "r", false, "Show the report time as a relative age (e.g. '3h ago')")
|
||||||
|
f.StringVarP(&tz, "timezone", "z", "", "IANA timezone for the report time (e.g. Asia/Singapore); default local")
|
||||||
|
f.StringVar(&boardURL, "puppetboard-url", cfg.PuppetboardURL, "Puppetboard base URL (overrides config and NODE_LOOKUP_PUPPETBOARD_URL)")
|
||||||
|
f.StringVar(&pdbURL, "url", cfg.PuppetDBURL, "PuppetDB facts URL (overrides config and NODE_LOOKUP_URL)")
|
||||||
|
|
||||||
|
root.AddCommand(&cobra.Command{
|
||||||
|
Use: "version",
|
||||||
|
Short: "Print the version",
|
||||||
|
Run: func(cmd *cobra.Command, args []string) { fmt.Println(version) },
|
||||||
|
SilenceUsage: true,
|
||||||
|
})
|
||||||
|
|
||||||
|
if err := root.Execute(); err != nil {
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,53 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"node-lookup/internal/puppet"
|
||||||
|
)
|
||||||
|
|
||||||
|
// formatWhen renders the "last report" column for a node lookup result. It
|
||||||
|
// handles the lookup error, the unknown-node, and the never-reported cases so
|
||||||
|
// the output always has a value in every column.
|
||||||
|
func formatWhen(node *puppet.Node, lookupErr error, relative bool, loc *time.Location, now time.Time) string {
|
||||||
|
if lookupErr != nil {
|
||||||
|
return "error: " + lookupErr.Error()
|
||||||
|
}
|
||||||
|
if node == nil {
|
||||||
|
return "unknown node"
|
||||||
|
}
|
||||||
|
if node.ReportTimestamp == "" {
|
||||||
|
return "no report"
|
||||||
|
}
|
||||||
|
ts, err := time.Parse(time.RFC3339Nano, node.ReportTimestamp)
|
||||||
|
if err != nil {
|
||||||
|
return node.ReportTimestamp // fall back to the raw value
|
||||||
|
}
|
||||||
|
if relative {
|
||||||
|
return humanizeSince(now, ts)
|
||||||
|
}
|
||||||
|
return ts.In(loc).Format("2006-01-02 15:04:05 MST")
|
||||||
|
}
|
||||||
|
|
||||||
|
// humanizeSince renders the gap between now and ts as a coarse relative string
|
||||||
|
// ("42s ago", "9m ago", "3h ago", "5d ago"). Future timestamps (clock skew)
|
||||||
|
// render as "in <d>".
|
||||||
|
func humanizeSince(now, ts time.Time) string {
|
||||||
|
d := now.Sub(ts)
|
||||||
|
suffix := "ago"
|
||||||
|
if d < 0 {
|
||||||
|
d = -d
|
||||||
|
suffix = "from now"
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case d < time.Minute:
|
||||||
|
return fmt.Sprintf("%ds %s", int(d.Seconds()), suffix)
|
||||||
|
case d < time.Hour:
|
||||||
|
return fmt.Sprintf("%dm %s", int(d.Minutes()), suffix)
|
||||||
|
case d < 24*time.Hour:
|
||||||
|
return fmt.Sprintf("%dh %s", int(d.Hours()), suffix)
|
||||||
|
default:
|
||||||
|
return fmt.Sprintf("%dd %s", int(d.Hours()/24), suffix)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,84 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"errors"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"node-lookup/internal/puppet"
|
||||||
|
)
|
||||||
|
|
||||||
|
func mustTime(t *testing.T, s string) time.Time {
|
||||||
|
t.Helper()
|
||||||
|
ts, err := time.Parse(time.RFC3339Nano, s)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
return ts
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFormatWhen_Absolute(t *testing.T) {
|
||||||
|
node := &puppet.Node{ReportTimestamp: "2026-07-15T04:05:06.000Z"}
|
||||||
|
now := mustTime(t, "2026-07-15T10:00:00Z")
|
||||||
|
got := formatWhen(node, nil, false, time.UTC, now)
|
||||||
|
if got != "2026-07-15 04:05:06 UTC" {
|
||||||
|
t.Fatalf("unexpected absolute time: %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFormatWhen_TimezoneApplied(t *testing.T) {
|
||||||
|
loc, err := time.LoadLocation("Asia/Singapore") // UTC+8, no DST
|
||||||
|
if err != nil {
|
||||||
|
t.Skipf("tzdata unavailable: %v", err)
|
||||||
|
}
|
||||||
|
node := &puppet.Node{ReportTimestamp: "2026-07-15T04:05:06Z"}
|
||||||
|
now := mustTime(t, "2026-07-15T10:00:00Z")
|
||||||
|
got := formatWhen(node, nil, false, loc, now)
|
||||||
|
if !strings.HasPrefix(got, "2026-07-15 12:05:06") {
|
||||||
|
t.Fatalf("expected +08 time, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFormatWhen_Relative(t *testing.T) {
|
||||||
|
node := &puppet.Node{ReportTimestamp: "2026-07-15T07:00:00Z"}
|
||||||
|
now := mustTime(t, "2026-07-15T10:00:00Z")
|
||||||
|
if got := formatWhen(node, nil, true, time.UTC, now); got != "3h ago" {
|
||||||
|
t.Fatalf("expected '3h ago', got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFormatWhen_EdgeCases(t *testing.T) {
|
||||||
|
now := mustTime(t, "2026-07-15T10:00:00Z")
|
||||||
|
if got := formatWhen(nil, errors.New("down"), false, time.UTC, now); !strings.HasPrefix(got, "error:") {
|
||||||
|
t.Fatalf("expected error passthrough, got %q", got)
|
||||||
|
}
|
||||||
|
if got := formatWhen(nil, nil, false, time.UTC, now); got != "unknown node" {
|
||||||
|
t.Fatalf("expected unknown node, got %q", got)
|
||||||
|
}
|
||||||
|
if got := formatWhen(&puppet.Node{ReportTimestamp: ""}, nil, false, time.UTC, now); got != "no report" {
|
||||||
|
t.Fatalf("expected no report, got %q", got)
|
||||||
|
}
|
||||||
|
if got := formatWhen(&puppet.Node{ReportTimestamp: "garbage"}, nil, false, time.UTC, now); got != "garbage" {
|
||||||
|
t.Fatalf("expected raw fallback, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestHumanizeSince(t *testing.T) {
|
||||||
|
base := mustTime(t, "2026-07-15T10:00:00Z")
|
||||||
|
cases := []struct {
|
||||||
|
ts string
|
||||||
|
want string
|
||||||
|
}{
|
||||||
|
{"2026-07-15T09:59:30Z", "30s ago"},
|
||||||
|
{"2026-07-15T09:45:00Z", "15m ago"},
|
||||||
|
{"2026-07-15T05:00:00Z", "5h ago"},
|
||||||
|
{"2026-07-13T10:00:00Z", "2d ago"},
|
||||||
|
{"2026-07-15T10:01:00Z", "1m from now"},
|
||||||
|
}
|
||||||
|
for _, c := range cases {
|
||||||
|
if got := humanizeSince(base, mustTime(t, c.ts)); got != c.want {
|
||||||
|
t.Errorf("humanizeSince(%s) = %q, want %q", c.ts, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,63 @@
|
|||||||
|
// Command pburl prints the Puppetboard node-page URL for each host it is given.
|
||||||
|
//
|
||||||
|
// It reads hostnames from its arguments or from piped node-lookup output and
|
||||||
|
// emits "<host> <puppetboard-url>" per line:
|
||||||
|
//
|
||||||
|
// node-lookup -R | pburl
|
||||||
|
// pburl host1.example.net host2.example.net
|
||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
|
||||||
|
"node-lookup/internal/puppet"
|
||||||
|
|
||||||
|
"github.com/spf13/cobra"
|
||||||
|
)
|
||||||
|
|
||||||
|
var version = "dev"
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
cfg, err := puppet.Load()
|
||||||
|
if err != nil {
|
||||||
|
fmt.Fprintln(os.Stderr, "config error:", err)
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
|
||||||
|
var boardURL string
|
||||||
|
|
||||||
|
root := &cobra.Command{
|
||||||
|
Use: "pburl [host...]",
|
||||||
|
Short: "Print the Puppetboard node-page URL for each host.",
|
||||||
|
Long: "Reads hostnames from arguments or piped node-lookup output and prints\n" +
|
||||||
|
"'<host> <puppetboard-url>' for each. Example: node-lookup -R | pburl",
|
||||||
|
Args: cobra.ArbitraryArgs,
|
||||||
|
SilenceUsage: true,
|
||||||
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
|
if cmd.Flags().Changed("puppetboard-url") {
|
||||||
|
cfg.PuppetboardURL = boardURL
|
||||||
|
}
|
||||||
|
hosts := puppet.ReadHosts(os.Stdin, args)
|
||||||
|
if len(hosts) == 0 {
|
||||||
|
return fmt.Errorf("no hosts given (pass as arguments or pipe node-lookup output)")
|
||||||
|
}
|
||||||
|
for _, h := range hosts {
|
||||||
|
fmt.Printf("%s %s\n", h, puppet.HostPageURL(cfg.PuppetboardURL, h))
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
},
|
||||||
|
}
|
||||||
|
root.Flags().StringVar(&boardURL, "puppetboard-url", cfg.PuppetboardURL, "Puppetboard base URL (overrides config and NODE_LOOKUP_PUPPETBOARD_URL)")
|
||||||
|
|
||||||
|
root.AddCommand(&cobra.Command{
|
||||||
|
Use: "version",
|
||||||
|
Short: "Print the version",
|
||||||
|
Run: func(cmd *cobra.Command, args []string) { fmt.Println(version) },
|
||||||
|
SilenceUsage: true,
|
||||||
|
})
|
||||||
|
|
||||||
|
if err := root.Execute(); err != nil {
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -3,8 +3,11 @@ module node-lookup
|
|||||||
go 1.25.7
|
go 1.25.7
|
||||||
|
|
||||||
require (
|
require (
|
||||||
github.com/inconshreveable/mousetrap v1.1.0 // indirect
|
github.com/spf13/cobra v1.10.2
|
||||||
github.com/spf13/cobra v1.10.2 // indirect
|
gopkg.in/yaml.v3 v3.0.1
|
||||||
github.com/spf13/pflag v1.0.9 // indirect
|
)
|
||||||
gopkg.in/yaml.v3 v3.0.1 // indirect
|
|
||||||
|
require (
|
||||||
|
github.com/inconshreveable/mousetrap v1.1.0 // indirect
|
||||||
|
github.com/spf13/pflag v1.0.9 // indirect
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ github.com/spf13/cobra v1.10.2/go.mod h1:7C1pvHqHw5A4vrJfjNwvOdzYu0Gml16OCs2GRiT
|
|||||||
github.com/spf13/pflag v1.0.9 h1:9exaQaMOCwffKiiiYk6/BndUBv+iRViNW+4lEMi0PvY=
|
github.com/spf13/pflag v1.0.9 h1:9exaQaMOCwffKiiiYk6/BndUBv+iRViNW+4lEMi0PvY=
|
||||||
github.com/spf13/pflag v1.0.9/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
|
github.com/spf13/pflag v1.0.9/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
|
||||||
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
|
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
|
||||||
|
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
|
||||||
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
|
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
|
||||||
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
|
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
|
||||||
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
||||||
|
|||||||
@@ -0,0 +1,9 @@
|
|||||||
|
package puppet
|
||||||
|
|
||||||
|
import "strings"
|
||||||
|
|
||||||
|
// HostPageURL returns the Puppetboard node-detail page URL for a certname,
|
||||||
|
// e.g. https://puppetboard.example.net/node/host1.example.net.
|
||||||
|
func HostPageURL(base, certname string) string {
|
||||||
|
return strings.TrimRight(base, "/") + "/node/" + certname
|
||||||
|
}
|
||||||
@@ -0,0 +1,90 @@
|
|||||||
|
// Package puppet holds the small pieces of PuppetDB/Puppetboard plumbing shared
|
||||||
|
// by the node-lookup companion tools (pburl, pblastreport): config loading,
|
||||||
|
// PuppetDB "nodes" queries, Puppetboard URL construction, and reading hostnames
|
||||||
|
// from piped node-lookup output.
|
||||||
|
//
|
||||||
|
// It intentionally reads the SAME config file, env vars, and defaults as the
|
||||||
|
// node-lookup CLI so a single `~/.config/node-lookup/config.yaml` configures
|
||||||
|
// every tool in the family.
|
||||||
|
package puppet
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
|
||||||
|
"gopkg.in/yaml.v3"
|
||||||
|
)
|
||||||
|
|
||||||
|
const (
|
||||||
|
// DefaultPuppetDBURL is the PuppetDB v4 facts endpoint (shared with node-lookup).
|
||||||
|
DefaultPuppetDBURL = "http://puppetdbapi.service.consul:8080/pdb/query/v4/facts"
|
||||||
|
// DefaultRoleFact is the role fact node-lookup queries with -R.
|
||||||
|
DefaultRoleFact = "enc_role"
|
||||||
|
// DefaultPuppetboardURL is the base URL of the Puppetboard web UI.
|
||||||
|
DefaultPuppetboardURL = "https://puppetboard.k8s.syd1.au.unkin.net"
|
||||||
|
|
||||||
|
appName = "node-lookup"
|
||||||
|
configFileName = "config.yaml"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Config mirrors node-lookup's config plus the puppetboard_url key used by the
|
||||||
|
// companion tools. Fields map 1:1 to config file keys and env vars.
|
||||||
|
type Config struct {
|
||||||
|
PuppetDBURL string `yaml:"puppetdb_url"`
|
||||||
|
RoleFact string `yaml:"role_fact"`
|
||||||
|
PuppetboardURL string `yaml:"puppetboard_url"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// DefaultConfig returns the built-in defaults.
|
||||||
|
func DefaultConfig() Config {
|
||||||
|
return Config{
|
||||||
|
PuppetDBURL: DefaultPuppetDBURL,
|
||||||
|
RoleFact: DefaultRoleFact,
|
||||||
|
PuppetboardURL: DefaultPuppetboardURL,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ConfigDir returns the XDG_CONFIG_HOME/node-lookup directory.
|
||||||
|
func ConfigDir() string {
|
||||||
|
base := os.Getenv("XDG_CONFIG_HOME")
|
||||||
|
if base == "" {
|
||||||
|
home, _ := os.UserHomeDir()
|
||||||
|
base = filepath.Join(home, ".config")
|
||||||
|
}
|
||||||
|
return filepath.Join(base, appName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ConfigPath returns the full path to the shared config file.
|
||||||
|
func ConfigPath() string {
|
||||||
|
return filepath.Join(ConfigDir(), configFileName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Load reads the config file (if present), then applies env var overrides.
|
||||||
|
// Precedence (lowest → highest): defaults < config file < env vars.
|
||||||
|
func Load() (Config, error) {
|
||||||
|
cfg := DefaultConfig()
|
||||||
|
|
||||||
|
path := ConfigPath()
|
||||||
|
data, err := os.ReadFile(path)
|
||||||
|
if err != nil && !os.IsNotExist(err) {
|
||||||
|
return cfg, fmt.Errorf("reading config %s: %w", path, err)
|
||||||
|
}
|
||||||
|
if err == nil {
|
||||||
|
if err := yaml.Unmarshal(data, &cfg); err != nil {
|
||||||
|
return cfg, fmt.Errorf("parsing config %s: %w", path, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if v := os.Getenv("NODE_LOOKUP_URL"); v != "" {
|
||||||
|
cfg.PuppetDBURL = v
|
||||||
|
}
|
||||||
|
if v := os.Getenv("NODE_LOOKUP_ROLE_FACT"); v != "" {
|
||||||
|
cfg.RoleFact = v
|
||||||
|
}
|
||||||
|
if v := os.Getenv("NODE_LOOKUP_PUPPETBOARD_URL"); v != "" {
|
||||||
|
cfg.PuppetboardURL = v
|
||||||
|
}
|
||||||
|
|
||||||
|
return cfg, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,177 @@
|
|||||||
|
package puppet
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// ---- config -----------------------------------------------------------------
|
||||||
|
|
||||||
|
func TestLoad_Defaults(t *testing.T) {
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
||||||
|
t.Setenv("NODE_LOOKUP_URL", "")
|
||||||
|
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
||||||
|
t.Setenv("NODE_LOOKUP_PUPPETBOARD_URL", "")
|
||||||
|
|
||||||
|
cfg, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if cfg.PuppetDBURL != DefaultPuppetDBURL {
|
||||||
|
t.Fatalf("expected default puppetdb url, got %s", cfg.PuppetDBURL)
|
||||||
|
}
|
||||||
|
if cfg.PuppetboardURL != DefaultPuppetboardURL {
|
||||||
|
t.Fatalf("expected default puppetboard url, got %s", cfg.PuppetboardURL)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoad_FileAndEnvOverride(t *testing.T) {
|
||||||
|
dir := t.TempDir()
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", dir)
|
||||||
|
t.Setenv("NODE_LOOKUP_URL", "")
|
||||||
|
t.Setenv("NODE_LOOKUP_ROLE_FACT", "")
|
||||||
|
t.Setenv("NODE_LOOKUP_PUPPETBOARD_URL", "https://env.example.net")
|
||||||
|
|
||||||
|
cfgDir := filepath.Join(dir, appName)
|
||||||
|
if err := os.MkdirAll(cfgDir, 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
body := "puppetdb_url: http://file:8080/pdb/query/v4/facts\npuppetboard_url: https://file.example.net\n"
|
||||||
|
if err := os.WriteFile(filepath.Join(cfgDir, configFileName), []byte(body), 0o644); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
cfg, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if cfg.PuppetDBURL != "http://file:8080/pdb/query/v4/facts" {
|
||||||
|
t.Fatalf("file override failed: %s", cfg.PuppetDBURL)
|
||||||
|
}
|
||||||
|
// env beats the file for puppetboard_url
|
||||||
|
if cfg.PuppetboardURL != "https://env.example.net" {
|
||||||
|
t.Fatalf("env should beat file: %s", cfg.PuppetboardURL)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---- NodesEndpoint ----------------------------------------------------------
|
||||||
|
|
||||||
|
func TestNodesEndpoint(t *testing.T) {
|
||||||
|
cases := map[string]string{
|
||||||
|
"http://puppetdbapi.service.consul:8080/pdb/query/v4/facts": "http://puppetdbapi.service.consul:8080/pdb/query/v4/nodes",
|
||||||
|
"http://h:8080/pdb/query/v4/facts/": "http://h:8080/pdb/query/v4/nodes",
|
||||||
|
"https://h/facts": "https://h/nodes",
|
||||||
|
}
|
||||||
|
for in, want := range cases {
|
||||||
|
if got := NodesEndpoint(in); got != want {
|
||||||
|
t.Errorf("NodesEndpoint(%q) = %q, want %q", in, got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---- HostPageURL ------------------------------------------------------------
|
||||||
|
|
||||||
|
func TestHostPageURL(t *testing.T) {
|
||||||
|
if got := HostPageURL("https://pb.example.net", "h1.example.net"); got != "https://pb.example.net/node/h1.example.net" {
|
||||||
|
t.Fatalf("unexpected url: %s", got)
|
||||||
|
}
|
||||||
|
// trailing slash on the base is trimmed
|
||||||
|
if got := HostPageURL("https://pb.example.net/", "h1"); got != "https://pb.example.net/node/h1" {
|
||||||
|
t.Fatalf("trailing slash not handled: %s", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---- LookupNode -------------------------------------------------------------
|
||||||
|
|
||||||
|
func TestLookupNode_Found(t *testing.T) {
|
||||||
|
var gotQuery string
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
gotQuery = r.URL.Query().Get("query")
|
||||||
|
_ = json.NewEncoder(w).Encode([]Node{{
|
||||||
|
Certname: "h1",
|
||||||
|
ReportTimestamp: "2026-07-15T04:05:06.000Z",
|
||||||
|
LatestReportStatus: "changed",
|
||||||
|
}})
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
node, err := LookupNode(srv.URL, "h1")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if node == nil || node.ReportTimestamp != "2026-07-15T04:05:06.000Z" {
|
||||||
|
t.Fatalf("unexpected node: %+v", node)
|
||||||
|
}
|
||||||
|
if !strings.Contains(gotQuery, "certname") || !strings.Contains(gotQuery, "h1") {
|
||||||
|
t.Fatalf("query missing certname filter: %s", gotQuery)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLookupNode_Unknown(t *testing.T) {
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
_ = json.NewEncoder(w).Encode([]Node{})
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
node, err := LookupNode(srv.URL, "nope")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if node != nil {
|
||||||
|
t.Fatalf("expected nil node for unknown certname, got %+v", node)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLookupNode_HTTPError(t *testing.T) {
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
http.Error(w, "boom", http.StatusInternalServerError)
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
if _, err := LookupNode(srv.URL, "h1"); err == nil {
|
||||||
|
t.Fatal("expected error for HTTP 500")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---- ReadHosts --------------------------------------------------------------
|
||||||
|
|
||||||
|
func TestReadHosts_ArgsWin(t *testing.T) {
|
||||||
|
// A real pipe with data present, but explicit args should take precedence.
|
||||||
|
r, w, _ := os.Pipe()
|
||||||
|
go func() { _, _ = w.WriteString("piped\n"); _ = w.Close() }()
|
||||||
|
defer func() { _ = r.Close() }()
|
||||||
|
|
||||||
|
got := ReadHosts(r, []string{"a", "b", "a"})
|
||||||
|
if strings.Join(got, ",") != "a,b" {
|
||||||
|
t.Fatalf("expected deduped args, got %v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestReadHosts_StdinFirstField(t *testing.T) {
|
||||||
|
r, w, _ := os.Pipe()
|
||||||
|
go func() {
|
||||||
|
// node-lookup default output: "host value"; also a bare host and a dup.
|
||||||
|
_, _ = w.WriteString("host1 roles::web\nhost2 roles::db\nhost1 roles::web\nhost3\n")
|
||||||
|
_ = w.Close()
|
||||||
|
}()
|
||||||
|
defer func() { _ = r.Close() }()
|
||||||
|
|
||||||
|
got := ReadHosts(r, nil)
|
||||||
|
if strings.Join(got, ",") != "host1,host2,host3" {
|
||||||
|
t.Fatalf("expected first-field hosts deduped, got %v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestReadHosts_NoInput(t *testing.T) {
|
||||||
|
// /dev/null is a char device: no args, no pipe data -> nil.
|
||||||
|
f, _ := os.Open(os.DevNull)
|
||||||
|
defer func() { _ = f.Close() }()
|
||||||
|
if got := ReadHosts(f, nil); got != nil {
|
||||||
|
t.Fatalf("expected nil for no input, got %v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,71 @@
|
|||||||
|
package puppet
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"net/http"
|
||||||
|
"net/url"
|
||||||
|
"strings"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Node is the subset of a PuppetDB v4 "nodes" record the companion tools use.
|
||||||
|
type Node struct {
|
||||||
|
Certname string `json:"certname"`
|
||||||
|
ReportTimestamp string `json:"report_timestamp"`
|
||||||
|
LatestReportStatus string `json:"latest_report_status"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// NodesEndpoint derives the PuppetDB v4 "nodes" query endpoint from the
|
||||||
|
// configured facts endpoint by swapping the final path segment
|
||||||
|
// (…/pdb/query/v4/facts → …/pdb/query/v4/nodes). It leaves scheme/host/query
|
||||||
|
// untouched, so a custom NODE_LOOKUP_URL still resolves correctly.
|
||||||
|
func NodesEndpoint(factsURL string) string {
|
||||||
|
u, err := url.Parse(factsURL)
|
||||||
|
if err != nil {
|
||||||
|
return factsURL
|
||||||
|
}
|
||||||
|
p := strings.TrimRight(u.Path, "/")
|
||||||
|
if i := strings.LastIndex(p, "/"); i >= 0 {
|
||||||
|
p = p[:i] + "/nodes"
|
||||||
|
} else {
|
||||||
|
p = "/nodes"
|
||||||
|
}
|
||||||
|
u.Path = p
|
||||||
|
return u.String()
|
||||||
|
}
|
||||||
|
|
||||||
|
// LookupNode fetches the single PuppetDB node record for certname. It returns
|
||||||
|
// (nil, nil) when PuppetDB knows of no such node.
|
||||||
|
func LookupNode(nodesURL, certname string) (*Node, error) {
|
||||||
|
q, _ := json.Marshal([]interface{}{"=", "certname", certname})
|
||||||
|
nodes, err := queryNodes(nodesURL, string(q))
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if len(nodes) == 0 {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
return &nodes[0], nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func queryNodes(nodesURL, query string) ([]Node, error) {
|
||||||
|
params := url.Values{}
|
||||||
|
params.Set("query", query)
|
||||||
|
resp, err := http.Get(nodesURL + "?" + params.Encode())
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("request failed: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = resp.Body.Close() }()
|
||||||
|
|
||||||
|
if resp.StatusCode != http.StatusOK {
|
||||||
|
body, _ := io.ReadAll(resp.Body)
|
||||||
|
return nil, fmt.Errorf("HTTP %d: %s", resp.StatusCode, string(body))
|
||||||
|
}
|
||||||
|
|
||||||
|
var nodes []Node
|
||||||
|
if err := json.NewDecoder(resp.Body).Decode(&nodes); err != nil {
|
||||||
|
return nil, fmt.Errorf("decode error: %w", err)
|
||||||
|
}
|
||||||
|
return nodes, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,66 @@
|
|||||||
|
package puppet
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bufio"
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
)
|
||||||
|
|
||||||
|
// StdinReader returns a buffered reader over f and true only when f actually
|
||||||
|
// carries piped/redirected data. Terminals and character devices such as
|
||||||
|
// /dev/null return false, and an empty pipe or empty file (immediate EOF on
|
||||||
|
// peek) also returns false. This mirrors node-lookup's no-TTY behaviour: when
|
||||||
|
// invoked without a real pipe the caller can fall back to arguments instead of
|
||||||
|
// blocking on or silently consuming empty input.
|
||||||
|
func StdinReader(f *os.File) (*bufio.Reader, bool) {
|
||||||
|
fi, err := f.Stat()
|
||||||
|
if err != nil {
|
||||||
|
return nil, false
|
||||||
|
}
|
||||||
|
if (fi.Mode() & os.ModeCharDevice) != 0 {
|
||||||
|
return nil, false // terminal or /dev/null
|
||||||
|
}
|
||||||
|
r := bufio.NewReader(f)
|
||||||
|
if _, err := r.Peek(1); err != nil {
|
||||||
|
return nil, false // empty pipe / empty file (EOF)
|
||||||
|
}
|
||||||
|
return r, true
|
||||||
|
}
|
||||||
|
|
||||||
|
// ReadHosts resolves the list of hostnames to act on. Explicit args win; failing
|
||||||
|
// that it reads the first whitespace-separated field of each non-empty line from
|
||||||
|
// stdin (so `node-lookup -R | pburl` and `node-lookup -1 | pburl` both work).
|
||||||
|
// Order is preserved and duplicates are removed. Returns nil when neither args
|
||||||
|
// nor piped stdin data are present.
|
||||||
|
func ReadHosts(stdin *os.File, args []string) []string {
|
||||||
|
if len(args) > 0 {
|
||||||
|
return dedupe(args)
|
||||||
|
}
|
||||||
|
r, ok := StdinReader(stdin)
|
||||||
|
if !ok {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
var hosts []string
|
||||||
|
sc := bufio.NewScanner(r)
|
||||||
|
for sc.Scan() {
|
||||||
|
fields := strings.Fields(sc.Text())
|
||||||
|
if len(fields) == 0 {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
hosts = append(hosts, fields[0])
|
||||||
|
}
|
||||||
|
return dedupe(hosts)
|
||||||
|
}
|
||||||
|
|
||||||
|
func dedupe(in []string) []string {
|
||||||
|
seen := make(map[string]struct{}, len(in))
|
||||||
|
out := make([]string, 0, len(in))
|
||||||
|
for _, s := range in {
|
||||||
|
if _, ok := seen[s]; ok {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
seen[s] = struct{}{}
|
||||||
|
out = append(out, s)
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
@@ -19,10 +19,12 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
const (
|
const (
|
||||||
defaultPuppetDBURL = "http://puppetdbapi.service.consul:8080/pdb/query/v4/facts"
|
defaultPuppetDBURL = "http://puppetdbapi.service.consul:8080/pdb/query/v4/facts"
|
||||||
defaultRoleFact = "enc_role"
|
defaultRoleFact = "enc_role"
|
||||||
configFileName = "config.yaml"
|
defaultPuppetboardURL = "https://puppetboard.k8s.syd1.au.unkin.net"
|
||||||
appName = "node-lookup"
|
defaultDomain = "main.unkin.net"
|
||||||
|
configFileName = "config.yaml"
|
||||||
|
appName = "node-lookup"
|
||||||
)
|
)
|
||||||
|
|
||||||
var version = "dev"
|
var version = "dev"
|
||||||
@@ -32,12 +34,20 @@ var version = "dev"
|
|||||||
type config struct {
|
type config struct {
|
||||||
PuppetDBURL string `yaml:"puppetdb_url"`
|
PuppetDBURL string `yaml:"puppetdb_url"`
|
||||||
RoleFact string `yaml:"role_fact"`
|
RoleFact string `yaml:"role_fact"`
|
||||||
|
// PuppetboardURL is not used by node-lookup itself; it is scaffolded here so
|
||||||
|
// the shared config file also configures the companion tools (pburl,
|
||||||
|
// pblastreport) that read this same file.
|
||||||
|
PuppetboardURL string `yaml:"puppetboard_url"`
|
||||||
|
// Domain is appended to a short (dotless) -n node name to form its FQDN.
|
||||||
|
Domain string `yaml:"domain"`
|
||||||
}
|
}
|
||||||
|
|
||||||
func defaultConfig() config {
|
func defaultConfig() config {
|
||||||
return config{
|
return config{
|
||||||
PuppetDBURL: defaultPuppetDBURL,
|
PuppetDBURL: defaultPuppetDBURL,
|
||||||
RoleFact: defaultRoleFact,
|
RoleFact: defaultRoleFact,
|
||||||
|
PuppetboardURL: defaultPuppetboardURL,
|
||||||
|
Domain: defaultDomain,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -78,6 +88,12 @@ func loadConfig() (config, error) {
|
|||||||
if v := os.Getenv("NODE_LOOKUP_ROLE_FACT"); v != "" {
|
if v := os.Getenv("NODE_LOOKUP_ROLE_FACT"); v != "" {
|
||||||
cfg.RoleFact = v
|
cfg.RoleFact = v
|
||||||
}
|
}
|
||||||
|
if v := os.Getenv("NODE_LOOKUP_PUPPETBOARD_URL"); v != "" {
|
||||||
|
cfg.PuppetboardURL = v
|
||||||
|
}
|
||||||
|
if v := os.Getenv("NODE_LOOKUP_DOMAIN"); v != "" {
|
||||||
|
cfg.Domain = v
|
||||||
|
}
|
||||||
|
|
||||||
return cfg, nil
|
return cfg, nil
|
||||||
}
|
}
|
||||||
@@ -96,7 +112,7 @@ func writeDefaultConfig() error {
|
|||||||
|
|
||||||
cfg := defaultConfig()
|
cfg := defaultConfig()
|
||||||
data, _ := yaml.Marshal(cfg)
|
data, _ := yaml.Marshal(cfg)
|
||||||
header := []byte("# node-lookup configuration\n# Fields can be overridden with env vars: NODE_LOOKUP_URL, NODE_LOOKUP_ROLE_FACT\n\n")
|
header := []byte("# node-lookup configuration\n# Fields can be overridden with env vars: NODE_LOOKUP_URL, NODE_LOOKUP_ROLE_FACT, NODE_LOOKUP_PUPPETBOARD_URL, NODE_LOOKUP_DOMAIN\n# puppetboard_url is used by the companion tools (pburl, pblastreport).\n# domain is appended to short (dotless) -n node names to form their FQDN.\n\n")
|
||||||
if err := os.WriteFile(path, append(header, data...), 0o644); err != nil {
|
if err := os.WriteFile(path, append(header, data...), 0o644); err != nil {
|
||||||
return fmt.Errorf("writing config: %w", err)
|
return fmt.Errorf("writing config: %w", err)
|
||||||
}
|
}
|
||||||
@@ -110,6 +126,46 @@ type fact struct {
|
|||||||
Value json.RawMessage `json:"value"`
|
Value json.RawMessage `json:"value"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// splitFactNames splits a comma-separated -F value into trimmed, non-empty
|
||||||
|
// names, so `-F ipaddress,enc_role` queries both facts.
|
||||||
|
func splitFactNames(factName string) []string {
|
||||||
|
var names []string
|
||||||
|
for _, n := range strings.Split(factName, ",") {
|
||||||
|
if n = strings.TrimSpace(n); n != "" {
|
||||||
|
names = append(names, n)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return names
|
||||||
|
}
|
||||||
|
|
||||||
|
// nameFilter returns a PQL filter matching any of the given fact names: a plain
|
||||||
|
// equality for one name, an "or" over per-name equalities for several.
|
||||||
|
func nameFilter(names []string) []interface{} {
|
||||||
|
if len(names) == 1 {
|
||||||
|
return []interface{}{"=", "name", names[0]}
|
||||||
|
}
|
||||||
|
or := []interface{}{"or"}
|
||||||
|
for _, n := range names {
|
||||||
|
or = append(or, []interface{}{"=", "name", n})
|
||||||
|
}
|
||||||
|
return or
|
||||||
|
}
|
||||||
|
|
||||||
|
// qualifyNode auto-qualifies a short (dotless) node name by appending
|
||||||
|
// ".<domain>", so `-n ausyd1nxvm2120` resolves the same as its FQDN. A name
|
||||||
|
// that already contains a dot is treated as already-qualified (including names
|
||||||
|
// in other domains like *.k8s.syd1.au.unkin.net) and returned unchanged. A
|
||||||
|
// single trailing dot is stripped first, so a dotless name with a trailing dot
|
||||||
|
// is still qualified. Empty input is returned unchanged to preserve the
|
||||||
|
// existing "no node given" behavior.
|
||||||
|
func qualifyNode(name, domain string) string {
|
||||||
|
name = strings.TrimSuffix(name, ".")
|
||||||
|
if name == "" || strings.Contains(name, ".") {
|
||||||
|
return name
|
||||||
|
}
|
||||||
|
return name + "." + domain
|
||||||
|
}
|
||||||
|
|
||||||
func buildQuery(node, factName, match, roleFact string, showRole, partial, inverse bool) string {
|
func buildQuery(node, factName, match, roleFact string, showRole, partial, inverse bool) string {
|
||||||
type filter = []interface{}
|
type filter = []interface{}
|
||||||
var filters []filter
|
var filters []filter
|
||||||
@@ -117,8 +173,8 @@ func buildQuery(node, factName, match, roleFact string, showRole, partial, inver
|
|||||||
if node != "" {
|
if node != "" {
|
||||||
filters = append(filters, filter{"=", "certname", node})
|
filters = append(filters, filter{"=", "certname", node})
|
||||||
}
|
}
|
||||||
if factName != "" {
|
if names := splitFactNames(factName); len(names) > 0 {
|
||||||
filters = append(filters, filter{"=", "name", factName})
|
filters = append(filters, nameFilter(names))
|
||||||
} else if showRole {
|
} else if showRole {
|
||||||
filters = append(filters, filter{"=", "name", roleFact})
|
filters = append(filters, filter{"=", "name", roleFact})
|
||||||
}
|
}
|
||||||
@@ -236,6 +292,46 @@ func stdinReader(f *os.File) (*bufio.Reader, bool) {
|
|||||||
return r, true
|
return r, true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// matchValue resolves the value to match against. The -m/--match flag wins; if
|
||||||
|
// it is empty, the (optional) positional argument is used instead. The
|
||||||
|
// positional fallback exists so combined shorthands like `-pm k8s` work — pflag
|
||||||
|
// leaves the space-separated `k8s` as a positional rather than attaching it to
|
||||||
|
// the grouped -m flag.
|
||||||
|
func matchValue(flagMatch string, args []string) string {
|
||||||
|
if flagMatch != "" {
|
||||||
|
return flagMatch
|
||||||
|
}
|
||||||
|
if len(args) > 0 {
|
||||||
|
return args[0]
|
||||||
|
}
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
|
// factsByHost groups collected facts into {certname: {factname: value}}. Each
|
||||||
|
// value is keyed by the fact's real name, so multiple -F facts each appear
|
||||||
|
// under the host; it falls back to the -F string, the role fact (with -R), or
|
||||||
|
// "value" only when a result carries no name. Shared by the -j and -A outputs.
|
||||||
|
func factsByHost(collected []fact, factName, roleFact string, showRole bool) map[string]map[string]interface{} {
|
||||||
|
out := map[string]map[string]interface{}{}
|
||||||
|
for _, f := range collected {
|
||||||
|
if _, ok := out[f.Certname]; !ok {
|
||||||
|
out[f.Certname] = map[string]interface{}{}
|
||||||
|
}
|
||||||
|
key := f.Name
|
||||||
|
if key == "" {
|
||||||
|
if key = factName; key == "" {
|
||||||
|
if showRole {
|
||||||
|
key = roleFact
|
||||||
|
} else {
|
||||||
|
key = "value"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
out[f.Certname][key] = valueAny(f.Value)
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
func allFactsForNode(puppetDBURL, node string) ([]fact, error) {
|
func allFactsForNode(puppetDBURL, node string) ([]fact, error) {
|
||||||
query, _ := json.Marshal([]interface{}{"=", "certname", node})
|
query, _ := json.Marshal([]interface{}{"=", "certname", node})
|
||||||
return queryPuppetDB(puppetDBURL, string(query))
|
return queryPuppetDB(puppetDBURL, string(query))
|
||||||
@@ -244,6 +340,8 @@ func allFactsForNode(puppetDBURL, node string) ([]fact, error) {
|
|||||||
func run(cfg config, nodeName, factName, match string, showRole, partial, inverse, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts bool) error {
|
func run(cfg config, nodeName, factName, match string, showRole, partial, inverse, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts bool) error {
|
||||||
signal.Ignore(syscall.SIGPIPE)
|
signal.Ignore(syscall.SIGPIPE)
|
||||||
|
|
||||||
|
nodeName = qualifyNode(nodeName, cfg.Domain)
|
||||||
|
|
||||||
if allFacts {
|
if allFacts {
|
||||||
if nodeName == "" {
|
if nodeName == "" {
|
||||||
return fmt.Errorf("-a requires -n")
|
return fmt.Errorf("-a requires -n")
|
||||||
@@ -291,7 +389,7 @@ func run(cfg config, nodeName, factName, match string, showRole, partial, invers
|
|||||||
if len(fields) == 0 {
|
if len(fields) == 0 {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
if err := doQuery(fields[0]); err != nil {
|
if err := doQuery(qualifyNode(fields[0], cfg.Domain)); err != nil {
|
||||||
fmt.Fprintln(os.Stderr, "error:", err)
|
fmt.Fprintln(os.Stderr, "error:", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -306,25 +404,10 @@ func run(cfg config, nodeName, factName, match string, showRole, partial, invers
|
|||||||
|
|
||||||
switch {
|
switch {
|
||||||
case jsonMode:
|
case jsonMode:
|
||||||
hostFactMap := map[string]map[string]interface{}{}
|
|
||||||
for _, f := range collected {
|
|
||||||
if _, ok := hostFactMap[f.Certname]; !ok {
|
|
||||||
hostFactMap[f.Certname] = map[string]interface{}{}
|
|
||||||
}
|
|
||||||
key := factName
|
|
||||||
if key == "" {
|
|
||||||
if showRole {
|
|
||||||
key = cfg.RoleFact
|
|
||||||
} else {
|
|
||||||
key = "value"
|
|
||||||
}
|
|
||||||
}
|
|
||||||
hostFactMap[f.Certname][key] = valueAny(f.Value)
|
|
||||||
}
|
|
||||||
enc := json.NewEncoder(os.Stdout)
|
enc := json.NewEncoder(os.Stdout)
|
||||||
enc.SetIndent("", " ")
|
enc.SetIndent("", " ")
|
||||||
enc.SetEscapeHTML(false)
|
enc.SetEscapeHTML(false)
|
||||||
_ = enc.Encode(hostFactMap)
|
_ = enc.Encode(factsByHost(collected, factName, cfg.RoleFact, showRole))
|
||||||
|
|
||||||
case count:
|
case count:
|
||||||
values := stdinLines
|
values := stdinLines
|
||||||
@@ -334,10 +417,11 @@ func run(cfg config, nodeName, factName, match string, showRole, partial, invers
|
|||||||
fmt.Println(strings.Join(countResults(values), "\n"))
|
fmt.Println(strings.Join(countResults(values), "\n"))
|
||||||
|
|
||||||
case ansible:
|
case ansible:
|
||||||
|
// Attach each host's queried fact(s) as inventory host vars, e.g.
|
||||||
|
// `-F ipaddress,enc_role -A` yields hosts with ipaddress + enc_role set.
|
||||||
hosts := map[string]interface{}{}
|
hosts := map[string]interface{}{}
|
||||||
for _, line := range returnData {
|
for host, vars := range factsByHost(collected, factName, cfg.RoleFact, showRole) {
|
||||||
host := strings.Fields(line)[0]
|
hosts[host] = vars
|
||||||
hosts[host] = map[string]interface{}{}
|
|
||||||
}
|
}
|
||||||
inventory := map[string]interface{}{
|
inventory := map[string]interface{}{
|
||||||
"all": map[string]interface{}{"hosts": hosts},
|
"all": map[string]interface{}{"hosts": hosts},
|
||||||
@@ -386,26 +470,36 @@ func main() {
|
|||||||
jsonMode bool
|
jsonMode bool
|
||||||
allFacts bool
|
allFacts bool
|
||||||
puppetDBURL string
|
puppetDBURL string
|
||||||
|
domain string
|
||||||
)
|
)
|
||||||
|
|
||||||
rootCmd := &cobra.Command{
|
rootCmd := &cobra.Command{
|
||||||
Use: appName,
|
Use: appName + " [value]",
|
||||||
Short: "Query PuppetDB for nodes.",
|
Short: "Query PuppetDB for nodes.",
|
||||||
|
// Accept an optional positional match value in addition to -m. This makes
|
||||||
|
// combined shorthands like `-pm k8s` work: pflag does not attach a
|
||||||
|
// space-separated value to a string flag grouped with a bool flag (only
|
||||||
|
// `-pm=k8s` or `-p -m k8s` do), so `k8s` arrives here as a positional
|
||||||
|
// argument instead. Falling back to it keeps the ergonomic form working.
|
||||||
|
Args: cobra.MaximumNArgs(1),
|
||||||
PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
|
PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
|
||||||
if cmd.Flags().Changed("url") {
|
if cmd.Flags().Changed("url") {
|
||||||
cfg.PuppetDBURL = puppetDBURL
|
cfg.PuppetDBURL = puppetDBURL
|
||||||
}
|
}
|
||||||
|
if cmd.Flags().Changed("domain") {
|
||||||
|
cfg.Domain = domain
|
||||||
|
}
|
||||||
return nil
|
return nil
|
||||||
},
|
},
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
return run(cfg, nodeName, factName, match, showRole, partial, inverse, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts)
|
return run(cfg, nodeName, factName, matchValue(match, args), showRole, partial, inverse, nodeOnly, valueOnly, count, ansible, jsonMode, allFacts)
|
||||||
},
|
},
|
||||||
SilenceUsage: true,
|
SilenceUsage: true,
|
||||||
}
|
}
|
||||||
|
|
||||||
f := rootCmd.Flags()
|
f := rootCmd.Flags()
|
||||||
f.StringVarP(&nodeName, "node", "n", "", "Node name")
|
f.StringVarP(&nodeName, "node", "n", "", "Node name")
|
||||||
f.StringVarP(&factName, "fact", "F", "", "Fact name")
|
f.StringVarP(&factName, "fact", "F", "", "Fact name (comma-separated for several, e.g. -F ipaddress,enc_role)")
|
||||||
f.BoolVarP(&showRole, "role", "R", false, "Show role fact ("+defaultRoleFact+" by default)")
|
f.BoolVarP(&showRole, "role", "R", false, "Show role fact ("+defaultRoleFact+" by default)")
|
||||||
f.StringVarP(&match, "match", "m", "", "Value to match (use with -p and/or -i)")
|
f.StringVarP(&match, "match", "m", "", "Value to match (use with -p and/or -i)")
|
||||||
f.BoolVarP(&partial, "partial", "p", false, "Partial/regex match modifier (combine with -m)")
|
f.BoolVarP(&partial, "partial", "p", false, "Partial/regex match modifier (combine with -m)")
|
||||||
@@ -416,6 +510,7 @@ func main() {
|
|||||||
f.BoolVarP(&ansible, "ansible", "A", false, "Output as Ansible inventory")
|
f.BoolVarP(&ansible, "ansible", "A", false, "Output as Ansible inventory")
|
||||||
f.BoolVarP(&jsonMode, "json", "j", false, "Emit valid JSON for all output")
|
f.BoolVarP(&jsonMode, "json", "j", false, "Emit valid JSON for all output")
|
||||||
f.BoolVarP(&allFacts, "all", "a", false, "Show all facts for a node (requires -n)")
|
f.BoolVarP(&allFacts, "all", "a", false, "Show all facts for a node (requires -n)")
|
||||||
|
f.StringVar(&domain, "domain", cfg.Domain, "Domain appended to short (dotless) -n node names (overrides config and NODE_LOOKUP_DOMAIN)")
|
||||||
rootCmd.PersistentFlags().StringVar(&puppetDBURL, "url", cfg.PuppetDBURL, "PuppetDB facts URL (overrides config and NODE_LOOKUP_URL)")
|
rootCmd.PersistentFlags().StringVar(&puppetDBURL, "url", cfg.PuppetDBURL, "PuppetDB facts URL (overrides config and NODE_LOOKUP_URL)")
|
||||||
|
|
||||||
configCmd := &cobra.Command{
|
configCmd := &cobra.Command{
|
||||||
@@ -436,9 +531,11 @@ func main() {
|
|||||||
Use: "show",
|
Use: "show",
|
||||||
Short: "Print the active configuration",
|
Short: "Print the active configuration",
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
fmt.Printf("config file : %s\n", configPath())
|
fmt.Printf("config file : %s\n", configPath())
|
||||||
fmt.Printf("puppetdb_url: %s\n", cfg.PuppetDBURL)
|
fmt.Printf("puppetdb_url : %s\n", cfg.PuppetDBURL)
|
||||||
fmt.Printf("role_fact : %s\n", cfg.RoleFact)
|
fmt.Printf("role_fact : %s\n", cfg.RoleFact)
|
||||||
|
fmt.Printf("puppetboard_url: %s\n", cfg.PuppetboardURL)
|
||||||
|
fmt.Printf("domain : %s\n", cfg.Domain)
|
||||||
return nil
|
return nil
|
||||||
},
|
},
|
||||||
SilenceUsage: true,
|
SilenceUsage: true,
|
||||||
|
|||||||
+173
@@ -9,6 +9,8 @@ import (
|
|||||||
"path/filepath"
|
"path/filepath"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"gopkg.in/yaml.v3"
|
||||||
)
|
)
|
||||||
|
|
||||||
// ---- helpers ----------------------------------------------------------------
|
// ---- helpers ----------------------------------------------------------------
|
||||||
@@ -142,6 +144,130 @@ func TestBuildQuery_ValidJSON(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ---- multi-fact -F (comma-separated) ----------------------------------------
|
||||||
|
|
||||||
|
func TestSplitFactNames(t *testing.T) {
|
||||||
|
cases := map[string][]string{
|
||||||
|
"ipaddress": {"ipaddress"},
|
||||||
|
"ipaddress,enc_role": {"ipaddress", "enc_role"},
|
||||||
|
"ipaddress, enc_role ": {"ipaddress", "enc_role"}, // trims spaces
|
||||||
|
"a,,b,": {"a", "b"}, // drops empties
|
||||||
|
"": nil,
|
||||||
|
}
|
||||||
|
for in, want := range cases {
|
||||||
|
got := splitFactNames(in)
|
||||||
|
if len(got) != len(want) {
|
||||||
|
t.Fatalf("splitFactNames(%q) = %v, want %v", in, got, want)
|
||||||
|
}
|
||||||
|
for i := range want {
|
||||||
|
if got[i] != want[i] {
|
||||||
|
t.Fatalf("splitFactNames(%q) = %v, want %v", in, got, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQualifyNode(t *testing.T) {
|
||||||
|
const domain = "main.unkin.net"
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
in string
|
||||||
|
want string
|
||||||
|
}{
|
||||||
|
{"short name appends domain", "ausyd1nxvm2120", "ausyd1nxvm2120.main.unkin.net"},
|
||||||
|
{"fqdn in default domain unchanged", "ausyd1nxvm2120.main.unkin.net", "ausyd1nxvm2120.main.unkin.net"},
|
||||||
|
{"multi-label fqdn other domain unchanged", "foo.k8s.syd1.au.unkin.net", "foo.k8s.syd1.au.unkin.net"},
|
||||||
|
{"short name with trailing dot qualified", "ausyd1nxvm2120.", "ausyd1nxvm2120.main.unkin.net"},
|
||||||
|
{"fqdn with trailing dot stripped", "foo.main.unkin.net.", "foo.main.unkin.net"},
|
||||||
|
{"empty unchanged", "", ""},
|
||||||
|
}
|
||||||
|
for _, tc := range cases {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
if got := qualifyNode(tc.in, domain); got != tc.want {
|
||||||
|
t.Fatalf("qualifyNode(%q, %q) = %q, want %q", tc.in, domain, got, tc.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestQualifyNode_CustomDomain(t *testing.T) {
|
||||||
|
if got := qualifyNode("host1", "example.com"); got != "host1.example.com" {
|
||||||
|
t.Fatalf("qualifyNode with custom domain = %q, want host1.example.com", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBuildQuery_SingleFact_NoOr(t *testing.T) {
|
||||||
|
q := buildQuery("", "ipaddress", "", "enc_role", false, false, false)
|
||||||
|
if strings.Contains(q, `"or"`) {
|
||||||
|
t.Fatalf("single fact should not use 'or': %s", q)
|
||||||
|
}
|
||||||
|
if !strings.Contains(q, "ipaddress") {
|
||||||
|
t.Fatalf("expected fact name in query: %s", q)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBuildQuery_MultiFact_UsesOr(t *testing.T) {
|
||||||
|
q := buildQuery("host1", "ipaddress,enc_role", "", "enc_role", false, false, false)
|
||||||
|
if !strings.Contains(q, `"or"`) {
|
||||||
|
t.Fatalf("expected 'or' over fact names: %s", q)
|
||||||
|
}
|
||||||
|
if !strings.Contains(q, "ipaddress") || !strings.Contains(q, "enc_role") {
|
||||||
|
t.Fatalf("expected both fact names: %s", q)
|
||||||
|
}
|
||||||
|
// Must remain valid PQL JSON, combined under "and" with the certname filter.
|
||||||
|
var v []interface{}
|
||||||
|
if err := json.Unmarshal([]byte(q), &v); err != nil {
|
||||||
|
t.Fatalf("query is not valid JSON: %v (%s)", err, q)
|
||||||
|
}
|
||||||
|
if v[0] != "and" {
|
||||||
|
t.Fatalf("expected top-level 'and', got %v", v[0])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestRun_JSON_MultipleFacts(t *testing.T) {
|
||||||
|
// Two facts returned for one host must both appear, keyed by their real name.
|
||||||
|
facts := []fact{
|
||||||
|
{Certname: "hosta", Name: "ipaddress", Value: rawJSON("198.18.0.1")},
|
||||||
|
{Certname: "hosta", Name: "enc_role", Value: rawJSON("roles::dns")},
|
||||||
|
}
|
||||||
|
out := runToString(t, facts, func(a *runArgs) {
|
||||||
|
a.showRole = false
|
||||||
|
a.factName = "ipaddress,enc_role"
|
||||||
|
a.jsonMode = true
|
||||||
|
})
|
||||||
|
var parsed map[string]map[string]interface{}
|
||||||
|
if err := json.Unmarshal([]byte(out), &parsed); err != nil {
|
||||||
|
t.Fatalf("output is not valid JSON: %v (%s)", err, out)
|
||||||
|
}
|
||||||
|
host := parsed["hosta"]
|
||||||
|
if host["ipaddress"] != "198.18.0.1" || host["enc_role"] != "roles::dns" {
|
||||||
|
t.Fatalf("expected both facts under host, got: %v", host)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---- matchValue (positional fallback for `-pm value`) -----------------------
|
||||||
|
|
||||||
|
func TestMatchValue_FlagWins(t *testing.T) {
|
||||||
|
// An explicit -m value takes precedence over any positional arg.
|
||||||
|
if got := matchValue("flagval", []string{"posval"}); got != "flagval" {
|
||||||
|
t.Fatalf("expected flag value to win, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMatchValue_PositionalFallback(t *testing.T) {
|
||||||
|
// This is the `-pm k8s` case: pflag leaves k8s as a positional because the
|
||||||
|
// grouped -m flag does not attach the space-separated value.
|
||||||
|
if got := matchValue("", []string{"k8s"}); got != "k8s" {
|
||||||
|
t.Fatalf("expected positional fallback, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMatchValue_NoneGiven(t *testing.T) {
|
||||||
|
if got := matchValue("", nil); got != "" {
|
||||||
|
t.Fatalf("expected empty, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// ---- valueString / valueAny -------------------------------------------------
|
// ---- valueString / valueAny -------------------------------------------------
|
||||||
|
|
||||||
func TestValueString_String(t *testing.T) {
|
func TestValueString_String(t *testing.T) {
|
||||||
@@ -300,6 +426,22 @@ func TestLoadConfig_Defaults(t *testing.T) {
|
|||||||
if cfg.RoleFact != defaultRoleFact {
|
if cfg.RoleFact != defaultRoleFact {
|
||||||
t.Fatalf("expected default role fact, got %s", cfg.RoleFact)
|
t.Fatalf("expected default role fact, got %s", cfg.RoleFact)
|
||||||
}
|
}
|
||||||
|
if cfg.Domain != defaultDomain {
|
||||||
|
t.Fatalf("expected default domain, got %s", cfg.Domain)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoadConfig_DomainEnvOverride(t *testing.T) {
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
||||||
|
t.Setenv("NODE_LOOKUP_DOMAIN", "example.com")
|
||||||
|
|
||||||
|
cfg, err := loadConfig()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if cfg.Domain != "example.com" {
|
||||||
|
t.Fatalf("domain env override failed: %s", cfg.Domain)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLoadConfig_EnvOverride(t *testing.T) {
|
func TestLoadConfig_EnvOverride(t *testing.T) {
|
||||||
@@ -677,6 +819,37 @@ func TestRun_Ansible(t *testing.T) {
|
|||||||
if !strings.Contains(out, "hosta:") || !strings.Contains(out, "hostb:") {
|
if !strings.Contains(out, "hosta:") || !strings.Contains(out, "hostb:") {
|
||||||
t.Fatalf("expected both hosts in inventory, got: %q", out)
|
t.Fatalf("expected both hosts in inventory, got: %q", out)
|
||||||
}
|
}
|
||||||
|
// The queried fact is attached as a host var.
|
||||||
|
if !strings.Contains(out, "enc_role: roles::db") || !strings.Contains(out, "enc_role: roles::web") {
|
||||||
|
t.Fatalf("expected fact host vars in inventory, got: %q", out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestRun_Ansible_MultipleFacts(t *testing.T) {
|
||||||
|
// -F ipaddress,enc_role -A must include both facts as host vars.
|
||||||
|
facts := []fact{
|
||||||
|
{Certname: "hosta", Name: "ipaddress", Value: rawJSON("198.18.0.1")},
|
||||||
|
{Certname: "hosta", Name: "enc_role", Value: rawJSON("roles::dns")},
|
||||||
|
}
|
||||||
|
out := runToString(t, facts, func(a *runArgs) {
|
||||||
|
a.showRole = false
|
||||||
|
a.factName = "ipaddress,enc_role"
|
||||||
|
a.ansible = true
|
||||||
|
})
|
||||||
|
|
||||||
|
// Parse it back as YAML and assert the structure precisely.
|
||||||
|
var inv struct {
|
||||||
|
All struct {
|
||||||
|
Hosts map[string]map[string]interface{} `yaml:"hosts"`
|
||||||
|
} `yaml:"all"`
|
||||||
|
}
|
||||||
|
if err := yaml.Unmarshal([]byte(out), &inv); err != nil {
|
||||||
|
t.Fatalf("inventory is not valid YAML: %v (%s)", err, out)
|
||||||
|
}
|
||||||
|
host := inv.All.Hosts["hosta"]
|
||||||
|
if host["ipaddress"] != "198.18.0.1" || host["enc_role"] != "roles::dns" {
|
||||||
|
t.Fatalf("expected both facts as host vars, got: %v", host)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestRun_AllFacts_PrintsSortedByName(t *testing.T) {
|
func TestRun_AllFacts_PrintsSortedByName(t *testing.T) {
|
||||||
|
|||||||
+37
-1
@@ -23,13 +23,25 @@ provides:
|
|||||||
- node-lookup
|
- node-lookup
|
||||||
|
|
||||||
contents:
|
contents:
|
||||||
# The CLI binary.
|
# The CLI binaries: node-lookup and its companion tools.
|
||||||
- src: dist/node-lookup
|
- src: dist/node-lookup
|
||||||
dst: /usr/bin/node-lookup
|
dst: /usr/bin/node-lookup
|
||||||
file_info:
|
file_info:
|
||||||
mode: 0755
|
mode: 0755
|
||||||
owner: root
|
owner: root
|
||||||
group: root
|
group: root
|
||||||
|
- src: dist/pburl
|
||||||
|
dst: /usr/bin/pburl
|
||||||
|
file_info:
|
||||||
|
mode: 0755
|
||||||
|
owner: root
|
||||||
|
group: root
|
||||||
|
- src: dist/pblastreport
|
||||||
|
dst: /usr/bin/pblastreport
|
||||||
|
file_info:
|
||||||
|
mode: 0755
|
||||||
|
owner: root
|
||||||
|
group: root
|
||||||
|
|
||||||
# Shell completions (generated by scripts/build-rpm.sh before packaging).
|
# Shell completions (generated by scripts/build-rpm.sh before packaging).
|
||||||
- src: dist/completions/node-lookup.bash
|
- src: dist/completions/node-lookup.bash
|
||||||
@@ -44,3 +56,27 @@ contents:
|
|||||||
dst: /usr/share/fish/vendor_completions.d/node-lookup.fish
|
dst: /usr/share/fish/vendor_completions.d/node-lookup.fish
|
||||||
file_info:
|
file_info:
|
||||||
mode: 0644
|
mode: 0644
|
||||||
|
- src: dist/completions/pburl.bash
|
||||||
|
dst: /usr/share/bash-completion/completions/pburl
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
- src: dist/completions/_pburl
|
||||||
|
dst: /usr/share/zsh/site-functions/_pburl
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
- src: dist/completions/pburl.fish
|
||||||
|
dst: /usr/share/fish/vendor_completions.d/pburl.fish
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
- src: dist/completions/pblastreport.bash
|
||||||
|
dst: /usr/share/bash-completion/completions/pblastreport
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
- src: dist/completions/_pblastreport
|
||||||
|
dst: /usr/share/zsh/site-functions/_pblastreport
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
- src: dist/completions/pblastreport.fish
|
||||||
|
dst: /usr/share/fish/vendor_completions.d/pblastreport.fish
|
||||||
|
file_info:
|
||||||
|
mode: 0644
|
||||||
|
|||||||
+17
-12
@@ -1,7 +1,7 @@
|
|||||||
#!/usr/bin/env bash
|
#!/usr/bin/env bash
|
||||||
#
|
#
|
||||||
# Package the (already built) node-lookup binary into an RPM with nfpm,
|
# Package the (already built) node-lookup, pburl and pblastreport binaries into
|
||||||
# bundling generated bash/zsh/fish shell completions.
|
# an RPM with nfpm, bundling generated bash/zsh/fish shell completions.
|
||||||
# Usage: scripts/build-rpm.sh [version] (version defaults to $CI_COMMIT_TAG)
|
# Usage: scripts/build-rpm.sh [version] (version defaults to $CI_COMMIT_TAG)
|
||||||
#
|
#
|
||||||
set -euo pipefail
|
set -euo pipefail
|
||||||
@@ -12,27 +12,32 @@ cd "${ROOT_DIR}"
|
|||||||
VERSION="${1:-${CI_COMMIT_TAG:-0.0.0-dev}}"
|
VERSION="${1:-${CI_COMMIT_TAG:-0.0.0-dev}}"
|
||||||
VERSION="${VERSION#v}" # strip a leading v
|
VERSION="${VERSION#v}" # strip a leading v
|
||||||
BINARY="node-lookup"
|
BINARY="node-lookup"
|
||||||
|
BINARIES=(node-lookup pburl pblastreport)
|
||||||
DIST="dist"
|
DIST="dist"
|
||||||
|
|
||||||
if [ ! -f "${DIST}/${BINARY}" ]; then
|
for b in "${BINARIES[@]}"; do
|
||||||
echo "ERROR: ${DIST}/${BINARY} not found; run 'make build' first" >&2
|
if [ ! -f "${DIST}/${b}" ]; then
|
||||||
exit 1
|
echo "ERROR: ${DIST}/${b} not found; run 'make build' first" >&2
|
||||||
fi
|
exit 1
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
# Generate shell completions from the freshly built binary so they always match
|
# Generate shell completions from the freshly built binaries so they always
|
||||||
# the shipped flags/subcommands.
|
# match the shipped flags/subcommands.
|
||||||
COMP_DIR="${DIST}/completions"
|
COMP_DIR="${DIST}/completions"
|
||||||
mkdir -p "${COMP_DIR}"
|
mkdir -p "${COMP_DIR}"
|
||||||
"./${DIST}/${BINARY}" completion bash >"${COMP_DIR}/${BINARY}.bash"
|
for b in "${BINARIES[@]}"; do
|
||||||
"./${DIST}/${BINARY}" completion zsh >"${COMP_DIR}/_${BINARY}"
|
"./${DIST}/${b}" completion bash >"${COMP_DIR}/${b}.bash"
|
||||||
"./${DIST}/${BINARY}" completion fish >"${COMP_DIR}/${BINARY}.fish"
|
"./${DIST}/${b}" completion zsh >"${COMP_DIR}/_${b}"
|
||||||
|
"./${DIST}/${b}" completion fish >"${COMP_DIR}/${b}.fish"
|
||||||
|
done
|
||||||
|
|
||||||
export PACKAGE_NAME="${BINARY}"
|
export PACKAGE_NAME="${BINARY}"
|
||||||
export PACKAGE_VERSION="${VERSION}"
|
export PACKAGE_VERSION="${VERSION}"
|
||||||
export PACKAGE_RELEASE="1"
|
export PACKAGE_RELEASE="1"
|
||||||
export PACKAGE_ARCH="amd64"
|
export PACKAGE_ARCH="amd64"
|
||||||
export PACKAGE_PLATFORM="linux"
|
export PACKAGE_PLATFORM="linux"
|
||||||
export PACKAGE_DESCRIPTION="CLI tool that queries the PuppetDB API to look up and filter node facts"
|
export PACKAGE_DESCRIPTION="CLI tools for PuppetDB: node-lookup (fact lookup/filtering) plus pburl and pblastreport (Puppetboard URLs and last-report times)"
|
||||||
export PACKAGE_MAINTAINER="Ben Vincent <ben@unkin.net>"
|
export PACKAGE_MAINTAINER="Ben Vincent <ben@unkin.net>"
|
||||||
export PACKAGE_HOMEPAGE="https://git.unkin.net/unkin/node-lookup"
|
export PACKAGE_HOMEPAGE="https://git.unkin.net/unkin/node-lookup"
|
||||||
export PACKAGE_LICENSE="MIT"
|
export PACKAGE_LICENSE="MIT"
|
||||||
|
|||||||
Reference in New Issue
Block a user