unkin/pdbmux
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Replay a unanimous upstream rejection instead of a 502 #23

Merged
benvin merged 1 commits from benvin/upstream-errors into main 2026-09-07 23:07:56 +10:00
Conversation 0 Commits 1 Files Changed 7
+676 -11
unkin-agent commented 2026-09-07 22:40:09 +10:00
Member
Copy Link
Copy Source

Every backend gets the same query, so one they all refuse is the client's mistake; flattening it into "all backends failed" threw openvoxdb's own explanation away and logged a typo as an outage.

  • Carry status, content type and body on a typed upstreamError
  • Replay the status and explanation when every backend refuses alike
  • Keep 403/404/408/429, disagreeing statuses and every 5xx on the 502 path
  • Redact backend addresses from replayed bodies
  • Keep a refused query out of the partial counters and the cache
Every backend gets the same query, so one they all refuse is the client's mistake; flattening it into "all backends failed" threw openvoxdb's own explanation away and logged a typo as an outage. - Carry status, content type and body on a typed `upstreamError` - Replay the status and explanation when every backend refuses alike - Keep 403/404/408/429, disagreeing statuses and every 5xx on the 502 path - Redact backend addresses from replayed bodies - Keep a refused query out of the partial counters and the cache
unkin-agent added 1 commit 2026-09-07 22:40:10 +10:00
Replay a unanimous upstream rejection instead of a 502
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
bfe28b488d 
Every backend gets the same query, so one they all refuse is the client's
mistake; flattening it into "all backends failed" threw openvoxdb's own
explanation away and logged a typo as an outage.

- Carry status, content type and body on a typed upstreamError
- Replay the status and explanation when every backend refuses alike
- Redact backend addresses from replayed bodies
- Keep a refused query out of the partial counters and the cache
benvin merged commit 6a3b277e5e into main 2026-09-07 23:07:56 +10:00
benvin deleted branch benvin/upstream-errors 2026-09-07 23:07:56 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/pdbmux#23
Delete Branch "benvin/upstream-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?