unkin/pdbmux
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: sum aggregate rows across backends on event-counts and /reports #8

Merged
benvin merged 1 commits from benvin/aggregate-sums into main 2026-09-05 13:06:44 +10:00
Conversation 0 Commits 1 Files Changed 5
+776 -12
unkin-agent commented 2026-09-05 11:46:43 +10:00
Member
Copy Link
Copy Source

Why

Puppetboard's node-status numbers and daily-reports chart are wrong: each PuppetDB
counts only its own slice, and pdbmux passed both partial rows through instead of
adding them. PR #5 left aggregates un-summed on purpose; this closes that gap.

How

  • Sum /event-counts per subject and /aggregate-event-counts per summary object across backends.
  • Sum extract/count()/group_by rows on /reports, grouping on the query's plain extract fields plus its group_by clause; a query with no function column stays on the union path.
  • Absent or non-numeric aggregate columns are skipped rather than zeroed, and a key only one backend reported passes through byte-for-byte.
  • include_total on a summed endpoint reports the merged row count, not the sum of the backends' X-Records.
## Why Puppetboard's node-status numbers and daily-reports chart are wrong: each PuppetDB counts only its own slice, and pdbmux passed both partial rows through instead of adding them. PR #5 left aggregates un-summed on purpose; this closes that gap. ## How - Sum `/event-counts` per subject and `/aggregate-event-counts` per summary object across backends. - Sum `extract`/`count()`/`group_by` rows on `/reports`, grouping on the query's plain extract fields plus its `group_by` clause; a query with no `function` column stays on the union path. - Absent or non-numeric aggregate columns are skipped rather than zeroed, and a key only one backend reported passes through byte-for-byte. - `include_total` on a summed endpoint reports the merged row count, not the sum of the backends' `X-Records`.
unkin-agent added 1 commit 2026-09-05 12:30:24 +10:00
feat: sum aggregate rows across backends on event-counts and /reports
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
b1ecbf31ac 
- group by the row's non-aggregate fields and add the numeric columns; X-Records on a summed endpoint is the merged row count
unkin-agent force-pushed benvin/aggregate-sums from b7dc2a53a2 to b1ecbf31ac 2026-09-05 12:30:24 +10:00 Compare
benvin merged commit d724cf0a5e into main 2026-09-05 13:06:44 +10:00
benvin deleted branch benvin/aggregate-sums 2026-09-05 13:06:44 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/pdbmux#8
Delete Branch "benvin/aggregate-sums"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?