Report the accumulated warnings on stderr when the estate load fails, and fold
the dropped-record tally into the error. Count records rather than warning
messages in --explain, by carrying the count on the Warn hook.
catalog-impact built its PuppetDB client without a Warn hook, so a host whose
fact records all failed to decode vanished from the estate table with no
warning on any output path.
- wire catalog-impact's Warn hook into NodeWarnings
- default an unset Warn to stderr so a dropped record is never silent
- thread stderr through run() instead of writing os.Stderr directly
- count dropped fact records in the explain resolution-incomplete line
A differently quoted substring inside a ${...} interpolation ended the
outer string early and truncated the argument list, dropping every name
after it. One shared walker now backs every source scan.
Lowercase the recovered prefix of an unresolved reference, and every
class name as it is added, so a mixed-case interpolated name still
widens.
Report fact records with no certname instead of dropping them, and
assert stripSource keeps newline positions rather than just length.
- walk the classes holding an unresolved reference when tracing any class
it could have named, so a dropped edge cannot lose hosts
- list unresolved references in --explain, in unresolved_references in
--json and on stderr, and flag summary.resolution_incomplete
- name an ordering reference as such in the --explain chain
- strip # comments with quote-state tracking so a hash in a string no
longer truncates the line
- skip heredoc bodies in every @(EOT) form so documentation text is not
indexed as a class reference
- take every literal name out of a selector, following a bare variable
through the assignments in its own file
- record a class reference that stays unresolved against its file, with
any literal prefix, instead of dropping it
- read a class name case insensitively in a title or type reference
- tag each edge as a declaration or an ordering reference
A hieradata file for a role with no members produces an empty host list, which
is indistinguishable from a mapping failure.
- list files that mapped cleanly but selected nobody in --explain
A params.pp is only ever reached by inherits and $class::var, so changing one
resolved to no hosts at all.
- index inherits, $class::var reads and create_resources()
- match a defined type declared part-way along a line
Work out which hosts a puppet-prod change can affect, so a catalog test can
fan out over exactly those hosts instead of the whole estate.
- add cmd/catalog-impact and internal/impact
- map hieradata paths onto fact selectors from the hiera hierarchy
- trace manifest classes back to role classes through include, contain,
class {} and hiera_include, to a fixed point
- fetch the estate fact table from pdbmux in one query via FactsByName
- widen to all hosts, loudly, for any path that matches no rule
- ship the binary and its completions in the RPM
unkin-agent