fix: replace puppetdbquery with native PQL queries (#457)

Replace deprecated dalen-puppetdbquery module with native puppetdb_query
function using PQL syntax to resolve URI.escape compatibility issues.
This is required to migrated to Puppet 8 (and kubernetes).

Changes:
- Remove dalen-puppetdbquery dependency from Puppetfile
- Replace query_nodes() calls with puppetdb_query() using PQL syntax
- Update 27 function calls across 18 Puppet manifests
- Maintain equivalent functionality with improved compatibility

Reviewed-on: #457

site/profiles/manifests/ntp/client.pp

@@ -26,9 +26,21 @@ class profiles::ntp::client (
     $ntpserver_array = $ntp_role ? {
       undef   => $peers,
       default => $use_ntp ? {
-        'all'     => query_nodes("enc_role='${ntp_role}'", 'networking.fqdn'),
-        'region'  => query_nodes("enc_role='${ntp_role}' and region=${facts['region']}", 'networking.fqdn'),
-        'country' => query_nodes("enc_role='${ntp_role}' and country=${facts['country']}", 'networking.fqdn'),
+        'all'     => puppetdb_query(
+          "facts[certname] { name = 'enc_role' and value = '${ntp_role}' }"
+        ).map |$fact| { $fact['certname'] },
+        'region'  => puppetdb_query(
+          "facts[certname] {
+            name = 'enc_role' and value = '${ntp_role}' and
+            certname in facts[certname] { name = 'region' and value = '${facts['region']}' }
+          }"
+        ).map |$fact| { $fact['certname'] },
+        'country' => puppetdb_query(
+          "facts[certname] {
+            name = 'enc_role' and value = '${ntp_role}' and
+            certname in facts[certname] { name = 'country' and value = '${facts['country']}' }
+          }"
+        ).map |$fact| { $fact['certname'] },
       }
     }