fix: resolve warnings/errors
All checks were successful
Build / precommit (pull_request) Successful in 3m31s

- modules/libs/lib/facter/pve_nodelist.rb:11:5: W: [Correctable] Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/BlockNesting.a
- site/profiles/manifests/puppet/puppetboard.pp - WARNING: there should be a single space before '=>' on line 158, column 14 on line 158 (check: space_before_arrow)
- site/profiles/manifests/consul/client.pp - WARNING: there should be a single space before '=>' on line 93, column 13 on line 93 (check: space_before_arrow)
- site/profiles/manifests/ntp/client.pp - WARNING: there should be a single space before '=>' on line 44, column 16 on line 44 (check: space_before_arrow)
- site/profiles/manifests/puppet/enc.pp - WARNING: there should be a single space before '=>' on line 14, column 11 on line 14 (check: space_before_arrow)
- site/profiles/manifests/puppet/enc.pp - WARNING: there should be a single space before '=>' on line 18, column 11 on line 18 (check: space_before_arrow)

- set max block nesting to 4
This commit is contained in:
Ben Vincent 2025-07-08 19:53:53 +10:00
parent 46beea21d2
commit 8745c6bcb8
6 changed files with 10 additions and 10 deletions

View File

@ -8,3 +8,6 @@ Style/Documentation:
Layout/LineLength:
Max: 140
Metrics/BlockNesting:
Max: 4

View File

@ -8,7 +8,6 @@ Facter.add('pve_nodelist') do
conf_file = '/etc/pve/corosync.conf'
node_list = {}
current_node = nil
# rubocop:disable Metrics/BlockNesting
if File.exist?(conf_file)
File.foreach(conf_file) do |line|
@ -28,8 +27,6 @@ Facter.add('pve_nodelist') do
end
end
# rubocop:enable Metrics/BlockNesting
node_list.empty? ? nil : node_list
end
end

View File

@ -90,7 +90,7 @@ class profiles::consul::client (
# cleanup /usr/local/bin/consul which was created by url install method
if $facts['os']['family'] == 'RedHat' {
file {'/usr/local/bin/consul':
ensure => absent,
ensure => absent,
}
}
}

View File

@ -41,7 +41,7 @@ class profiles::ntp::client (
}
} else {
class { 'chrony':
servers => sort($ntpserver_array),
servers => sort($ntpserver_array),
}
}
}

View File

@ -11,11 +11,11 @@ class profiles::puppet::enc (
) {
file { '/opt/puppetlabs/bin/enc':
ensure => absent,
ensure => absent,
}
file { '/opt/puppetlabs/bin/puppet-enc':
ensure => absent,
ensure => absent,
}
$_timer = @(EOT)

View File

@ -155,7 +155,7 @@ class profiles::puppet::puppetboard (
# call the nginx selinux class
class { 'profiles::selinux::nginx':
require => Class['Nginx'],
require => Class['Nginx'],
}
}
}