chore: centralise all yum repo configuration (#436)

- add 30+ repository definitions to AlmaLinux/all_releases.yaml with `ensure: absent` defaults
- update all role-specific hieradata files to use `ensure: present` pattern
- remove duplicated repository URL/GPG key configurations from individual roles
- maintains existing functionality while improving maintainability"

Reviewed-on: #436

site/profiles/manifests/puppet/agent.pp

@@ -20,9 +20,9 @@ class profiles::puppet::agent (
   if $openvox_enable and $facts['os']['family'] == 'RedHat' {
     yumrepo { 'openvox':
       ensure  => 'present',
-      baseurl => "https://packagerepo.service.consul/openvox7/el/${facts['os']['release']['major']}-daily/${facts['os']['architecture']}/os/",
+      baseurl => "https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/openvox/openvox7/el/${facts['os']['release']['major']}/${facts['os']['architecture']}/",
       descr   => 'openvox repository',
-      gpgkey  => "https://packagerepo.service.consul/openvox7/el/${facts['os']['release']['major']}-daily/${facts['os']['architecture']}/os/GPG-KEY-openvox.pub",
+      gpgkey  => 'https://artifactapi.k8s.syd1.au.unkin.net/api/v1/remote/openvox/GPG-KEY-openvox.pub',
       notify  => Exec['dnf_makecache'],
     }
   }else{

site/profiles/manifests/yum/global.pp

@@ -32,11 +32,14 @@ class profiles::yum::global (
       $key_url = $repo['gpgkey']
       $key_file = "/etc/pki/rpm-gpg/${name}-gpg-key"
 
-      exec { "download_gpg_key_${name}":
-        command => "curl -s -o ${key_file} ${key_url} && rpm --import ${key_file}",
-        path    => ['/bin', 'usr/bin'],
-        creates => $key_file,
-        before  => Yumrepo[$name],
+      # only download the key if the repo is present
+      if $repo['ensure'] == 'present' {
+        exec { "download_gpg_key_${name}":
+          command => "curl -s -o ${key_file} ${key_url} && rpm --import ${key_file}",
+          path    => ['/bin', 'usr/bin'],
+          creates => $key_file,
+          before  => Yumrepo[$name],
+        }
       }
     }
     # create the repo