From 95a0b543fd6a7a5c82c537df547ee04b21cea58b Mon Sep 17 00:00:00 2001
From: Ben Vincent <ben@unkin.net>
Date: Thu, 11 Jul 2024 19:59:26 +1000
Subject: [PATCH] feat: add othergroups support for services

- extend glauth::obj::service to allow othergroups
---
 modules/glauth/manifests/obj/service.pp  | 6 ++++++
 modules/glauth/templates/obj/service.epp | 1 +
 2 files changed, 7 insertions(+)

diff --git a/modules/glauth/manifests/obj/service.pp b/modules/glauth/manifests/obj/service.pp
index 53e53ef..470133b 100644
--- a/modules/glauth/manifests/obj/service.pp
+++ b/modules/glauth/manifests/obj/service.pp
@@ -6,7 +6,12 @@ define glauth::obj::service (
   Integer $primarygroup,
   String $passsha256,
   Stdlib::Absolutepath $config_path,
+  Optional[Array[Integer]] $othergroups = [],
 ) {
+  $formatted_othergroups = $othergroups.empty ? {
+    true    => '[]',
+    false   => "[${othergroups.join(', ')}]",
+  }
   concat::fragment { "glauth_service_${service_name}":
     target  => $config_path,
     content => epp('glauth/obj/service.epp', {
@@ -15,6 +20,7 @@ define glauth::obj::service (
       'uidnumber'    => $uidnumber,
       'primarygroup' => $primarygroup,
       'passsha256'   => $passsha256,
+      'othergroups'  => $formatted_othergroups,
     }),
     order   => '80',
   }
diff --git a/modules/glauth/templates/obj/service.epp b/modules/glauth/templates/obj/service.epp
index b063ce7..aa15d66 100644
--- a/modules/glauth/templates/obj/service.epp
+++ b/modules/glauth/templates/obj/service.epp
@@ -4,4 +4,5 @@
   uidnumber = <%= $uidnumber %>
   primarygroup = <%= $primarygroup %>
   passsha256 = "<%= $passsha256 %>"
+  othergroups = <%= $othergroups %>