unkin/repospawner
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable API token automount on spawned job pods #2

Merged
benvin merged 1 commits from benvin/job-no-automount into main 2026-08-30 16:05:38 +10:00
Conversation 0 Commits 1 Files Changed 2
+7
unkin-agent commented 2026-08-30 15:33:04 +10:00
Member
Copy Link
Copy Source

Why

Job pods set ServiceAccountName but leave automount at its default, so every pr/watch/woodpecker-enable pod carries an unused k8s API token with the repospawner Role's access — no job subcommand touches the k8s API.

How

  • Set AutomountServiceAccountToken: false on the job PodSpec (the explicit vault-audience projected token volume is unchanged) and assert it in the job-spec test.
## Why Job pods set `ServiceAccountName` but leave automount at its default, so every pr/watch/woodpecker-enable pod carries an unused k8s API token with the repospawner Role's access — no job subcommand touches the k8s API. ## How - Set `AutomountServiceAccountToken: false` on the job PodSpec (the explicit vault-audience projected token volume is unchanged) and assert it in the job-spec test.
unkin-agent added 1 commit 2026-08-30 15:33:04 +10:00
Disable API token automount on spawned job pods
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
6aec05deae 
Job pods only need the vault-audience projected token to log in; the
default automounted ServiceAccount token hands them the repospawner
Role's k8s API access that no job subcommand uses.
benvin merged commit 9b49170083 into main 2026-08-30 16:05:38 +10:00
benvin deleted branch benvin/job-no-automount 2026-08-30 16:05:38 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/repospawner#2
Delete Branch "benvin/job-no-automount"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?