refactor: modernise RPM builder with Python tooling v2

- Migrate from legacy shell-based build system to modern Python tooling
- Update all metadata.yaml files to new schema with per-distro builds
- Standardise build scripts with curl -L, envsubst, and error handling
- Convert nfpm.yaml templates to use environment variable substitution
- Update Dockerfile to accept all package metadata as build arguments
- Modernise Makefile to use new Python build tool commands
- Update CI workflow to use tools/build instead of make

rpms/consul/metadata.yaml

@@ -1,8 +1,18 @@
+---
+arch: amd64
+builds:
+  - image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
+    release: '1'
+    repository: [almalinux/el8]
+    version: 1.21.1
+  - image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    release: '1'
+    repository: [almalinux/el9]
+    version: 1.21.1
+description: Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.
+github: hashicorp/consul
+homepage: https://github.com/hashicorp/consul
+license: BUSL-1.1
+maintainer: HashiCorp
 name: consul
-release: 1
-version: 1.21.1
-build:
-- distro: el/8
-  image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
-- distro: el/9
-  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+platform: linux

rpms/consul/resources/build.sh

@@ -1,11 +1,16 @@
 #!/usr/bin/bash
 
+set -e
+
 # Install dependencies
 dnf install -y unzip
 
 # Download and extract consul
-curl -o /app/consul.zip https://releases.hashicorp.com/consul/${PACKAGE_VERSION}/consul_${PACKAGE_VERSION}_linux_amd64.zip
+curl -L -o /app/consul.zip https://releases.hashicorp.com/consul/${PACKAGE_VERSION}/consul_${PACKAGE_VERSION}_linux_amd64.zip
 unzip consul.zip
 
+# Process the nfpm.yaml template with environment variables
+envsubst < /app/resources/nfpm.yaml > /app/nfpm.yaml
+
 # Build the RPM
-nfpm pkg --config /app/resources/nfpm.yaml --target /app/dist --packager rpm
+nfpm pkg --config /app/nfpm.yaml --target /app/dist --packager rpm

rpms/consul/resources/nfpm.yaml

@@ -1,17 +1,17 @@
 # nfpm.yaml
 
-name: consul
+name: ${PACKAGE_NAME}
 version: ${PACKAGE_VERSION}
 release: ${PACKAGE_RELEASE}
-arch: amd64
-platform: linux
+arch: ${PACKAGE_ARCH}
+platform: ${PACKAGE_PLATFORM}
 section: default
 priority: extra
-description: "Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure."
+description: "${PACKAGE_DESCRIPTION}"
 
-maintainer: HashiCorp
-homepage: https://github.com/hashicorp/consul
-license: BUSL-1.1
+maintainer: ${PACKAGE_MAINTAINER}
+homepage: ${PACKAGE_HOMEPAGE}
+license: ${PACKAGE_LICENSE}
 
 disable_globbing: false