refactor: modernise RPM builder with Python tooling v2

- Migrate from legacy shell-based build system to modern Python tooling
- Update all metadata.yaml files to new schema with per-distro builds
- Standardise build scripts with curl -L, envsubst, and error handling
- Convert nfpm.yaml templates to use environment variable substitution
- Update Dockerfile to accept all package metadata as build arguments
- Modernise Makefile to use new Python build tool commands
- Update CI workflow to use tools/build instead of make

rpms/helmfile/metadata.yaml

@@ -1,9 +1,18 @@
+---
+arch: amd64
+builds:
+  - image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
+    release: '1'
+    repository: [almalinux/el8]
+    version: 1.1.7
+  - image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
+    release: '1'
+    repository: [almalinux/el9]
+    version: 1.1.7
+description: A declarative spec for deploying Helm charts. It lets you keep a directory of chart value files and maintain changes in version control; apply CI/CD to configuration changes; and periodically sync to avoid skew in environments.
+github: helmfile/helmfile
+homepage: https://github.com/helmfile/helmfile
+license: MIT
+maintainer: Helmfile Contributors
 name: helmfile
-release: 1
-version: 1.1.7
-build:
-- distro: el/8
-  image: git.unkin.net/unkin/almalinux8-rpmbuilder:latest
-- distro: el/9
-  image: git.unkin.net/unkin/almalinux9-rpmbuilder:latest
-github: helmfile/helmfile
+platform: linux

rpms/helmfile/resources/build.sh

@@ -1,5 +1,7 @@
 #!/usr/bin/bash
 
+set -e
+
 # Download the required files
 curl -L -o /app/helmfile.tar.gz https://github.com/helmfile/helmfile/releases/download/v${PACKAGE_VERSION}/helmfile_${PACKAGE_VERSION}_linux_amd64.tar.gz
 
@@ -10,5 +12,7 @@ tar -xzf helmfile.tar.gz
 # Make the binary executable
 chmod +x /app/helmfile
 
-# Build the RPM
-nfpm pkg --config /app/resources/nfpm.yaml --target /app/dist --packager rpm
+# Process the nfpm.yaml template with environment variables
+envsubst < /app/resources/nfpm.yaml > /app/nfpm.yaml
+
+nfpm pkg --config /app/nfpm.yaml --target /app/dist --packager rpm

rpms/helmfile/resources/nfpm.yaml

@@ -1,17 +1,17 @@
 # nfpm.yaml
 
-name: helmfile
+name: ${PACKAGE_NAME}
 version: ${PACKAGE_VERSION}
 release: ${PACKAGE_RELEASE}
-arch: amd64
-platform: linux
+arch: ${PACKAGE_ARCH}
+platform: ${PACKAGE_PLATFORM}
 section: default
 priority: extra
-description: "A declarative spec for deploying Helm charts. It lets you keep a directory of chart value files and maintain changes in version control; apply CI/CD to configuration changes; and periodically sync to avoid skew in environments."
+description: "${PACKAGE_DESCRIPTION}"
 
-maintainer: Helmfile Contributors
-homepage: https://github.com/helmfile/helmfile
-license: MIT
+maintainer: ${PACKAGE_MAINTAINER}
+homepage: ${PACKAGE_HOMEPAGE}
+license: ${PACKAGE_LICENSE}
 
 disable_globbing: false