unkin/rpmbuilder
3
0
Fork 0
Code Issues 9 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix: support builds[].version metadata structure in update-gh #114

Merged
unkinben merged 1 commits from worktree-fix+update-gh-builds-version into master 2026-05-02 01:34:42 +10:00
Conversation 0 Commits 1 Files Changed 1
+21 -4
unkinben commented 2026-05-02 01:29:26 +10:00
Owner
Copy Link
Copy Source

Summary

  • The update-gh tool was reading metadata['version'] but all packages store version inside builds[].version entries
  • Fix reads builds[0].version as current version when builds are present
  • Fix updates all builds[].version and builds[].release entries when writing back

Test plan

  • Run tools/update-gh --all --dry-run and verify packages with builds-style metadata are no longer warned as "no version in metadata"
  • Run tools/update-gh --package <name> on a package with a known update and verify the builds entries are updated
## Summary - The `update-gh` tool was reading `metadata['version']` but all packages store version inside `builds[].version` entries - Fix reads `builds[0].version` as current version when builds are present - Fix updates all `builds[].version` and `builds[].release` entries when writing back ## Test plan - [ ] Run `tools/update-gh --all --dry-run` and verify packages with builds-style metadata are no longer warned as "no version in metadata" - [ ] Run `tools/update-gh --package <name>` on a package with a known update and verify the builds entries are updated
unkinben added 1 commit 2026-05-02 01:29:26 +10:00
fix: support builds[].version metadata structure in update-gh
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build-almalinux8 Pipeline was successful
Details
ci/woodpecker/pr/build-almalinux9 Pipeline was successful
Details
17fec6b015 
Packages use version/release fields nested inside builds[] entries
rather than at the top level of metadata.yaml.
unkinben merged commit 5a0b93c4b7 into master 2026-05-02 01:34:42 +10:00
unkinben deleted branch worktree-fix+update-gh-builds-version 2026-05-02 01:34:42 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) droneci unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/rpmbuilder#114
Delete Branch "worktree-fix+update-gh-builds-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?