unkin/terraform-artifactapi
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allowlist the iplocate DB patterns #10

Merged
benvin merged 1 commits from benvin/iplocate-patterns-allowlist into main 2026-07-24 00:15:36 +10:00
Conversation 0 Commits 1 Files Changed 1
+4
unkinben commented 2026-07-24 00:13:36 +10:00
Owner
Copy Link
Copy Source

Why

The iplocate patterns from #9 were added to mutable_patterns only. Live testing showed that is not the allowlist: requests to the iplocate paths return 403 'access denied', and so do existing mutable_patterns-only paths (branch archives, webadmin), while patterns entries (uv) return 200. So patterns is the allowlist; mutable_patterns only tags TTL.

Changes

  • Add the two iplocate patterns to patterns (the allowlist), keeping them in mutable_patterns so the daily-updated branch content is re-checked rather than cached immutably.

After apply

/api/v1/remote/github/iplocate/ip-address-databases/raw/main/ip-to-asn/ip-to-asn.csv.zip should return 200 (currently 403).

## Why The iplocate patterns from #9 were added to `mutable_patterns` only. Live testing showed that is not the allowlist: requests to the iplocate paths return 403 'access denied', and so do existing `mutable_patterns`-only paths (branch archives, webadmin), while `patterns` entries (uv) return 200. So `patterns` is the allowlist; `mutable_patterns` only tags TTL. ## Changes - Add the two iplocate patterns to `patterns` (the allowlist), keeping them in `mutable_patterns` so the daily-updated branch content is re-checked rather than cached immutably. ## After apply `/api/v1/remote/github/iplocate/ip-address-databases/raw/main/ip-to-asn/ip-to-asn.csv.zip` should return 200 (currently 403).
unkinben added 1 commit 2026-07-24 00:13:37 +10:00
Allowlist the iplocate DB patterns (add to patterns, not just mutable_patterns)
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/plan Pipeline was successful
Details
dd48e7a8e0 
The iplocate patterns were added to mutable_patterns only, which tags TTL but
does not allowlist — requests 403'd 'access denied'. Verified: existing
mutable_patterns-only paths (branch archives, webadmin) also 403, while patterns
entries (uv) return 200. Add the iplocate patterns to patterns (the allowlist),
keeping them in mutable_patterns so the daily-updated DB stays mutable.
benvin merged commit 70caa416d7 into main 2026-07-24 00:15:36 +10:00
benvin deleted branch benvin/iplocate-patterns-allowlist 2026-07-24 00:15:36 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/terraform-artifactapi#10
Delete Branch "benvin/iplocate-patterns-allowlist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?