Remove woodpecker module and fix branch protection dependency

- Remove woodpecker_repository module and provider (repos managed outside TF)
- Add removed block with destroy=false to drop state without destroying
- Add module.team to branch_protection depends_on to prevent race condition
- Add lifecycle ignore_changes for team permission (provider bug: API returns
  "none" but rejects it on write)

config/git.unkin.net/unkin/repository/argocd-apps.yaml

@@ -10,4 +10,3 @@ branch_protection:
       - "ci/woodpecker/pr/kubeconform"
     approval_whitelist_users:
       - "unkinben"
-woodpecker: true

config/git.unkin.net/unkin/repository/artifactapi.yaml

@@ -12,4 +12,3 @@ branch_protection:
       - "ci/woodpecker/pr/build"
     approval_whitelist_users:
       - "unkinben"
-woodpecker: true

config/git.unkin.net/unkin/repository/certmanager.yaml

@@ -9,4 +9,3 @@ branch_protection:
       - "unkinben"
     approval_whitelist_users:
       - "unkinben"
-woodpecker: true

config/git.unkin.net/unkin/repository/forgebot-skills.yaml

@@ -12,4 +12,3 @@ branch_protection:
       - "forgebot"
     merge_whitelist_teams:
       - "forgebot"
-woodpecker: true

config/git.unkin.net/unkin/repository/forgebot.yaml

@@ -14,4 +14,3 @@ branch_protection:
       - "forgebot"
     merge_whitelist_teams:
       - "forgebot"
-woodpecker: true

config/git.unkin.net/unkin/repository/node-lookup.yaml

@@ -12,4 +12,3 @@ branch_protection:
       - "ci/woodpecker/pr/unit-tests"
     approval_whitelist_users:
       - "unkinben"
-woodpecker: true

config/git.unkin.net/unkin/repository/puppet-prod.yaml

@@ -35,4 +35,3 @@ branch_protection:
       - "ci/woodpecker/pr/yamllint"
     approval_whitelist_teams:
       - "puppet"
-woodpecker: true

config/git.unkin.net/unkin/repository/puppet-r10k.yaml

@@ -13,4 +13,3 @@ branch_protection:
     approval_whitelist_teams:
       - "puppet"
     block_on_rejected_reviews: true
-woodpecker: true

config/git.unkin.net/unkin/repository/rpmbuilder.yaml

@@ -18,4 +18,3 @@ branch_protection:
     approval_whitelist_teams:
       - "rpmbuild"
     block_on_rejected_reviews: true
-woodpecker: true

config/git.unkin.net/unkin/repository/terraform-artifactapi.yaml

@@ -16,4 +16,3 @@ branch_protection:
       - "unkinben"
     approval_whitelist_teams:
       - "Owners"
-woodpecker: true

config/git.unkin.net/unkin/repository/terraform-git.yaml

@@ -1,7 +1,6 @@
 description: "Manage Gitea resources, teams, repos, and Woodpecker CI via Terraform"
 private: false
 default_branch: "main"
-woodpecker: true
 branch_protection:
   - rule_name: "main"
     enable_push: false

config/git.unkin.net/unkin/repository/terraform-provider-artifactapi.yaml

@@ -6,4 +6,3 @@ branch_protection:
     enable_push: false
     approval_whitelist_teams:
       - "Owners"
-woodpecker: true

config/git.unkin.net/unkin/repository/terraform-vault.yaml

@@ -16,4 +16,3 @@ branch_protection:
       - "unkinben"
     approval_whitelist_teams:
       - "Owners"
-woodpecker: true

modules/gitea_instance/imports.tf

@@ -198,58 +198,8 @@ import {
   id = "12"
 }
 
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/puppet-prod"].woodpecker_repository.this
-  id = "unkin/puppet-prod"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/puppet-r10k"].woodpecker_repository.this
-  id = "unkin/puppet-r10k"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/terraform-vault"].woodpecker_repository.this
-  id = "unkin/terraform-vault"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/rpmbuilder"].woodpecker_repository.this
-  id = "unkin/rpmbuilder"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/artifactapi"].woodpecker_repository.this
-  id = "unkin/artifactapi"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/argocd-apps"].woodpecker_repository.this
-  id = "unkin/argocd-apps"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/certmanager"].woodpecker_repository.this
-  id = "unkin/certmanager"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/node-lookup"].woodpecker_repository.this
-  id = "unkin/node-lookup"
-}
-
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/terraform-provider-artifactapi"].woodpecker_repository.this
-  id = "unkin/terraform-provider-artifactapi"
-}
-
 import {
   to = module.repository["git.unkin.net/unkin/terraform-git"].gitea_repository.this
   id = "144"
 }
 
-import {
-  to = module.woodpecker_repository["git.unkin.net/unkin/terraform-git"].woodpecker_repository.this
-  id = "unkin/terraform-git"
-}
-

modules/gitea_instance/main.tf

@@ -55,18 +55,12 @@ module "team" {
   depends_on = [module.organisation, module.repository]
 }
 
-module "woodpecker_repository" {
+removed {
-  source = "./modules/woodpecker_repository"
+  from = module.woodpecker_repository
 
-  for_each = {
+  lifecycle {
-    for k, v in var.repository : k => v
+    destroy = false
-    if try(v.woodpecker, false)
   }
-
-  full_name  = "${each.value.organisation}/${each.value.name}"
-  visibility = each.value.private ? "private" : "public"
-
-  depends_on = [module.repository]
 }
 
 module "branch_protection" {
@@ -95,7 +89,7 @@ module "branch_protection" {
   protected_file_patterns           = each.value.protected_file_patterns
   unprotected_file_patterns         = each.value.unprotected_file_patterns
 
-  depends_on = [module.repository]
+  depends_on = [module.repository, module.team]
 }
 
 # TODO: enable when deploy keys are needed

modules/gitea_instance/modules/team/main.tf

@@ -6,6 +6,10 @@ resource "gitea_team" "this" {
   include_all_repositories = var.include_all_repositories
   can_create_repos         = var.can_create_repos
   repositories             = var.repositories
+
+  lifecycle {
+    ignore_changes = [permission]
+  }
 }
 
 resource "gitea_team_members" "this" {

modules/gitea_instance/modules/woodpecker_repository/main.tf

@@ -1,4 +0,0 @@
-resource "woodpecker_repository" "this" {
-  full_name  = var.full_name
-  visibility = var.visibility
-}

modules/gitea_instance/modules/woodpecker_repository/terraform.tf

@@ -1,9 +0,0 @@
-terraform {
-  required_version = ">= 1.10"
-  required_providers {
-    woodpecker = {
-      source  = "Kichiyaki/woodpecker"
-      version = "0.5.0"
-    }
-  }
-}

modules/gitea_instance/modules/woodpecker_repository/variables.tf

@@ -1,8 +0,0 @@
-variable "full_name" {
-  type = string
-}
-
-variable "visibility" {
-  type    = string
-  default = "internal"
-}

modules/gitea_instance/variables.tf

@@ -32,7 +32,6 @@ variable "repository" {
     repo_template           = optional(bool)
     website                 = optional(string)
     autodetect_manual_merge = optional(bool)
-    woodpecker              = optional(bool, false)
   }))
   default = {}
 }