Merge pull request 'feat: support per-remote upstream timeouts' (#9) from benvin/remote-upstream-timeouts into main

Reviewed-on: #9

.woodpecker/release.yml

@@ -5,16 +5,15 @@ steps:
   - name: package
     image: git.unkin.net/unkin/almalinux9-gobuilder:20260606
     commands:
-      - apt-get update && apt-get install -y zip
       - make package VERSION=${CI_COMMIT_TAG}
 
   - name: upload
     image: git.unkin.net/unkin/almalinux9-base:20260606
     commands:
       - |
-        VERSION=$(echo ${CI_COMMIT_TAG} | sed 's/^v//')
+        VERSION=$$(echo ${CI_COMMIT_TAG} | sed 's/^v//')
-        FILE="terraform-provider-artifactapi_${VERSION}_linux_amd64.zip"
+        FILE="terraform-provider-artifactapi_$${VERSION}_linux_amd64.zip"
         curl -f -X PUT \
-        "https://artifactapi3.k8s.syd1.au.unkin.net/api/v2/remotes/terraform-unkin/files/unkin/artifactapi/$${FILE}" \
+          "https://artifactapi3.k8s.syd1.au.unkin.net/api/v2/remotes/terraform-unkin/files/unkin/artifactapi/$${FILE}" \
           -H "Content-Type: application/zip" \
           --data-binary @"$${FILE}"

Makefile

@@ -33,7 +33,7 @@ fmt: check-go
 
 package: build
 	cp $(BINARY) $(BINARY)_v$(INSTALL_VERSION)
-	zip $(ZIP) $(BINARY)_v$(INSTALL_VERSION)
+	python3 -c "import zipfile,sys; z=zipfile.ZipFile(sys.argv[1],'w',zipfile.ZIP_DEFLATED); z.write(sys.argv[2]); z.close()" $(ZIP) $(BINARY)_v$(INSTALL_VERSION)
 	rm $(BINARY)_v$(INSTALL_VERSION)
 
 clean:

README.md

@@ -82,6 +82,9 @@ Available resource types:
 | `quarantine_enabled` | No       | `false` | Enable quarantine for new artifacts                               |
 | `quarantine_days`    | No       | `3`     | Days to quarantine new artifacts                                  |
 | `stale_on_error`     | No       | `true`  | Serve stale cache when upstream is unreachable                    |
+| `upstream_dial_timeout` | No    | `0`     | Upstream TCP connect timeout in seconds (0 = server default)      |
+| `upstream_tls_timeout` | No     | `0`     | Upstream TLS handshake timeout in seconds (0 = server default)    |
+| `upstream_response_header_timeout` | No | `0` | Upstream response-header timeout in seconds (0 = server default) |
 
 #### Docker-specific Attributes
 

examples/resources/artifactapi_local_pypi/main.tf

@@ -0,0 +1,4 @@
+resource "artifactapi_local_pypi" "internal" {
+  name        = "pypi-internal"
+  description = "Internal PyPI package registry"
+}

examples/resources/artifactapi_local_rpm/main.tf

@@ -0,0 +1,4 @@
+resource "artifactapi_local_rpm" "internal" {
+  name        = "rpm-internal"
+  description = "Internal RPM package repository"
+}

internal/provider/datasource_remote.go

@@ -45,6 +45,10 @@ func (d *remoteDataSource) Schema(_ context.Context, _ datasource.SchemaRequest,
 			"stale_on_error":     schema.BoolAttribute{Computed: true},
 			"releases_remote":    schema.StringAttribute{Computed: true},
 			"managed_by":         schema.StringAttribute{Computed: true},
+
+			"upstream_dial_timeout":            schema.Int64Attribute{Computed: true},
+			"upstream_tls_timeout":             schema.Int64Attribute{Computed: true},
+			"upstream_response_header_timeout": schema.Int64Attribute{Computed: true},
 		},
 	}
 }
@@ -68,6 +72,10 @@ type remoteDataSourceModel struct {
 	StaleOnError      types.Bool   `tfsdk:"stale_on_error"`
 	ReleasesRemote    types.String `tfsdk:"releases_remote"`
 	ManagedBy         types.String `tfsdk:"managed_by"`
+
+	UpstreamDialTimeout           types.Int64 `tfsdk:"upstream_dial_timeout"`
+	UpstreamTLSTimeout            types.Int64 `tfsdk:"upstream_tls_timeout"`
+	UpstreamResponseHeaderTimeout types.Int64 `tfsdk:"upstream_response_header_timeout"`
 }
 
 func (d *remoteDataSource) Configure(_ context.Context, req datasource.ConfigureRequest, resp *datasource.ConfigureResponse) {
@@ -114,6 +122,10 @@ func (d *remoteDataSource) Read(ctx context.Context, req datasource.ReadRequest,
 		StaleOnError:      types.BoolValue(remote.StaleOnError),
 		ReleasesRemote:    types.StringValue(remote.ReleasesRemote),
 		ManagedBy:         types.StringValue(remote.ManagedBy),
+
+		UpstreamDialTimeout:           types.Int64Value(remote.UpstreamDialTimeout),
+		UpstreamTLSTimeout:            types.Int64Value(remote.UpstreamTLSTimeout),
+		UpstreamResponseHeaderTimeout: types.Int64Value(remote.UpstreamResponseHeaderTimeout),
 	}
 	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)
 }

internal/provider/models.go

@@ -22,6 +22,10 @@ type remoteAPI struct {
 	StaleOnError      bool     `json:"stale_on_error"`
 	ReleasesRemote    string   `json:"releases_remote,omitempty"`
 	ManagedBy         string   `json:"managed_by,omitempty"`
+
+	UpstreamDialTimeout           int64 `json:"upstream_dial_timeout"`
+	UpstreamTLSTimeout            int64 `json:"upstream_tls_timeout"`
+	UpstreamResponseHeaderTimeout int64 `json:"upstream_response_header_timeout"`
 }
 
 type virtualAPI struct {

internal/provider/provider.go

@@ -69,6 +69,8 @@ func (p *ArtifactAPIProvider) Resources(_ context.Context) []func() resource.Res
 		newRemoteResource("goproxy"),
 		NewVirtualResource,
 		NewLocalTerraformResource,
+		NewLocalPyPIResource,
+		NewLocalRPMResource,
 	}
 }
 

internal/provider/provider_test.go

@@ -66,8 +66,8 @@ func TestProvider_Resources(t *testing.T) {
 	p := &ArtifactAPIProvider{version: "1.0.0"}
 	resources := p.Resources(context.Background())
 
-	// 10 remote resource types + 1 virtual + 1 local_terraform = 12
+	// 10 remote resource types + 1 virtual + 1 local_terraform + 1 local_pypi + 1 local_rpm = 14
-	expectedCount := 12
+	expectedCount := 14
 	if len(resources) != expectedCount {
 		t.Fatalf("expected %d resources, got %d", expectedCount, len(resources))
 	}
@@ -108,6 +108,8 @@ func TestProvider_Resources_ContainsExpectedTypes(t *testing.T) {
 		"artifactapi_remote_goproxy",
 		"artifactapi_virtual",
 		"artifactapi_local_terraform",
+		"artifactapi_local_pypi",
+		"artifactapi_local_rpm",
 	}
 
 	for _, name := range expected {

internal/provider/resource_local_pypi.go

@@ -0,0 +1,164 @@
+package provider
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+)
+
+var (
+	_ resource.Resource                = &localPyPIResource{}
+	_ resource.ResourceWithImportState = &localPyPIResource{}
+)
+
+type localPyPIResource struct {
+	client *apiClient
+}
+
+type localPyPIResourceModel struct {
+	Name        types.String `tfsdk:"name"`
+	Description types.String `tfsdk:"description"`
+}
+
+func NewLocalPyPIResource() resource.Resource {
+	return &localPyPIResource{}
+}
+
+func (r *localPyPIResource) Metadata(_ context.Context, req resource.MetadataRequest, resp *resource.MetadataResponse) {
+	resp.TypeName = req.ProviderTypeName + "_local_pypi"
+}
+
+func (r *localPyPIResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) {
+	resp.Schema = schema.Schema{
+		Description: "Manages a local ArtifactAPI PyPI repository for hosting Python packages directly.",
+		Attributes: map[string]schema.Attribute{
+			"name": schema.StringAttribute{
+				Description: "Unique name of the local PyPI repository.",
+				Required:    true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.RequiresReplace(),
+				},
+			},
+			"description": schema.StringAttribute{
+				Description: "Human-readable description.",
+				Optional:    true,
+				Computed:    true,
+				Default:     stringdefault.StaticString(""),
+			},
+		},
+	}
+}
+
+func (r *localPyPIResource) Configure(_ context.Context, req resource.ConfigureRequest, resp *resource.ConfigureResponse) {
+	if req.ProviderData == nil {
+		return
+	}
+	client, ok := req.ProviderData.(*apiClient)
+	if !ok {
+		resp.Diagnostics.AddError("unexpected provider data type", fmt.Sprintf("got %T", req.ProviderData))
+		return
+	}
+	r.client = client
+}
+
+func (r *localPyPIResource) Create(ctx context.Context, req resource.CreateRequest, resp *resource.CreateResponse) {
+	var plan localPyPIResourceModel
+	resp.Diagnostics.Append(req.Plan.Get(ctx, &plan)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	api := localPyPIModelToAPI(plan)
+	api.ManagedBy = "terraform"
+
+	var created remoteAPI
+	if err := r.client.post(ctx, "/api/v2/remotes", api, &created); err != nil {
+		resp.Diagnostics.AddError("create local pypi failed", err.Error())
+		return
+	}
+
+	state := localPyPIAPIToModel(created)
+	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)
+}
+
+func (r *localPyPIResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
+	var state localPyPIResourceModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	var remote remoteAPI
+	err := r.client.get(ctx, "/api/v2/remotes/"+state.Name.ValueString(), &remote)
+	if err != nil {
+		if isNotFound(err) {
+			resp.State.RemoveResource(ctx)
+			return
+		}
+		resp.Diagnostics.AddError("read local pypi failed", err.Error())
+		return
+	}
+
+	newState := localPyPIAPIToModel(remote)
+	resp.Diagnostics.Append(resp.State.Set(ctx, newState)...)
+}
+
+func (r *localPyPIResource) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
+	var plan localPyPIResourceModel
+	resp.Diagnostics.Append(req.Plan.Get(ctx, &plan)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	api := localPyPIModelToAPI(plan)
+	api.ManagedBy = "terraform"
+
+	var updated remoteAPI
+	if err := r.client.put(ctx, "/api/v2/remotes/"+plan.Name.ValueString(), api, &updated); err != nil {
+		resp.Diagnostics.AddError("update local pypi failed", err.Error())
+		return
+	}
+
+	state := localPyPIAPIToModel(updated)
+	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)
+}
+
+func (r *localPyPIResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {
+	var state localPyPIResourceModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	if err := r.client.del(ctx, "/api/v2/remotes/"+state.Name.ValueString()); err != nil {
+		resp.Diagnostics.AddError("delete local pypi failed", err.Error())
+		return
+	}
+}
+
+func (r *localPyPIResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
+	resource.ImportStatePassthroughID(ctx, path.Root("name"), req, resp)
+}
+
+func localPyPIModelToAPI(m localPyPIResourceModel) remoteAPI {
+	return remoteAPI{
+		Name:        m.Name.ValueString(),
+		PackageType: "pypi",
+		RepoType:    "local",
+		Description: m.Description.ValueString(),
+	}
+}
+
+func localPyPIAPIToModel(api remoteAPI) localPyPIResourceModel {
+	return localPyPIResourceModel{
+		Name:        types.StringValue(api.Name),
+		Description: types.StringValue(api.Description),
+	}
+}

internal/provider/resource_local_pypi_test.go

@@ -0,0 +1,125 @@
+package provider
+
+import (
+	"context"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+)
+
+func TestLocalPyPIModelToAPI(t *testing.T) {
+	model := localPyPIResourceModel{
+		Name:        types.StringValue("pypi-internal"),
+		Description: types.StringValue("Internal PyPI registry"),
+	}
+
+	api := localPyPIModelToAPI(model)
+
+	if api.Name != "pypi-internal" {
+		t.Errorf("Name: expected pypi-internal, got %s", api.Name)
+	}
+	if api.PackageType != "pypi" {
+		t.Errorf("PackageType: expected pypi, got %s", api.PackageType)
+	}
+	if api.RepoType != "local" {
+		t.Errorf("RepoType: expected local, got %s", api.RepoType)
+	}
+	if api.Description != "Internal PyPI registry" {
+		t.Errorf("Description: expected 'Internal PyPI registry', got %s", api.Description)
+	}
+}
+
+func TestLocalPyPIModelToAPI_EmptyDescription(t *testing.T) {
+	model := localPyPIResourceModel{
+		Name:        types.StringValue("pypi-empty"),
+		Description: types.StringValue(""),
+	}
+
+	api := localPyPIModelToAPI(model)
+
+	if api.Name != "pypi-empty" {
+		t.Errorf("Name: expected pypi-empty, got %s", api.Name)
+	}
+	if api.Description != "" {
+		t.Errorf("Description: expected empty string, got %s", api.Description)
+	}
+	if api.PackageType != "pypi" {
+		t.Errorf("PackageType: expected pypi, got %s", api.PackageType)
+	}
+	if api.RepoType != "local" {
+		t.Errorf("RepoType: expected local, got %s", api.RepoType)
+	}
+}
+
+func TestLocalPyPIAPIToModel(t *testing.T) {
+	api := remoteAPI{
+		Name:        "pypi-internal",
+		PackageType: "pypi",
+		RepoType:    "local",
+		Description: "Internal PyPI registry",
+		ManagedBy:   "terraform",
+	}
+
+	model := localPyPIAPIToModel(api)
+
+	if model.Name.ValueString() != "pypi-internal" {
+		t.Errorf("Name: expected pypi-internal, got %s", model.Name.ValueString())
+	}
+	if model.Description.ValueString() != "Internal PyPI registry" {
+		t.Errorf("Description: expected 'Internal PyPI registry', got %s", model.Description.ValueString())
+	}
+}
+
+func TestLocalPyPIRoundTrip(t *testing.T) {
+	original := localPyPIResourceModel{
+		Name:        types.StringValue("roundtrip-pypi"),
+		Description: types.StringValue("Round trip test"),
+	}
+
+	api := localPyPIModelToAPI(original)
+	result := localPyPIAPIToModel(api)
+
+	if result.Name.ValueString() != original.Name.ValueString() {
+		t.Errorf("Name: expected %s, got %s", original.Name.ValueString(), result.Name.ValueString())
+	}
+	if result.Description.ValueString() != original.Description.ValueString() {
+		t.Errorf("Description: expected %s, got %s", original.Description.ValueString(), result.Description.ValueString())
+	}
+}
+
+func TestLocalPyPIResource_Metadata(t *testing.T) {
+	r := NewLocalPyPIResource()
+	req := resource.MetadataRequest{ProviderTypeName: "artifactapi"}
+	var resp resource.MetadataResponse
+	r.Metadata(context.Background(), req, &resp)
+	if resp.TypeName != "artifactapi_local_pypi" {
+		t.Errorf("expected artifactapi_local_pypi, got %s", resp.TypeName)
+	}
+}
+
+func TestLocalPyPIResource_Schema(t *testing.T) {
+	r := NewLocalPyPIResource()
+	req := resource.SchemaRequest{}
+	var resp resource.SchemaResponse
+	r.Schema(context.Background(), req, &resp)
+
+	expectedAttrs := []string{"name", "description"}
+	for _, attr := range expectedAttrs {
+		if _, ok := resp.Schema.Attributes[attr]; !ok {
+			t.Errorf("missing expected attribute: %s", attr)
+		}
+	}
+
+	if len(resp.Schema.Attributes) != len(expectedAttrs) {
+		t.Errorf("expected %d attributes, got %d", len(expectedAttrs), len(resp.Schema.Attributes))
+	}
+}
+
+func TestNewLocalPyPIResource_Type(t *testing.T) {
+	r := NewLocalPyPIResource()
+	_, ok := r.(*localPyPIResource)
+	if !ok {
+		t.Error("expected *localPyPIResource")
+	}
+}

internal/provider/resource_local_rpm.go

@@ -0,0 +1,164 @@
+package provider
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+)
+
+var (
+	_ resource.Resource                = &localRPMResource{}
+	_ resource.ResourceWithImportState = &localRPMResource{}
+)
+
+type localRPMResource struct {
+	client *apiClient
+}
+
+type localRPMResourceModel struct {
+	Name        types.String `tfsdk:"name"`
+	Description types.String `tfsdk:"description"`
+}
+
+func NewLocalRPMResource() resource.Resource {
+	return &localRPMResource{}
+}
+
+func (r *localRPMResource) Metadata(_ context.Context, req resource.MetadataRequest, resp *resource.MetadataResponse) {
+	resp.TypeName = req.ProviderTypeName + "_local_rpm"
+}
+
+func (r *localRPMResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) {
+	resp.Schema = schema.Schema{
+		Description: "Manages a local ArtifactAPI RPM repository for hosting RPM packages directly.",
+		Attributes: map[string]schema.Attribute{
+			"name": schema.StringAttribute{
+				Description: "Unique name of the local RPM repository.",
+				Required:    true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.RequiresReplace(),
+				},
+			},
+			"description": schema.StringAttribute{
+				Description: "Human-readable description.",
+				Optional:    true,
+				Computed:    true,
+				Default:     stringdefault.StaticString(""),
+			},
+		},
+	}
+}
+
+func (r *localRPMResource) Configure(_ context.Context, req resource.ConfigureRequest, resp *resource.ConfigureResponse) {
+	if req.ProviderData == nil {
+		return
+	}
+	client, ok := req.ProviderData.(*apiClient)
+	if !ok {
+		resp.Diagnostics.AddError("unexpected provider data type", fmt.Sprintf("got %T", req.ProviderData))
+		return
+	}
+	r.client = client
+}
+
+func (r *localRPMResource) Create(ctx context.Context, req resource.CreateRequest, resp *resource.CreateResponse) {
+	var plan localRPMResourceModel
+	resp.Diagnostics.Append(req.Plan.Get(ctx, &plan)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	api := localRPMModelToAPI(plan)
+	api.ManagedBy = "terraform"
+
+	var created remoteAPI
+	if err := r.client.post(ctx, "/api/v2/remotes", api, &created); err != nil {
+		resp.Diagnostics.AddError("create local rpm failed", err.Error())
+		return
+	}
+
+	state := localRPMAPIToModel(created)
+	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)
+}
+
+func (r *localRPMResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
+	var state localRPMResourceModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	var remote remoteAPI
+	err := r.client.get(ctx, "/api/v2/remotes/"+state.Name.ValueString(), &remote)
+	if err != nil {
+		if isNotFound(err) {
+			resp.State.RemoveResource(ctx)
+			return
+		}
+		resp.Diagnostics.AddError("read local rpm failed", err.Error())
+		return
+	}
+
+	newState := localRPMAPIToModel(remote)
+	resp.Diagnostics.Append(resp.State.Set(ctx, newState)...)
+}
+
+func (r *localRPMResource) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
+	var plan localRPMResourceModel
+	resp.Diagnostics.Append(req.Plan.Get(ctx, &plan)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	api := localRPMModelToAPI(plan)
+	api.ManagedBy = "terraform"
+
+	var updated remoteAPI
+	if err := r.client.put(ctx, "/api/v2/remotes/"+plan.Name.ValueString(), api, &updated); err != nil {
+		resp.Diagnostics.AddError("update local rpm failed", err.Error())
+		return
+	}
+
+	state := localRPMAPIToModel(updated)
+	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)
+}
+
+func (r *localRPMResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {
+	var state localRPMResourceModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	if err := r.client.del(ctx, "/api/v2/remotes/"+state.Name.ValueString()); err != nil {
+		resp.Diagnostics.AddError("delete local rpm failed", err.Error())
+		return
+	}
+}
+
+func (r *localRPMResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
+	resource.ImportStatePassthroughID(ctx, path.Root("name"), req, resp)
+}
+
+func localRPMModelToAPI(m localRPMResourceModel) remoteAPI {
+	return remoteAPI{
+		Name:        m.Name.ValueString(),
+		PackageType: "rpm",
+		RepoType:    "local",
+		Description: m.Description.ValueString(),
+	}
+}
+
+func localRPMAPIToModel(api remoteAPI) localRPMResourceModel {
+	return localRPMResourceModel{
+		Name:        types.StringValue(api.Name),
+		Description: types.StringValue(api.Description),
+	}
+}

internal/provider/resource_local_rpm_test.go

@@ -0,0 +1,125 @@
+package provider
+
+import (
+	"context"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+)
+
+func TestLocalRPMModelToAPI(t *testing.T) {
+	model := localRPMResourceModel{
+		Name:        types.StringValue("rpm-internal"),
+		Description: types.StringValue("Internal RPM repository"),
+	}
+
+	api := localRPMModelToAPI(model)
+
+	if api.Name != "rpm-internal" {
+		t.Errorf("Name: expected rpm-internal, got %s", api.Name)
+	}
+	if api.PackageType != "rpm" {
+		t.Errorf("PackageType: expected rpm, got %s", api.PackageType)
+	}
+	if api.RepoType != "local" {
+		t.Errorf("RepoType: expected local, got %s", api.RepoType)
+	}
+	if api.Description != "Internal RPM repository" {
+		t.Errorf("Description: expected 'Internal RPM repository', got %s", api.Description)
+	}
+}
+
+func TestLocalRPMModelToAPI_EmptyDescription(t *testing.T) {
+	model := localRPMResourceModel{
+		Name:        types.StringValue("rpm-empty"),
+		Description: types.StringValue(""),
+	}
+
+	api := localRPMModelToAPI(model)
+
+	if api.Name != "rpm-empty" {
+		t.Errorf("Name: expected rpm-empty, got %s", api.Name)
+	}
+	if api.Description != "" {
+		t.Errorf("Description: expected empty string, got %s", api.Description)
+	}
+	if api.PackageType != "rpm" {
+		t.Errorf("PackageType: expected rpm, got %s", api.PackageType)
+	}
+	if api.RepoType != "local" {
+		t.Errorf("RepoType: expected local, got %s", api.RepoType)
+	}
+}
+
+func TestLocalRPMAPIToModel(t *testing.T) {
+	api := remoteAPI{
+		Name:        "rpm-internal",
+		PackageType: "rpm",
+		RepoType:    "local",
+		Description: "Internal RPM repository",
+		ManagedBy:   "terraform",
+	}
+
+	model := localRPMAPIToModel(api)
+
+	if model.Name.ValueString() != "rpm-internal" {
+		t.Errorf("Name: expected rpm-internal, got %s", model.Name.ValueString())
+	}
+	if model.Description.ValueString() != "Internal RPM repository" {
+		t.Errorf("Description: expected 'Internal RPM repository', got %s", model.Description.ValueString())
+	}
+}
+
+func TestLocalRPMRoundTrip(t *testing.T) {
+	original := localRPMResourceModel{
+		Name:        types.StringValue("roundtrip-rpm"),
+		Description: types.StringValue("Round trip test"),
+	}
+
+	api := localRPMModelToAPI(original)
+	result := localRPMAPIToModel(api)
+
+	if result.Name.ValueString() != original.Name.ValueString() {
+		t.Errorf("Name: expected %s, got %s", original.Name.ValueString(), result.Name.ValueString())
+	}
+	if result.Description.ValueString() != original.Description.ValueString() {
+		t.Errorf("Description: expected %s, got %s", original.Description.ValueString(), result.Description.ValueString())
+	}
+}
+
+func TestLocalRPMResource_Metadata(t *testing.T) {
+	r := NewLocalRPMResource()
+	req := resource.MetadataRequest{ProviderTypeName: "artifactapi"}
+	var resp resource.MetadataResponse
+	r.Metadata(context.Background(), req, &resp)
+	if resp.TypeName != "artifactapi_local_rpm" {
+		t.Errorf("expected artifactapi_local_rpm, got %s", resp.TypeName)
+	}
+}
+
+func TestLocalRPMResource_Schema(t *testing.T) {
+	r := NewLocalRPMResource()
+	req := resource.SchemaRequest{}
+	var resp resource.SchemaResponse
+	r.Schema(context.Background(), req, &resp)
+
+	expectedAttrs := []string{"name", "description"}
+	for _, attr := range expectedAttrs {
+		if _, ok := resp.Schema.Attributes[attr]; !ok {
+			t.Errorf("missing expected attribute: %s", attr)
+		}
+	}
+
+	if len(resp.Schema.Attributes) != len(expectedAttrs) {
+		t.Errorf("expected %d attributes, got %d", len(expectedAttrs), len(resp.Schema.Attributes))
+	}
+}
+
+func TestNewLocalRPMResource_Type(t *testing.T) {
+	r := NewLocalRPMResource()
+	_, ok := r.(*localRPMResource)
+	if !ok {
+		t.Error("expected *localRPMResource")
+	}
+}

internal/provider/resource_remote.go

@@ -44,6 +44,10 @@ type remoteResourceModel struct {
 	QuarantineDays    types.Int64  `tfsdk:"quarantine_days"`
 	StaleOnError      types.Bool   `tfsdk:"stale_on_error"`
 	ReleasesRemote    types.String `tfsdk:"releases_remote"`
+
+	UpstreamDialTimeout           types.Int64 `tfsdk:"upstream_dial_timeout"`
+	UpstreamTLSTimeout            types.Int64 `tfsdk:"upstream_tls_timeout"`
+	UpstreamResponseHeaderTimeout types.Int64 `tfsdk:"upstream_response_header_timeout"`
 }
 
 func newRemoteResource(packageType string) func() resource.Resource {
@@ -144,6 +148,18 @@ func (r *remoteResource) Schema(_ context.Context, _ resource.SchemaRequest, res
 			Description: "Name of the CDN remote for download URL rewriting (terraform only).",
 			Optional:    true, Computed: true, Default: stringdefault.StaticString(""),
 		},
+		"upstream_dial_timeout": schema.Int64Attribute{
+			Description: "Upstream TCP connect timeout in seconds (0 = server default).",
+			Optional:    true, Computed: true, Default: int64default.StaticInt64(0),
+		},
+		"upstream_tls_timeout": schema.Int64Attribute{
+			Description: "Upstream TLS handshake timeout in seconds (0 = server default).",
+			Optional:    true, Computed: true, Default: int64default.StaticInt64(0),
+		},
+		"upstream_response_header_timeout": schema.Int64Attribute{
+			Description: "Upstream response-header timeout in seconds (0 = server default).",
+			Optional:    true, Computed: true, Default: int64default.StaticInt64(0),
+		},
 	}
 
 	resp.Schema = schema.Schema{
@@ -268,6 +284,10 @@ func (r *remoteResource) modelToAPI(ctx context.Context, m remoteResourceModel)
 		QuarantineEnabled: m.QuarantineEnabled.ValueBool(),
 		QuarantineDays:    m.QuarantineDays.ValueInt64(),
 		StaleOnError:      m.StaleOnError.ValueBool(),
+
+		UpstreamDialTimeout:           m.UpstreamDialTimeout.ValueInt64(),
+		UpstreamTLSTimeout:            m.UpstreamTLSTimeout.ValueInt64(),
+		UpstreamResponseHeaderTimeout: m.UpstreamResponseHeaderTimeout.ValueInt64(),
 	}
 	api.Patterns = listToStrings(ctx, m.Patterns)
 	api.Blocklist = listToStrings(ctx, m.Blocklist)
@@ -299,6 +319,10 @@ func (r *remoteResource) apiToModel(ctx context.Context, api remoteAPI) remoteRe
 		BanTagsEnabled:    types.BoolValue(api.BanTagsEnabled),
 		BanTags:           stringsToList(ctx, api.BanTags),
 		ReleasesRemote:    types.StringValue(api.ReleasesRemote),
+
+		UpstreamDialTimeout:           types.Int64Value(api.UpstreamDialTimeout),
+		UpstreamTLSTimeout:            types.Int64Value(api.UpstreamTLSTimeout),
+		UpstreamResponseHeaderTimeout: types.Int64Value(api.UpstreamResponseHeaderTimeout),
 	}
 	return m
 }

internal/provider/resource_remote_test.go

@@ -31,10 +31,18 @@ func TestModelToAPI_FullFields(t *testing.T) {
 		QuarantineDays:    types.Int64Value(7),
 		StaleOnError:      types.BoolValue(false),
 		ReleasesRemote:    types.StringValue("cdn-remote"),
+
+		UpstreamDialTimeout:           types.Int64Value(3),
+		UpstreamTLSTimeout:            types.Int64Value(4),
+		UpstreamResponseHeaderTimeout: types.Int64Value(5),
 	}
 
 	api := r.modelToAPI(ctx, model)
 
+	if api.UpstreamDialTimeout != 3 || api.UpstreamTLSTimeout != 4 || api.UpstreamResponseHeaderTimeout != 5 {
+		t.Errorf("upstream timeouts: got %d/%d/%d, want 3/4/5",
+			api.UpstreamDialTimeout, api.UpstreamTLSTimeout, api.UpstreamResponseHeaderTimeout)
+	}
 	if api.Name != "my-remote" {
 		t.Errorf("Name: expected my-remote, got %s", api.Name)
 	}
@@ -211,10 +219,22 @@ func TestAPIToModel_FullFields(t *testing.T) {
 		StaleOnError:      false,
 		ReleasesRemote:    "cdn-remote",
 		ManagedBy:         "terraform",
+
+		UpstreamDialTimeout:           3,
+		UpstreamTLSTimeout:            4,
+		UpstreamResponseHeaderTimeout: 5,
 	}
 
 	model := r.apiToModel(ctx, api)
 
+	if model.UpstreamDialTimeout.ValueInt64() != 3 ||
+		model.UpstreamTLSTimeout.ValueInt64() != 4 ||
+		model.UpstreamResponseHeaderTimeout.ValueInt64() != 5 {
+		t.Errorf("upstream timeouts: got %d/%d/%d, want 3/4/5",
+			model.UpstreamDialTimeout.ValueInt64(),
+			model.UpstreamTLSTimeout.ValueInt64(),
+			model.UpstreamResponseHeaderTimeout.ValueInt64())
+	}
 	if model.Name.ValueString() != "my-remote" {
 		t.Errorf("Name: expected my-remote, got %s", model.Name.ValueString())
 	}
@@ -324,12 +344,24 @@ func TestModelToAPI_RoundTrip(t *testing.T) {
 		QuarantineDays:    3,
 		StaleOnError:      true,
 		ReleasesRemote:    "",
+
+		UpstreamDialTimeout:           5,
+		UpstreamTLSTimeout:            0,
+		UpstreamResponseHeaderTimeout: 45,
 	}
 
 	// API -> Model -> API round-trip
 	model := r.apiToModel(ctx, original)
 	result := r.modelToAPI(ctx, model)
 
+	if result.UpstreamDialTimeout != original.UpstreamDialTimeout ||
+		result.UpstreamTLSTimeout != original.UpstreamTLSTimeout ||
+		result.UpstreamResponseHeaderTimeout != original.UpstreamResponseHeaderTimeout {
+		t.Errorf("upstream timeouts round-trip: got %d/%d/%d, want %d/%d/%d",
+			result.UpstreamDialTimeout, result.UpstreamTLSTimeout, result.UpstreamResponseHeaderTimeout,
+			original.UpstreamDialTimeout, original.UpstreamTLSTimeout, original.UpstreamResponseHeaderTimeout)
+	}
+
 	if result.Name != original.Name {
 		t.Errorf("Name: expected %s, got %s", original.Name, result.Name)
 	}
@@ -405,6 +437,7 @@ func TestRemoteResource_Schema(t *testing.T) {
 		"ban_tags_enabled", "ban_tags",
 		"quarantine_enabled", "quarantine_days",
 		"stale_on_error", "releases_remote",
+		"upstream_dial_timeout", "upstream_tls_timeout", "upstream_response_header_timeout",
 	}
 
 	for _, attr := range expectedAttrs {