unkin/terraform-provider-binarylane
4
0
Fork 0
forked from mirrors/terraform-provider-binarylane
Code Pull Requests Activity

Allow server firewall rules without destination_ports #3

Merged
benvin merged 6 commits from benvin/firewall-optional-ports into main 2026-10-12 21:18:30 +11:00
Conversation 1 Commits 6 Files Changed 9
+765 -1
unkin-agent commented 2026-10-12 00:47:07 +11:00
Member
Copy Link
Copy Source

Omitting destination_ports (all ports, e.g. ICMP or allow-all from a source) fails apply: the computed attribute is planned unknown and written to state as-is, and reading back a rule with null ports panics. Fixes upstream oscarhermoso/terraform-provider-binarylane#91.

  • resolve unknown destination_ports to null before saving state on create/update
  • read null API ports as a typed null list
  • add a unit test covering create, update and read with omitted ports
Omitting `destination_ports` (all ports, e.g. ICMP or allow-all from a source) fails apply: the computed attribute is planned unknown and written to state as-is, and reading back a rule with null ports panics. Fixes upstream oscarhermoso/terraform-provider-binarylane#91. - resolve unknown `destination_ports` to null before saving state on create/update - read null API ports as a typed null list - add a unit test covering create, update and read with omitted ports
unkin-agent commented 2026-10-12 00:49:21 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin changed target branch from benvin/estate-ci to main 2026-10-12 21:16:56 +11:00
benvin added 1 commit 2026-10-12 21:16:56 +11:00
Allow server firewall rules without destination_ports
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
00b6fae313
benvin merged commit f659cfcd25 into main 2026-10-12 21:18:30 +11:00
benvin deleted branch benvin/firewall-optional-ports 2026-10-12 21:18:32 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/terraform-provider-binarylane#3
Delete Branch "benvin/firewall-optional-ports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?