unkin/terraform-vault
3
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ghp agent role (missing installation_id; unblock apply) #131

Merged
benvin merged 1 commits from benvin/remove-ghp-role-for-now into master 2026-08-20 00:05:14 +10:00
Conversation 0 Commits 1 Files Changed 1
-15
unkin-agent commented 2026-08-20 00:00:44 +10:00
Member
Copy Link
Copy Source

Why

The ghp agent role fails at apply with Code: 400 — installation_id is required for agent tokens. The role config config/ghp_secret_backend_role/ghp/agent.yaml carries only a placeholder installation_id, so the role can never be created. This failure blocks the terraform-vault master apply, which in turn blocks the arrstack #127 apply.

Remove the ghp role for now so the master apply goes green. The ghp secret backend itself is retained (it now mounts and configures cleanly). The role can be re-added once a real installation_id is provided.

Because the role never successfully created (apply failed on it), removing it is non-destructive — it is not in state, so no destroy is introduced.

Changes

  • Delete config/ghp_secret_backend_role/ghp/agent.yaml, which empties the ghp_secret_backend_role for_each map so no role instance (and no downstream ghp_secret_role) is planned.

Backend config/ghp_secret_backend/ghp.yaml and all other config are unchanged. Net diff vs master is exactly this one file deletion.

## Why The `ghp` agent role fails at apply with `Code: 400 — installation_id is required for agent tokens`. The role config `config/ghp_secret_backend_role/ghp/agent.yaml` carries only a placeholder `installation_id`, so the role can never be created. This failure blocks the terraform-vault master apply, which in turn blocks the arrstack #127 apply. Remove the ghp role for now so the master apply goes green. The `ghp` secret backend itself is retained (it now mounts and configures cleanly). The role can be re-added once a real `installation_id` is provided. Because the role never successfully created (apply failed on it), removing it is non-destructive — it is not in state, so no destroy is introduced. ## Changes - Delete `config/ghp_secret_backend_role/ghp/agent.yaml`, which empties the `ghp_secret_backend_role` for_each map so no role instance (and no downstream ghp_secret_role) is planned. Backend `config/ghp_secret_backend/ghp.yaml` and all other config are unchanged. Net diff vs master is exactly this one file deletion.
unkin-agent added 1 commit 2026-08-20 00:00:44 +10:00
Remove ghp agent role (missing installation_id; unblock apply)
ci/woodpecker/pr/plan Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
f26cb6aca8 
The ghp agent role fails at apply with `installation_id is required for
agent tokens` because config/ghp_secret_backend_role/ghp/agent.yaml carries a
placeholder installation_id. Remove the role for now so the master apply goes
green and does not block the arrstack #127 apply. The ghp backend is retained;
re-add the role once a real installation_id is available.

- Delete config/ghp_secret_backend_role/ghp/agent.yaml (empties the
  ghp_secret_backend_role for_each map).
benvin merged commit 08ec281b1d into master 2026-08-20 00:05:14 +10:00
benvin deleted branch benvin/remove-ghp-role-for-now 2026-08-20 00:05:14 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/terraform-vault#131
Delete Branch "benvin/remove-ghp-role-for-now"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?