unkin/tomswall
4
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Fix large-batch netlink errors and revert failed try applies #30

Merged
benvin merged 1 commits from benvin/try-apply-error into main 2026-10-04 15:40:08 +11:00
Conversation 1 Commits 1 Files Changed 5
+154 -7
unkin-agent commented 2026-10-04 15:34:13 +11:00
Member
Copy Link
Copy Source

Large applies fail at the netlink socket: past ~300 rules the kernel commits the batch but drops ACKs beyond the receive buffer (ENOBUFS), and larger batches exceed the send buffer (EMSGSIZE). Separately, a failed try apply discarded its snapshot without reverting, leaving a possibly committed, unconfirmed ruleset with no pending revert.

  • raise netlink send/receive buffers to 64MiB (FORCE when permitted, sysctl-capped otherwise)
  • restore the snapshot when a try apply fails; on restore failure keep the snapshot and revert timer
Large applies fail at the netlink socket: past ~300 rules the kernel commits the batch but drops ACKs beyond the receive buffer (ENOBUFS), and larger batches exceed the send buffer (EMSGSIZE). Separately, a failed try apply discarded its snapshot without reverting, leaving a possibly committed, unconfirmed ruleset with no pending revert. - raise netlink send/receive buffers to 64MiB (FORCE when permitted, sysctl-capped otherwise) - restore the snapshot when a try apply fails; on restore failure keep the snapshot and revert timer
unkin-agent added 1 commit 2026-10-04 15:34:14 +11:00
Raise netlink buffers for large batches; restore snapshot when try apply fails
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
fe689e99ed
unkin-agent commented 2026-10-04 15:35:04 +11:00
Author
Member
Copy Link
Copy Source

No findings.

No findings.
benvin merged commit 11fafc0e6a into main 2026-10-04 15:40:08 +11:00
benvin deleted branch benvin/try-apply-error 2026-10-04 15:40:08 +11:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benvin (BenVincent) unkin-agent (Unkin Agent) unkinben (Ben Vincent)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unkin/tomswall#30
Delete Branch "benvin/try-apply-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?