From bffbd45204f0b4c0ef8977f652450d201816d1cf Mon Sep 17 00:00:00 2001 From: Ben Vincent Date: Sun, 26 Jul 2026 23:49:13 +1000 Subject: [PATCH] Fix errcheck lint failures in runList MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit golangci-lint (errcheck) in CI flagged the fmt.Fprintf calls in vctl's runList as unchecked return values — writes to an arbitrary io.Writer are not on errcheck's default exclude list (unlike os.Stdout/os.Stderr). - discard the fmt.Fprintf return values in runList with '_, _ =', matching the existing convention used elsewhere in the tree Claude-Session: https://claude.ai/code/session_015ur3i7D2azsMAWTSVABApv --- vctl/main.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vctl/main.go b/vctl/main.go index 5fd1ae3..bd106ea 100644 --- a/vctl/main.go +++ b/vctl/main.go @@ -241,13 +241,13 @@ func runList(w io.Writer) error { } names := cfg.ContextNames() if len(names) == 0 { - fmt.Fprintf(w, "no contexts configured in %s\n", cfg.Path()) + _, _ = fmt.Fprintf(w, "no contexts configured in %s\n", cfg.Path()) return nil } for _, name := range names { rc, err := cfg.Resolve(name) if err != nil { - fmt.Fprintf(w, "%-24s %v\n", name, err) + _, _ = fmt.Fprintf(w, "%-24s %v\n", name, err) continue } status := "no token" @@ -263,7 +263,7 @@ func runList(w io.Writer) error { status = "token cached" } } - fmt.Fprintf(w, "%-24s %-40s %s\n", name, rc.Address, status) + _, _ = fmt.Fprintf(w, "%-24s %-40s %s\n", name, rc.Address, status) } return nil }