Fix Rubocop offenses

This commit is contained in:
Cédric Defortis 2017-05-02 11:57:57 +02:00 committed by Cedric DEFORTIS
parent d0dc06d4ca
commit 3ff354877b
2 changed files with 24 additions and 23 deletions

View File

@ -63,6 +63,10 @@ Style/RedundantSelf:
Metrics/MethodLength: Metrics/MethodLength:
Enabled: false Enabled: false
# DISABLED
Metrics/BlockLength:
Enabled: false
# DISABLED - not useful # DISABLED - not useful
Style/WhileUntilModifier: Style/WhileUntilModifier:
Enabled: false Enabled: false
@ -72,7 +76,7 @@ Lint/AmbiguousRegexpLiteral:
Enabled: false Enabled: false
# DISABLED # DISABLED
Lint/Eval: Security/Eval:
Enabled: false Enabled: false
# DISABLED # DISABLED
@ -211,16 +215,13 @@ Style/SpaceInsideParens:
Style/LeadingCommentSpace: Style/LeadingCommentSpace:
Enabled: false Enabled: false
Style/SingleSpaceBeforeFirstArg:
Enabled: false
Style/SpaceAfterColon: Style/SpaceAfterColon:
Enabled: false Enabled: false
Style/SpaceAfterComma: Style/SpaceAfterComma:
Enabled: false Enabled: false
Style/SpaceAfterControlKeyword: Style/SpaceAroundKeyword:
Enabled: false Enabled: false
Style/SpaceAfterMethodName: Style/SpaceAfterMethodName:
@ -268,8 +269,8 @@ Style/Documentation:
Style/DefWithParentheses: Style/DefWithParentheses:
Enabled: false Enabled: false
Style/DeprecatedHashMethods: #Style/DeprecatedHashMethods:
Enabled: false # Enabled: false
Style/DotPosition: Style/DotPosition:
Enabled: false Enabled: false
@ -308,7 +309,7 @@ Style/EmptyLiteral:
Metrics/LineLength: Metrics/LineLength:
Enabled: false Enabled: false
Style/MethodCallParentheses: Style/MethodCallWithoutArgsParentheses:
Enabled: false Enabled: false
Style/MethodDefParentheses: Style/MethodDefParentheses:
@ -323,7 +324,7 @@ Style/TrailingWhitespace:
Style/StringLiterals: Style/StringLiterals:
Enabled: false Enabled: false
Style/TrailingComma: Style/TrailingCommaInLiteral:
Enabled: false Enabled: false
Style/GlobalVars: Style/GlobalVars:
@ -464,7 +465,7 @@ Metrics/ParameterLists:
Lint/RequireParentheses: Lint/RequireParentheses:
Enabled: false Enabled: false
Lint/SpaceBeforeFirstArg: Style/SpaceBeforeFirstArg:
Enabled: false Enabled: false
Style/ModuleFunction: Style/ModuleFunction:

26
Gemfile
View File

@ -2,39 +2,39 @@ source ENV['GEM_SOURCE'] || "https://rubygems.org"
group :test do group :test do
puppetversion = ENV.key?('PUPPET_VERSION') ? "= #{ENV['PUPPET_VERSION']}" : ['>= 4.9'] puppetversion = ENV.key?('PUPPET_VERSION') ? "= #{ENV['PUPPET_VERSION']}" : ['>= 4.9']
gem "rake" gem "metadata-json-lint"
gem "puppet", puppetversion gem "puppet", puppetversion
gem "puppetlabs_spec_helper"
gem "rake"
gem "rspec", '> 3.4.0' gem "rspec", '> 3.4.0'
gem "rspec-puppet" gem "rspec-puppet"
gem "puppetlabs_spec_helper"
gem "metadata-json-lint"
gem "rspec-puppet-facts" gem "rspec-puppet-facts"
gem 'rubocop', '0.42.0' gem 'rubocop'
gem 'simplecov', '>= 0.11.0' gem 'simplecov', '>= 0.11.0'
gem 'simplecov-console' gem 'simplecov-console'
gem "puppet-lint-absolute_classname-check" gem "puppet-lint-absolute_classname-check"
gem "puppet-lint-leading_zero-check"
gem "puppet-lint-trailing_comma-check"
gem "puppet-lint-version_comparison-check"
gem "puppet-lint-classes_and_types_beginning_with_digits-check" gem "puppet-lint-classes_and_types_beginning_with_digits-check"
gem "puppet-lint-unquoted_string-check" gem "puppet-lint-leading_zero-check"
gem 'puppet-lint-resource_reference_syntax' gem 'puppet-lint-resource_reference_syntax'
gem "puppet-lint-trailing_comma-check"
gem "puppet-lint-unquoted_string-check"
gem "puppet-lint-version_comparison-check"
gem 'json_pure', '<= 2.0.1' if RUBY_VERSION < '2.0.0' gem 'json_pure', '<= 2.0.1' if RUBY_VERSION < '2.0.0'
end end
group :development do group :development do
gem "travis" if RUBY_VERSION >= '2.1.0'
gem "travis-lint" if RUBY_VERSION >= '2.1.0'
gem "puppet-blacksmith"
gem "guard-rake" if RUBY_VERSION >= '2.2.5' # per dependency https://rubygems.org/gems/ruby_dep gem "guard-rake" if RUBY_VERSION >= '2.2.5' # per dependency https://rubygems.org/gems/ruby_dep
gem 'yard' gem "puppet-blacksmith"
gem 'puppet-strings' gem 'puppet-strings'
gem "travis" if RUBY_VERSION >= '2.1.0'
gem "travis-lint" if RUBY_VERSION >= '2.1.0'
gem 'yard'
end end
group :system_tests do group :system_tests do
gem "beaker" gem "beaker"
gem "beaker-rspec"
gem "beaker-puppet_install_helper" gem "beaker-puppet_install_helper"
gem "beaker-rspec"
end end