From 5870f37f27d38a5e18067800ada29d03df0c49b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Defortis?= Date: Wed, 18 Oct 2017 12:41:31 +0200 Subject: [PATCH] Fix spec tests for bind::chroot::manual - Only works for facts[:os]['name'] == Debian and major > 7 - Declare class ::bind with correct parameters when spec testing bind::chroot::manual --- spec/classes/chroot/manual_spec.rb | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/spec/classes/chroot/manual_spec.rb b/spec/classes/chroot/manual_spec.rb index 379a424..774d70c 100644 --- a/spec/classes/chroot/manual_spec.rb +++ b/spec/classes/chroot/manual_spec.rb @@ -2,10 +2,26 @@ require 'spec_helper' describe 'bind::chroot::manual' do + let(:pre_condition) do + " + class { 'bind': + chroot => true, + default_zones_include => '/etc/named/default-zones.conf', + forwarders => [ + '8.8.8.8', + '8.8.4.4', + ], + dnssec => true, + version => 'Controlled by Puppet', + } + " + end on_supported_os.each do |os, facts| context "on #{os}" do # Only applies to Debian Family for now: - next unless facts[:os]['family'] == 'Debian' + next if facts[:os]['family'] != 'Debian' + next if facts[:os]['name'] != 'Debian' + next if facts[:os]['name'] == 'Debian' and facts[:os]['release']['major'].to_i < 8 let (:facts) {facts} context "with defaults parameters" do it { is_expected.to compile.with_all_deps }