From 827fb1e88f81fd2aa591125e028fd182cf8ff27c Mon Sep 17 00:00:00 2001
From: Nate Riffe <inkblot@movealong.org>
Date: Fri, 1 May 2015 08:01:12 -0500
Subject: [PATCH] Update RRData incrementally

Compute the adds and deletes required to get from existing RRData to new RRData
and perform just those operations instead of doing a complete drop/add of the
entire RRData set. Also during an update, do adds before deletes. This
eliminates the existence gap and fixes #29
---
 lib/puppet_bind/provider/nsupdate.rb | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/lib/puppet_bind/provider/nsupdate.rb b/lib/puppet_bind/provider/nsupdate.rb
index 67c08c7..746bfc6 100644
--- a/lib/puppet_bind/provider/nsupdate.rb
+++ b/lib/puppet_bind/provider/nsupdate.rb
@@ -1,3 +1,4 @@
+# ex: syntax=ruby si sw=2 ts=2 et
 require 'tempfile'
 
 module PuppetBind
@@ -27,8 +28,8 @@ module PuppetBind
       def flush
         return if @properties.empty?
         update do |file|
-          destructo(file)
           accio(file)
+          destructo(file)
         end
       end
 
@@ -58,17 +59,25 @@ module PuppetBind
       end
 
       def accio(file)
-        newdata.each do |datum|
+        rrdata_adds.each do |datum|
           file.write "update add #{name}. #{resource[:ttl]} #{rrclass} #{type} #{datum}\n"
         end
       end
 
       def destructo(file)
-        rrdata.each do |datum|
+        rrdata_deletes.each do |datum|
           file.write "update delete #{name}. #{ttl} #{rrclass} #{type} #{datum}\n"
         end
       end
 
+      def rrdata_adds
+        newdata - rrdata
+      end
+
+      def rrdata_deletes
+        type === 'SOA' ? [] : rrdata - newdata
+      end
+
       def server
         resource[:server]
       end